From: Thomas Andreatta <thomasandreatta2000@gmail.com>
To: dpenkler@gmail.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev,
Thomas Andreatta <thomas.andreatta2000@gmail.com>
Subject: [PATCH 1/8] Staging: gpib: agilent_82357a: changing return type void in int
Date: Thu, 1 May 2025 23:30:30 +0200 [thread overview]
Message-ID: <e902b9d53283d350e6f97399dd3fea646fdb5d88.1746133676.git.thomas.andreatta2000@gmail.com> (raw)
In-Reply-To: <cover.1746133676.git.thomas.andreatta2000@gmail.com>
Patched FIXME request moving the return type from a void to int.
Signed-off-by: Thomas Andreatta <thomas.andreatta2000@gmail.com>
---
drivers/staging/gpib/agilent_82357a/agilent_82357a.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
index da229965d98e..ce2d3850ba31 100644
--- a/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
+++ b/drivers/staging/gpib/agilent_82357a/agilent_82357a.c
@@ -754,8 +754,7 @@ static int agilent_82357a_go_to_standby(struct gpib_board *board)
return 0;
}
-//FIXME should change prototype to return int
-static void agilent_82357a_request_system_control(struct gpib_board *board,
+static int agilent_82357a_request_system_control(struct gpib_board *board,
int request_control)
{
struct agilent_82357a_priv *a_priv = board->private_data;
@@ -765,7 +764,7 @@ static void agilent_82357a_request_system_control(struct gpib_board *board,
int i = 0;
if (!a_priv->bus_interface)
- return; // -ENODEV;
+ return -ENODEV;
usb_dev = interface_to_usbdev(a_priv->bus_interface);
/* 82357B needs bit to be set in 9914 AUXCR register */
@@ -785,7 +784,7 @@ static void agilent_82357a_request_system_control(struct gpib_board *board,
retval = agilent_82357a_write_registers(a_priv, writes, i);
if (retval)
dev_err(&usb_dev->dev, "write_registers() returned error\n");
- return;// retval;
+ return retval;
}
static void agilent_82357a_interface_clear(struct gpib_board *board, int assert)
--
2.34.1
next prev parent reply other threads:[~2025-05-01 21:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 21:30 [PATCH 0/8] Staging: gpib: Update return types and error handling for request_system_control Thomas Andreatta
2025-05-01 21:30 ` Thomas Andreatta [this message]
2025-05-02 7:16 ` [PATCH 1/8] Staging: gpib: agilent_82357a: changing return type void in int Dan Carpenter
2025-05-02 7:35 ` Thomas Andreatta
2025-05-01 21:30 ` [PATCH 2/8] Staging: gpib: Updated return type `request_system_control` Thomas Andreatta
2025-05-02 8:33 ` kernel test robot
2025-05-02 9:25 ` kernel test robot
2025-05-01 21:30 ` [PATCH 3/8] Staging: gpib: Updated return type for `request_system_control` Thomas Andreatta
2025-05-01 21:30 ` [PATCH 4/8] Staging: gpib: Updated return type `ines_request_system_control` Thomas Andreatta
2025-05-01 21:30 ` [PATCH 5/8] Staging: gpib: Updated return type for `ines_request_system_control` Thomas Andreatta
2025-05-01 21:30 ` [PATCH 6/8] Staging: gpib: Updated return type for `request_system_control` Thomas Andreatta
2025-05-01 21:30 ` [PATCH 7/8] Staging: gpib: `request_system_control` error handling in resume Thomas Andreatta
2025-05-01 21:30 ` [PATCH 8/8] Staging: gpib: Optimize error handling in agilent_82357a_driver_resume Thomas Andreatta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e902b9d53283d350e6f97399dd3fea646fdb5d88.1746133676.git.thomas.andreatta2000@gmail.com \
--to=thomasandreatta2000@gmail.com \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=thomas.andreatta2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®