From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012028.outbound.protection.outlook.com [52.101.53.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77AF3325720 for ; Thu, 13 Nov 2025 20:51:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.28 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763067090; cv=fail; b=aq7uvt7YEtcSTzlABvjudOLBDYHu3+F3EA33SS2DAk1xfFE8vHh/ahXqSIOlY0ZFiopUEwwD4jeHUHoYWqi+wlUfm87FcXEMGIGzSGyqGThXOk/H+gBAPwnIn3XDDYKjWjQImyNuLF57e4Yy2dgRYXa1Wy3rWopgEU0yVcjM2tY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763067090; c=relaxed/simple; bh=snAwYxS5ZE/b2JZKUSoSV9F9moNCjRJcc7yIYsjM94A=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=syRs5LZrKoLNJnWyknbMfcgYxj7hTGZT6GMJXlgkVqkuf9Rc551hWA1bdCkjE5gBXAOAgNKz467cWdMg7y3oM71zrgNinnrcGH6v0xUXp+66Kye7VmumXnoftZbhswQRJ5slQmgp41+vZNJyq4grAWWljX6ywE+lto8xQ93sxRc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Vz/DL13j; arc=fail smtp.client-ip=52.101.53.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Vz/DL13j" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=q+4mUp5skha7mmha4uo/l7KIdcQ9eA4qD6Xkl0WFNIriJVhazrnFQGkkODPiBbB+1/vY8F+EkvVH80p596nEJ5OLfNAgZNzwfWPcLcSAU18ixDW2NyLvogGSzpW4fcBwxezSrNIl7gW0qihwWR2NoSoMCGaWwa4twA9gQEbC64BNDrJgqEbxsf3YIap/FSGLOcVVronlYXyXqeJPuBIXADVMoK/ydDffItnGpqx8lmaPEUGUg4YFUpep+MEGjsdKYLDcMTaINyVeBDKELYgZu+NfPOP/AA7HKz0tT+z+ME355rRPvleez63pWi4j1qSadeKEcByuaV4bRPQbNdORYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3apT2FV+o1jh/Z2zj/um7iMWbcT+Bnq1/5ZejIaso18=; b=pFk8KK1Bx3k16MnX7nm2iiO/qXvre3eZ30aH3nlkX+rB6Ejt+u2tvQo5dFTqK2m5ea+H0h+CJ1NEA9jVxJmT6xosOf/kXG/YrCbr6Ku1T0aZJrpISP2KHTm93FwaV/ngbR3i2gFrx/eoHIeRXyUaRzyhLdlJ2KIM6ud4plSaLv0U8l/h98hk68o4JJywF3nsJZZZUp5jV2EWptsXY2K+p+7G63ERb0RIwUxsSIaFr7fNK3RQv4vAbhwOlJudh+MxenDZ/oFqYcM6AQfAovUmdzr3dE+zftMKbilYrKVRPhZZCvE88ne4F37E76qI73axDJ5/OBYxE9vHs+DNM8bE2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3apT2FV+o1jh/Z2zj/um7iMWbcT+Bnq1/5ZejIaso18=; b=Vz/DL13jSWLKw0BYSbdWSU9cXLWJCCnKTY6iUFnWehqpuJhwn3yFskLhJP196skfK+PcPgjAehw/EkGB+4SamW7fJfS6KyY4p358d+ZBKQFHlWVib6kp9GB5tK5okhyt29J4Y1EZyq3Y8h4j59tchW/23pAURrRK2XPSI8PK9HBRsw8k3R1NZQGyz/Q2gfkEjGuou7JccjiAxN0JRdUUQgtmE31DALPO9zUKqtnuLGY/drwUlC+IfiJYBUwyvig1KQg64TVazsdyc7bZOtd3CfllvhseRwlCES7E7hRIyJ33al+aG2oJ8Yba0wQ4QjKtrfW0f+x9gYYATgm/iJhkNw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from PH8PR12MB7277.namprd12.prod.outlook.com (2603:10b6:510:223::13) by MW4PR12MB6998.namprd12.prod.outlook.com (2603:10b6:303:20a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9298.16; Thu, 13 Nov 2025 20:51:23 +0000 Received: from PH8PR12MB7277.namprd12.prod.outlook.com ([fe80::3a4:70ea:ff05:1251]) by PH8PR12MB7277.namprd12.prod.outlook.com ([fe80::3a4:70ea:ff05:1251%7]) with mapi id 15.20.9320.013; Thu, 13 Nov 2025 20:51:23 +0000 Message-ID: Date: Fri, 14 Nov 2025 07:51:15 +1100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fix gpu/drm/nouveau: fix return type in nouveau_dmem_migrate_to_ram() To: "David Hildenbrand (Red Hat)" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, dri-devel@lists.freedesktop.org Cc: kernel test robot , Andrew Morton , Zi Yan , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Oscar Salvador , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Ralph Campbell , =?UTF-8?Q?Mika_Penttil=C3=A4?= , Matthew Brost , Francois Dugast References: <20251113051322.1753532-1-balbirs@nvidia.com> <5bdd8b10-171e-4171-a1f2-43c029dfd8e4@kernel.org> <7d5ff6bf-9e44-41da-a9b9-c5424c569e98@nvidia.com> <48265d08-df2b-48df-959b-d2ed1407ceca@kernel.org> Content-Language: en-US From: Balbir Singh In-Reply-To: <48265d08-df2b-48df-959b-d2ed1407ceca@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SJ0P220CA0027.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:41b::18) To PH8PR12MB7277.namprd12.prod.outlook.com (2603:10b6:510:223::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH8PR12MB7277:EE_|MW4PR12MB6998:EE_ X-MS-Office365-Filtering-Correlation-Id: 3671ac69-58e7-446c-6b3e-08de22f667ef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dU8wRlVYVXpUZ1RRdTE1clN6NUVQd0R0dmtROTBjcG5DQ3RGa1JZQ3V5di9W?= =?utf-8?B?TkdqWmRxTU52T0JvdnRkMkNGREpkamFUKzlBZjdYZjBZTWl3ZFl3TFlUVmNi?= =?utf-8?B?eGI1K2xYMFVnSnZVV3lBbWNzVTllTUk3TkZvdU5rMmpqYmNEdHJ3cU13aURX?= =?utf-8?B?bTBGOEZ1WVI5S3hEMHhUMlhBbVlZM2lwdEFaL0lmYktsOHVqakJLTmhBQ3Rw?= =?utf-8?B?VWVNV1Z3RGp4enVNK09vN09tUHhJUWRLM1l6YndWcDBvTGU0U1JpeUgxNUo3?= =?utf-8?B?ckNORysrcGlyeXNueEQxanRpWlJ3VjBPS2RDeXFsM1pWbzV0OUZPcUowSmxl?= =?utf-8?B?U3V4WWExV2pqUWNRQk5wSU5MWjE5bDJNQUhUNUMxZnlwbTNpQmRKQ05CUGFm?= =?utf-8?B?b1pDQjRydCtIcDNvSXFTUE1acFhvQSswZzFxc213MTJPMk5UN2gxY2JwaHVM?= =?utf-8?B?d1VNUFltaGRZSnB5QzNhT0I1d3RjUWs0amU0WWhkOW1GVEJNTEt0c0dXOTNq?= =?utf-8?B?U1BKMUsvem9EUFNZU2V4LzVwMVZtTVczNFNqZUJYVzRTSXV6bDcxZHBWQWp5?= =?utf-8?B?dmtyL1dnREZaQ0cxWWZaMDlXc0x2YkZSWEI0MjJ4c1RFbjUreGdlSzNPNlNZ?= =?utf-8?B?L3pVcDNSc2VLM3ozY1hjUmNWNGQxOVhQc0pLQy9hZzBrY3R4M0dCMlgyWEQx?= =?utf-8?B?YzBEczMvanR4S1ZtVTNTc3lpRmZudjZIUFU0WEIyaVZzQXRXbk5GVGNwSjZ6?= =?utf-8?B?WERhWUJzdGR0aEg4SUppRSt3YlYxb0ZTcTRDWWR0UHRxTXZ6UnI0d3djTFFN?= =?utf-8?B?MmRCbUpVMHJKSVFSaHFvZERrS3IyNUIxdnFVZm0waE53VDkxaWs4SngrdFMy?= =?utf-8?B?SFlBbnA1MmhiWmtlM04yd010T0t3d0ZDYWdrQzhLVnMrelBxeWR0VE5kTUIy?= =?utf-8?B?djZPTGc1Q25HUmtFdjAvYXlJR1hkMUFHUXFMUmdEOVZ5WER1VWMxd0tMRUJP?= =?utf-8?B?aWpqenVkcytFN1JiZHhkUnc1VlhQUzRSd0xyczA3TVJGeThXWGVQTVc3R1Rr?= =?utf-8?B?WmcwLzZ1R014b1I1U21XTXdHQ0RFN0d2QStNQmRRc3RYWThqSkRoc084N1Fu?= =?utf-8?B?SEFXaHlUakxDdVgzQmV3ZWliQ0Uxb2NiMW5YTGhkeEUvUVFKbE16TEFXSDRI?= =?utf-8?B?Q2JqS0RNT3hzcGNPOUxkTll2YUx2bWNkbUUzK2hRMStlSGhoc2xwMytwaTJ1?= =?utf-8?B?VVE2WTh2anpkUkwwd0VUMm9wK2dSK3F6OWMvbmMvL3NSWDZVbnJrZEFpMVo4?= =?utf-8?B?TUtsaUM0dUVFMEhrZ2ZwelhaU2JLNWZzalFNdWllK2dtVTJOTEhYazRCTCtp?= =?utf-8?B?K0JnTGtJTjBFc1cwaVdDQzBaR1YvZjNycStuN1pCZUM3L3gvYVRQMzQ4amtu?= =?utf-8?B?M0pJdHdZVXhZanhSeVBMekVkR2VLeDBxYnZmWHV3cVp3NUpvVHQzTTJ5dUxk?= =?utf-8?B?N3lRNXdPUWpGZ2NVall4dG9ZR1B2dUUxekV1WUhvNnlJRFBJanhhMExDeURE?= =?utf-8?B?OGI2eWRSVTEydEp2UGVhblV4TEp6dnYrdFFXNzhBR3Y5SzZ3QkdVeWZEZlow?= =?utf-8?B?MmNKZUZIemplcGdPT3MzZUVKalo1cjVMTW1nWUdEK0xSSFVsQTZIUnNVVHEr?= =?utf-8?B?bndxdUtmMis1YUlTNTl6aFNIZXhwRnJDZzlndGhudnJRTCtmb3E1SGZXWkFH?= =?utf-8?B?QXNtbEtQQThvR29DWWtiY3VYSFQ4anBXZmpxY3g1OHZoRHEzSk5OUU5BK093?= =?utf-8?B?REJlVmJ0YTRmSUpPcG5lU2tNaHczbUV2Q2htQUdkdWErOGZ5WllQYTBVNG8r?= =?utf-8?B?bEhTRGVvTTZvYnBOY3RPZktSQ00rVm5zYkFpV09FK0wzYUxISmExQkpPak5R?= =?utf-8?Q?YIlwb9DSfiJYq5MZAqSNSQ4zYBmzhE1r?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH8PR12MB7277.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clZqSW9mVzg5cGwvM2o4VGRjWlJtUC91SUFpUzRSZlROTTBFMlY0anhiWkRF?= =?utf-8?B?QXFjVU0xeUZPNmJiZlJiRGgvN240a3VWREVodGZJVTNKem03T1g1Nzk1QmY1?= =?utf-8?B?bm0rblFBWFZ4WUlQQ1JnZ0NINVNTek5KSEJ2NTF5N2FUclc2b1pjUTlTMmRR?= =?utf-8?B?QmlqVTViS1owSXNKaE41d2s3OVdkY3NsQ1cxT0F0MFBlRFZCbi90dHFBNjQr?= =?utf-8?B?aXNnVUhRSEw1SFRTcE5kL0xTSGFLVm0xU3p1Y2lhWDR2SVRKdWdVdUI4UGpl?= =?utf-8?B?SGY4MTNVdFJTY2xsOFQyK1pGanFaQU1qbks0WWF0dWkyb0xyV2VqRHB0QTNS?= =?utf-8?B?VEtTTW0rUHFvYnRJejJ4SEMrK3dDeDB1VDVxaGZta1VMdzI0M3ZuVEJ2b1hk?= =?utf-8?B?OWJOamp2Y0h5ZUF3TmJrN0QvWVBERFQwS0JNbW8rTlpIU0ZwN1IweDJsTHZm?= =?utf-8?B?VGtzMmYxakhJVWZhNldhSVBIMHVyaGVuSzRobWk0bVIzVXhwMzdTc0pqd2Jo?= =?utf-8?B?dkVGUnVCbUIxVkVyaTNIVy91R2xFS0NOTE1YMFFFOForNlhsUGc2L1hLSTR1?= =?utf-8?B?WTJ4SEFiQVFGK1hwb3d1Ky84Z2J2dmF5Q2ZhRG5lTnRKd0Q2R2xkZ0ZsU21h?= =?utf-8?B?b0g1cm1Gejk0UDd0ZnhnNWhzUi9JekF3YUhOSVBiMHNlVGJuQVZiRU1iVUQ3?= =?utf-8?B?cVUwSVdQTGxLUW5FOURXdVdiRm45T05ISW9NUFJaZU9EZVBoTXpjNGVYTFFR?= =?utf-8?B?RlBPdFJ0MEtGdUYyQm91dXRWbmVyYXRTc0tjbUNINjU2Ujl3ZSt4cHlhWUt1?= =?utf-8?B?ZUkvSmF5QXo3K1lNUGdveDBrRi9FTHZtTUhCVlp6YXFYK3Y1N0NDQ2ptMnRO?= =?utf-8?B?dzlYRFBoVDBPSlROR2c1R1lkMVZSWU5xTGl6TUtlWWFCUTVkUFlMYXBSZllh?= =?utf-8?B?Mk01NW5pbXZYMjgyQ0FEaUkvWms5ZUJZWXA4YXVnMTdWNzVXNmVidU0rZ0tC?= =?utf-8?B?dnFKYmFxZlZvaVRTdkVpVmxpOXUvOW9IYnNkMHptRTllUldkZ2NTQ25TWXpY?= =?utf-8?B?YTFvQ0UzYURNZE5kR2dOK05WbGpQK2RiUVRmbVh4d0RKN2FSZkZCeTU0OCts?= =?utf-8?B?VEZpM01PQWViRzNhY3Bib2lGTC9vQ0o0eW9FOXg3Mzl6R2dvUVNYcGkzSDcy?= =?utf-8?B?ZHgyS3RQZTZEVEhVb2ZNR0t6T3dkVVRYY3dzcm1nb3RYalMySElOWm9pV2hZ?= =?utf-8?B?UEsyVXgvVEhxS2NHUjZLMElWdkpjUk9HTDZZUys4eHhHSnE0VWdxR2dsMzVl?= =?utf-8?B?aVRHWDhFRXprcFpSYm1MUExMU2tjSU9nVGtyMnl1OElmeFNkZ1lqTFdpTjVR?= =?utf-8?B?Z0NsNlRZL3hWeUpROVRWdUJkM0RNTFNNaXd6bDQ1bkthdElpdDgrQW5hVklC?= =?utf-8?B?VnpwY1JBaW5kQi8zZHFSN09YS2NrM0h1aEhCTVBKVGNKUHVjYjZaR0NiODBZ?= =?utf-8?B?cloyLzlWVnpFMFlLS3lzUHhZUjYxNWxrMXh2RFB3TTEwMVREVzh2UStmWk45?= =?utf-8?B?NkhLOWR5UUkyZnB0dUlJVDNwUXJpOTY5bGhVK3lzaDJ1R0NhMncrbDJwMHlq?= =?utf-8?B?bkVsQjlJWVBJQW1vZ0VjWXZjRVFSNHliaFcraWJJSXRXS3V1OHFSQjltdlVj?= =?utf-8?B?Q2JRaXFCSUdkMGh4TEFhVUdxU2twa012dnN5Z0dLaFBxYno3NWRnV1V2T0ls?= =?utf-8?B?M0FDVXFwcFVRcmIxOFdGMG5WUjRXcjdJa1FLQVJUeDlCUEREZUhPcUpONFhm?= =?utf-8?B?SGNnaHdydGJQY1ZCTnFBN2F0aVdBRzA3V0JpWWtZWm9BME4zRlZHMTZsS1JN?= =?utf-8?B?OG1qOE9PWkZjT3BlUFdDcmxXWjJrUG9XQzNmMUMydUh1TkcySUpKV3M5NUpH?= =?utf-8?B?aDVaU3NHVWlSampNeUl2bS9WS2tJR1ZMdmdubVFCbHhPTFJPNUx3WmJZWnow?= =?utf-8?B?c3RMeUxXbGY2RHFVVjBKRU90VXhKaHIyZ2tERUNVL3NleCtyaXBCT093UzJY?= =?utf-8?B?c2JqZXpNUEFpeGl0N2x5c0NlN3c2ZGNmSkdLT21EcmMrSXJ2c0E5dnlYRHhy?= =?utf-8?B?VnRpdndiRCsySFVPRUFmTWgwaVpkcFYxWVUzUXNRb0xuaHhxMmRpdWpOUUc4?= =?utf-8?Q?PchwKAZUJYxb5OqzCkrO0vWhJkKmPHUQX5i7BoeXsDeN?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3671ac69-58e7-446c-6b3e-08de22f667ef X-MS-Exchange-CrossTenant-AuthSource: PH8PR12MB7277.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2025 20:51:23.6010 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xzPCghhn5yc/Entqq2oomJL7UFbFrdVLbk5H2gjpO5E++I/ztPd0toJ9O+PwT/ZmcqVmTmdo5BFpTTJohlRCPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6998 On 11/13/25 22:50, David Hildenbrand (Red Hat) wrote: > On 13.11.25 11:31, Balbir Singh wrote: >> On 11/13/25 20:09, David Hildenbrand (Red Hat) wrote: >>> On 13.11.25 06:13, Balbir Singh wrote: >>>> ret of type vm_fault_t is reused to capture the return value of >>>> nouveau_dmem_copy_folio(), which returns an int. Use a new copy_ret >>>> to fix the issue. The issue is not new, prior to this the function >>>> called was called nouveau_dmem_copy_one() and ret was used to capture >>>> it's value. >>>> >>>> Reported-by: kernel test robot >>>> Closes: https://lore.kernel.org/oe-kbuild-all/202511121922.oP20Lzb8-lkp@intel.com/ >>> >>> It's a sparse warning, is there any runtime effect? >>> >> >> No impact really, it's just a sparse warning > > Okay, then please > > 1) Make that clear in the patch description > > 2) Make that clear in the patch subject. > > In particular, the current subject is weird. Should probably be > > "nouveau/dmem: fix sparse warning in nouveau_dmem_migrate_to_ram()" > I did have "sparse warning" in the subject and checkpatch complained that tools should not be mentioned in the subject, but I'll give it a shot with that. > Change itself LGTM, although I would probably call it "int err" or something like that instead. > Ack, will do that and resend Balbir