From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5166EC38145 for ; Wed, 7 Sep 2022 15:39:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229558AbiIGPjy convert rfc822-to-8bit (ORCPT ); Wed, 7 Sep 2022 11:39:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229985AbiIGPju (ORCPT ); Wed, 7 Sep 2022 11:39:50 -0400 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 258642124F; Wed, 7 Sep 2022 08:39:46 -0700 (PDT) Received: (Authenticated sender: hadess@hadess.net) by mail.gandi.net (Postfix) with ESMTPSA id CE4D740003; Wed, 7 Sep 2022 15:39:43 +0000 (UTC) Message-ID: Subject: Re: [v4 1/5] HID: core: Export hid_match_id() From: Bastien Nocera To: linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , "Peter F . Patel-Schneider" , Filipe =?ISO-8859-1?Q?La=EDns?= , Nestor Lopez Casado Date: Wed, 07 Sep 2022 17:39:43 +0200 In-Reply-To: <20220830132549.7240-1-hadess@hadess.net> References: <20220830132549.7240-1-hadess@hadess.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jiri, If those patches look good to you, would be great to get merged. Benjamin doesn't have the bandwidth to test the patches on his own test hardware right now, but I've been using them daily for a week now. Cheers On Tue, 2022-08-30 at 15:25 +0200, Bastien Nocera wrote: > Export hid_match_id() so it can be used in device-specific drivers to > implement their own matching with open-coding a match function. > > Signed-off-by: Bastien Nocera > --- >  drivers/hid/hid-core.c | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > index b7f5566e338d..72f8d8835b34 100644 > --- a/drivers/hid/hid-core.c > +++ b/drivers/hid/hid-core.c > @@ -2088,6 +2088,7 @@ const struct hid_device_id *hid_match_id(const > struct hid_device *hdev, >   >         return NULL; >  } > +EXPORT_SYMBOL_GPL(hid_match_id); >   >  static const struct hid_device_id hid_hiddev_list[] = { >         { HID_USB_DEVICE(USB_VENDOR_ID_MGE, USB_DEVICE_ID_MGE_UPS) },