mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil+cisco@kernel.org>
To: Shuah Khan <skhan@linuxfoundation.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	Pavan Bobba <opensource206@gmail.com>, shuah <shuah@kernel.org>
Subject: Re: [GIT PULL] Linux Media vimc update for 6.20-rc1
Date: Tue, 13 Jan 2026 10:19:25 +0100	[thread overview]
Message-ID: <e9098813-3b5a-47a1-b1a8-192040093541@kernel.org> (raw)
In-Reply-To: <5e808887-c849-4ccd-8fbf-77d12e3d8730@linuxfoundation.org>

Hi Shuah, Pavan,

On 08/01/2026 22:42, Shuah Khan wrote:
> Hi Mauro,
> 
> Please pull the vimc next update for Linux 6.20-rc1.
> 
> Adds
>      RGB/YUV input entity implementation
>      support for V4L2_FIELD_ALTERNATE in vimc-sensor
>      support for multiple RGB formats in vimc-debayer
>      support custom bytesperline values in vimc-capture
>      document RGB/YUV input entity
> 
> diff is attached.

Unfortunately these vimc changes cause regressions in the vimc test-media test.

This test is run in our CI to catch regressions, so it must always pass.

The test is in the v4l-utils git repository (https://git.linuxtv.org/v4l-utils.git/)
in the contrib/test directory. It's run as: 'sudo ./test-media vimc'.

It could be that these changes require changes in the vimc test itself.
In that case I need a patch for test-media fixing this. However, looking
at the failures I think that at least some of the issues are caused by these
patches.

Since this series adds a new entity, I think that test-media needs to be patched
anyway with a new test that tests this new entity as well.

Running the test-media vimc test results in:

Summary:

Total for vimc device /dev/media4: 8, Succeeded: 8, Failed: 0, Warnings: 0
Total for vimc device /dev/video13: 60, Succeeded: 49, Failed: 11, Warnings: 0
Total for vimc device /dev/video14: 60, Succeeded: 60, Failed: 0, Warnings: 0
Total for vimc device /dev/video15: 60, Succeeded: 49, Failed: 11, Warnings: 0
Total for vimc device /dev/v4l-subdev0: 54, Succeeded: 54, Failed: 0, Warnings: 0
Total for vimc device /dev/v4l-subdev1: 54, Succeeded: 54, Failed: 0, Warnings: 0
Total for vimc device /dev/v4l-subdev2: 61, Succeeded: 59, Failed: 2, Warnings: 0
Total for vimc device /dev/v4l-subdev3: 61, Succeeded: 59, Failed: 2, Warnings: 0
Total for vimc device /dev/v4l-subdev4: 54, Succeeded: 52, Failed: 2, Warnings: 0
Total for vimc device /dev/v4l-subdev5: 61, Succeeded: 61, Failed: 0, Warnings: 0
Total for vimc device /dev/v4l-subdev6: 47, Succeeded: 47, Failed: 0, Warnings: 0
Total for vimc device /dev/v4l-subdev7: 47, Succeeded: 47, Failed: 0, Warnings: 0
Grand Total for vimc device /dev/media4: 627, Succeeded: 599, Failed: 28, Warnings: 0

So I'm dropping this PR.

Regards,

	Hans

> 
> thanks,
> -- Shuah
> 
> ----------------------------------------------------------------
> 
> The following changes since commit 8f0b4cce4481fb22653697cced8d0d04027cb1e8:
> 
>    Linux 6.19-rc1 (2025-12-14 16:05:07 +1200)
> 
> are available in the Git repository at:
> 
>    git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux tags/linux-vimc-6.20-rc1
> 
> for you to fetch changes up to c3a017646b770b76f0f08c96aa74fbc4404ef674:
> 
>    docs: media: vimc: document RGB/YUV input entity (2025-12-15 12:43:25 -0700)
> 
> ----------------------------------------------------------------
> linux-vimc-6.20-rc1
> 
> Adds
>      RGB/YUV input entity implementation
>      support for V4L2_FIELD_ALTERNATE in vimc-sensor
>      support for multiple RGB formats in vimc-debayer
>      support custom bytesperline values in vimc-capture
>      document RGB/YUV input entity
> 
> ----------------------------------------------------------------
> Pavan Bobba (5):
>        media: vimc: add RGB/YUV input entity implementation
>        media: vimc: add support for V4L2_FIELD_ALTERNATE in vimc-sensor
>        media: vimc: debayer: add support for multiple RGB formats
>        media: vimc: capture: support custom bytesperline values
>        docs: media: vimc: document RGB/YUV input entity
> 
>   Documentation/admin-guide/media/vimc.rst       |  39 +++--
>   drivers/media/test-drivers/vimc/Makefile       |   3 +-
>   drivers/media/test-drivers/vimc/vimc-capture.c |  15 +-
>   drivers/media/test-drivers/vimc/vimc-common.h  |   1 +
>   drivers/media/test-drivers/vimc/vimc-core.c    |   3 +-
>   drivers/media/test-drivers/vimc/vimc-debayer.c | 113 ++++++++++---
>   drivers/media/test-drivers/vimc/vimc-input.c   | 210 +++++++++++++++++++++++++
>   drivers/media/test-drivers/vimc/vimc-sensor.c  |   9 +-
>   8 files changed, 352 insertions(+), 41 deletions(-)
>   create mode 100644 drivers/media/test-drivers/vimc/vimc-input.c
> 
> ----------------------------------------------------------------


  reply	other threads:[~2026-01-13  9:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08 21:42 Shuah Khan
2026-01-13  9:19 ` Hans Verkuil [this message]
2026-01-14 15:54   ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9098813-3b5a-47a1-b1a8-192040093541@kernel.org \
    --to=hverkuil+cisco@kernel.org \
    --cc=hverkuil@xs4all.nl \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=opensource206@gmail.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®