From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Luca Weiss <luca.weiss@fairphone.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] clk: qcom: gcc-sm6350: Add missing parent_map for two clocks
Date: Fri, 20 Dec 2024 10:42:07 +0100 [thread overview]
Message-ID: <e909ac59-b2d6-4626-8d4e-8279a691f98a@oss.qualcomm.com> (raw)
In-Reply-To: <20241220-sm6350-parent_map-v1-1-64f3d04cb2eb@fairphone.com>
On 20.12.2024 10:03 AM, Luca Weiss wrote:
> If a clk_rcg2 has a parent, it should also have parent_map defined,
^
freq_tbl
> otherwise we'll get a NULL pointer dereference when calling clk_set_rate
> like the following:
>
> [ 3.388105] Call trace:
> [ 3.390664] qcom_find_src_index+0x3c/0x70 (P)
> [ 3.395301] qcom_find_src_index+0x1c/0x70 (L)
> [ 3.399934] _freq_tbl_determine_rate+0x48/0x100
> [ 3.404753] clk_rcg2_determine_rate+0x1c/0x28
> [ 3.409387] clk_core_determine_round_nolock+0x58/0xe4
> [ 3.421414] clk_core_round_rate_nolock+0x48/0xfc
> [ 3.432974] clk_core_round_rate_nolock+0xd0/0xfc
> [ 3.444483] clk_core_set_rate_nolock+0x8c/0x300
> [ 3.455886] clk_set_rate+0x38/0x14c
>
> Add the parent_map property for two clocks where it's missing and also
> un-inline the parent_data as well to keep the matching parent_map and
> parent_data together.
The patch looks good otherwise
Konrad
next prev parent reply other threads:[~2024-12-20 9:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 9:03 [PATCH 0/2] Add missing parent_map to clocks in SM6350 clock drivers Luca Weiss
2024-12-20 9:03 ` [PATCH 1/2] clk: qcom: gcc-sm6350: Add missing parent_map for two clocks Luca Weiss
2024-12-20 9:42 ` Konrad Dybcio [this message]
2024-12-20 10:21 ` Luca Weiss
2024-12-20 10:28 ` Konrad Dybcio
2024-12-20 9:03 ` [PATCH 2/2] clk: qcom: dispcc-sm6350: Add missing parent_map for a clock Luca Weiss
2024-12-20 9:42 ` Konrad Dybcio
2024-12-20 10:28 ` Konrad Dybcio
2024-12-26 22:38 ` [PATCH 0/2] Add missing parent_map to clocks in SM6350 clock drivers Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e909ac59-b2d6-4626-8d4e-8279a691f98a@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=stable@vger.kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®