From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15065277C9E for ; Wed, 15 Apr 2026 19:57:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776283068; cv=none; b=S1FNNVxVe0+SSR1URMNQ6gBhvgVpAf60TAGXrx511KQ+6lDhn05c/IqJOM4FzHmIsU7vt7rf9+W6sCFv7M2P8HUZ9aTKFiCKOydpkLdDHzn4PxE6aqBhGTjJWcFZtbN+P146YcH+pOT1zgl/ZU3TAaFvE1KbkdsmGeYSAwYkuVc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776283068; c=relaxed/simple; bh=VmAcNb9P3Qr1tYvLopyU/QeEdk/8EC4lozC05QVaB4w=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=HLwWdDLezFJ86uNA8P1FjRdjMfy4XZZqUuLdgkXHjge5pdbdUKFz2uCVcI+rHyL+0MlGmxwNFyjZl+kAbQSt5Rce+ahCLTv4pE6vzXkv1nOna7C9aybXEB6eDpzBfhKMqgDcFZqRZnMiauj8xdZpfDDneThr2cHlFvQY2KLpCSM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iJhDHq1o; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=MD/UYzrX; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iJhDHq1o"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="MD/UYzrX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776283066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O4oSjRXCWU2fv/i32WfN8ZJBnI6Qk7Ic73APVL+9OGw=; b=iJhDHq1o18xndAG+0kH72hLKNRMUGLzR8TnWRWLy8YkmjecQ0j1MHRQ+pdmzc994x2/RGm 7yr6n9lUBtrrLEASlNilAX2ONC4viNTzetZmjPBt0/yVwSDpptfEuGOyHrsUcmaXfcYD4V SXu789dvnLVokTfaswKCmQzu4OeNtNM= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-64-jCwhdo--MT-eYZce4YiSug-1; Wed, 15 Apr 2026 15:57:45 -0400 X-MC-Unique: jCwhdo--MT-eYZce4YiSug-1 X-Mimecast-MFC-AGG-ID: jCwhdo--MT-eYZce4YiSug_1776283064 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-794b240c0d3so253994487b3.0 for ; Wed, 15 Apr 2026 12:57:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776283064; x=1776887864; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=O4oSjRXCWU2fv/i32WfN8ZJBnI6Qk7Ic73APVL+9OGw=; b=MD/UYzrX+Sb22N/G0u7fAeS8ezU6TKjBAirVQMgblVM5ap+e5KiEe4K8o94L4BPCsi Da5eozdLgTvLRgi/UDlZSoKhrIDIaphNO/zHkypOcY6gvhqDHTyv5GCZajliYz44E7h1 yJQ/Ve/hnkwlDk7mvRR74GigEMkEiVtFoJ1++kgLLD+Rc/nQLkteQP/9/NPFE0k+PZNJ dNMd86m+KgCiIDAFwzqb4ss3sVX+ezu/PEBmi/MJLVfyJo+YtvJwYBXGv6O/I+RoeWVY VJQb5dueWJd3ViktYAKAyzyTpVg5XavlGgzlapRR6HBZ4artqfyBNLZLErdI89K28LOu lQeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776283064; x=1776887864; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=O4oSjRXCWU2fv/i32WfN8ZJBnI6Qk7Ic73APVL+9OGw=; b=X0SDed+kuHGstbDANko0fWCAqlCMUtGU1RCMfjjpPFEdxh2l/30WycvkaVrJWYJclN uBIigpzkUUHPNfzQ83UBUygCF+A9/KJ06cajGjZA8VZMMhpQnSUvgK2ziVtMtpvYMsPP Kc4JYmuzFxLY08RX5tTpkfyt3swVVhslvXSGqq3UiLEIEwp+LAt8MKl9C0SaqBtGRrNW VEYF+nU/cDzpA4PZoavZnMAPmzaCZYQaN8ixW+yfUvhgxcduMZ2/o9Z/Q5p6/vV1sWfx s9z5XPl2S3jdtCsiiiQHEpHqg8KrsL2MctBr5i0apZJ5/KD7wREkoM5rEuWOENR3ztDY xi+A== X-Gm-Message-State: AOJu0YwdswcfDE0XX0HwuI0/5Oqeahnt17j5nOAtHqz8FCT2XM54Nocc g28bJ+xNaX8+ZWFYulO+59Jv4NlO30gZX3EtKeAw49LgB0QHP8MxPzAP8AmjUups9SUGP+Q0lYF R8O6B4vFcrc91M0CBk3a1oJDKIHwpA0gTIz7NP+q/nriKz+vxjA3/WngeBcERjE0fYw== X-Gm-Gg: AeBDievUzL+62NnblzM5TaovUAfg/qxtvIjlRfBZ4GOPbGvamirjGoqggv2gwWfNUDD B14dXCFSKaiFOJH+8V7ozE9zRnJz5tP2RWW+BFIGOS2Xmw3Qt14uFtUqix6qg3Wyyqd+dix4dIE 4tfZS7LSadFQUskgo+e3pmZn+WFZrTUE9ajjVbfEHcLnkNSSjWhutHUq5Q70HKeXKLRTeuEOeTP U0BQ1dUkwlPxHPN4f8udAoy6ZjKNbszlSJLjLUD9iUqx88toIEQKTrPsj6EPw+mDTt5BuIk9kJ7 i2Wea9AR9b+pfEprUzayk6GiTKhpibklh8jcVuhxu4iqYGDYlpz2bonPJbOFjoQGZzrLj4rQh/F XjCSR7rDn82RpfXemhK7rTr/JoASqJ2aBE1zNMeeOlsf4w0SYou11S95YwFgxVN8= X-Received: by 2002:a05:690c:6a13:b0:7a2:ce0e:863e with SMTP id 00721157ae682-7b86542b1camr10545947b3.27.1776283064381; Wed, 15 Apr 2026 12:57:44 -0700 (PDT) X-Received: by 2002:a05:690c:6a13:b0:7a2:ce0e:863e with SMTP id 00721157ae682-7b86542b1camr10545747b3.27.1776283063968; Wed, 15 Apr 2026 12:57:43 -0700 (PDT) Received: from li-4c4c4544-0032-4210-804c-c3c04f423534.ibm.com ([2600:1700:6476:1430::29]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7b76941160csm12724327b3.41.2026.04.15.12.57.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 12:57:43 -0700 (PDT) Message-ID: Subject: Re: [EXTERNAL] [PATCH v2 2/7] ceph: use proper endian conversion for flock_len in reconnect From: Viacheslav Dubeyko To: Alex Markuze , ceph-devel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, idryomov@gmail.com Date: Wed, 15 Apr 2026 12:57:41 -0700 In-Reply-To: <20260415170043.3882912-3-amarkuze@redhat.com> References: <20260415170043.3882912-1-amarkuze@redhat.com> <20260415170043.3882912-3-amarkuze@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43app2) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-04-15 at 17:00 +0000, Alex Markuze wrote: > Replace the __force __le32 cast with cpu_to_le32() for the flock_len fiel= d > in reconnect_caps_cb(). The old code used a type-system bypass to silence > sparse; the new form uses the proper endian conversion macro. >=20 > Also switch from a raw bitmask test against i_ceph_flags to test_bit() on > the named CEPH_I_ERROR_FILELOCK_BIT, which is the correct accessor for th= e > unsigned long flags field after the bit-position conversion. >=20 > Signed-off-by: Alex Markuze > --- > fs/ceph/mds_client.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c > index ccf0d53dde2b..871f0eef468d 100644 > --- a/fs/ceph/mds_client.c > +++ b/fs/ceph/mds_client.c > @@ -4693,8 +4693,9 @@ static int reconnect_caps_cb(struct inode *inode, i= nt mds, void *arg) > rec.v2.issued =3D cpu_to_le32(cap->issued); > rec.v2.snaprealm =3D cpu_to_le64(ci->i_snap_realm->ino); > rec.v2.pathbase =3D cpu_to_le64(path_info.vino.ino); > - rec.v2.flock_len =3D (__force __le32) > - ((ci->i_ceph_flags & CEPH_I_ERROR_FILELOCK) ? 0 : 1); > + rec.v2.flock_len =3D cpu_to_le32( > + test_bit(CEPH_I_ERROR_FILELOCK_BIT, > + &ci->i_ceph_flags) ? 0 : 1); > } else { > struct timespec64 ts; > =20 Makes sense. Reviewed-by: Viacheslav Dubeyko Thanks, Slava.