From: "Noralf Trønnes" <noralf@tronnes.org>
To: Meghana Madhyastha <meghana.madhyastha@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Sean Paul <seanpaul@chromium.org>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v16 07/10] drm/panel: Use backlight_enable/disable helpers
Date: Tue, 16 Jan 2018 18:11:13 +0100 [thread overview]
Message-ID: <e919ffdd-c94f-d808-5a89-afdcafd9a5d2@tronnes.org> (raw)
In-Reply-To: <7ade4e0607f04902d6a9cacbe89fea1e99665205.1516098341.git.meghana.madhyastha@gmail.com>
Den 16.01.2018 11.35, skrev Meghana Madhyastha:
> Use backlight_enable/disable helpers instead of changing
> the property and calling backlight_update_status for cleaner
> and simpler code and also to avoid repetitions.
>
> Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
> ---
> drivers/gpu/drm/panel/panel-innolux-p079zca.c | 6 ++----
> drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 6 ++----
> drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 12 ++++--------
> drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 12 ++++--------
> 4 files changed, 12 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-innolux-p079zca.c b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> index 6ba93449f..4c1b29eec 100644
> --- a/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> +++ b/drivers/gpu/drm/panel/panel-innolux-p079zca.c
> @@ -45,8 +45,7 @@ static int innolux_panel_disable(struct drm_panel *panel)
> if (!innolux->enabled)
> return 0;
>
> - innolux->backlight->props.power = FB_BLANK_POWERDOWN;
> - backlight_update_status(innolux->backlight);
> + backlight_disable(innolux->backlight);
>
> err = mipi_dsi_dcs_set_display_off(innolux->link);
> if (err < 0)
> @@ -151,8 +150,7 @@ static int innolux_panel_enable(struct drm_panel *panel)
> if (innolux->enabled)
> return 0;
>
> - innolux->backlight->props.power = FB_BLANK_UNBLANK;
> - ret = backlight_update_status(innolux->backlight);
> + ret = backlight_enable(innolux->backlight);
> if (ret) {
> DRM_DEV_ERROR(panel->drm->dev,
> "Failed to enable backlight %d\n", ret);
> diff --git a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
> index 5b2340ef7..0a94ab79a 100644
> --- a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
> +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c
> @@ -192,8 +192,7 @@ static int jdi_panel_disable(struct drm_panel *panel)
> if (!jdi->enabled)
> return 0;
>
> - jdi->backlight->props.power = FB_BLANK_POWERDOWN;
> - backlight_update_status(jdi->backlight);
> + backlight_disable(jdi->backlight);
>
> jdi->enabled = false;
>
> @@ -289,8 +288,7 @@ static int jdi_panel_enable(struct drm_panel *panel)
> if (jdi->enabled)
> return 0;
>
> - jdi->backlight->props.power = FB_BLANK_UNBLANK;
> - backlight_update_status(jdi->backlight);
> + backlight_enable(jdi->backlight);
>
> jdi->enabled = true;
>
> diff --git a/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c b/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c
> index 3cce3ca19..1512ec4f3 100644
> --- a/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c
> +++ b/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c
> @@ -96,10 +96,8 @@ static int sharp_panel_disable(struct drm_panel *panel)
> if (!sharp->enabled)
> return 0;
>
> - if (sharp->backlight) {
> - sharp->backlight->props.power = FB_BLANK_POWERDOWN;
> - backlight_update_status(sharp->backlight);
> - }
> + if (sharp->backlight)
No need for a NULL check, backlight_enable/disable() already does that.
The same goes for the rest of the patch.
Noralf.
> + backlight_disable(sharp->backlight);
>
> sharp->enabled = false;
>
> @@ -263,10 +261,8 @@ static int sharp_panel_enable(struct drm_panel *panel)
> if (sharp->enabled)
> return 0;
>
> - if (sharp->backlight) {
> - sharp->backlight->props.power = FB_BLANK_UNBLANK;
> - backlight_update_status(sharp->backlight);
> - }
> + if (sharp->backlight)
> + backlight_enable(sharp->backlight);
>
> sharp->enabled = true;
>
> diff --git a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c
> index 3aeb0bda4..a6af3257f 100644
> --- a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c
> +++ b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c
> @@ -117,10 +117,8 @@ static int sharp_nt_panel_disable(struct drm_panel *panel)
> if (!sharp_nt->enabled)
> return 0;
>
> - if (sharp_nt->backlight) {
> - sharp_nt->backlight->props.power = FB_BLANK_POWERDOWN;
> - backlight_update_status(sharp_nt->backlight);
> - }
> + if (sharp_nt->backlight)
> + backlight_disable(sharp_nt->backlight);
>
> sharp_nt->enabled = false;
>
> @@ -203,10 +201,8 @@ static int sharp_nt_panel_enable(struct drm_panel *panel)
> if (sharp_nt->enabled)
> return 0;
>
> - if (sharp_nt->backlight) {
> - sharp_nt->backlight->props.power = FB_BLANK_UNBLANK;
> - backlight_update_status(sharp_nt->backlight);
> - }
> + if (sharp_nt->backlight)
> + backlight_enable(sharp_nt->backlight);
>
> sharp_nt->enabled = true;
>
next prev parent reply other threads:[~2018-01-16 17:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 10:31 [PATCH v16 00/10] Add backlight helper functions Meghana Madhyastha
2018-01-16 10:31 ` [PATCH v16 01/10] video: backlight: Add helpers to enable and disable backlight Meghana Madhyastha
2018-01-16 16:50 ` Noralf Trønnes
2018-01-17 17:00 ` Daniel Thompson
2018-01-17 21:24 ` Daniel Vetter
2018-01-17 22:03 ` Noralf Trønnes
2018-01-18 10:59 ` Meghana Madhyastha
2018-01-18 12:02 ` Daniel Thompson
2018-01-16 10:32 ` [PATCH v16 02/10] drm/tinydrm: Convert tinydrm_enable/disable_backlight to backlight_enable/disable Meghana Madhyastha
2018-01-16 16:51 ` Noralf Trønnes
2018-01-16 10:33 ` [PATCH v16 03/10] video: backlight: Add of_find_backlight helper in backlight.c Meghana Madhyastha
2018-01-16 16:56 ` Noralf Trønnes
2018-01-17 17:01 ` Daniel Thompson
2018-01-16 10:34 ` [PATCH v16 04/10] drm/tinydrm: Replace tinydrm_of_find_backlight with of_find_backlight Meghana Madhyastha
2018-01-16 16:59 ` Noralf Trønnes
2018-01-16 10:34 ` [PATCH v16 05/10] video: backlight: Add devres versions of of_find_backlight Meghana Madhyastha
2018-01-16 17:02 ` Noralf Trønnes
2018-01-17 17:09 ` Daniel Thompson
2018-01-18 11:02 ` Meghana Madhyastha
2018-01-18 11:50 ` Daniel Thompson
2018-01-16 10:34 ` [PATCH v16 06/10] drm/tinydrm: Call devres version " Meghana Madhyastha
2018-01-16 17:03 ` Noralf Trønnes
2018-01-16 10:35 ` [PATCH v16 07/10] drm/panel: Use backlight_enable/disable helpers Meghana Madhyastha
2018-01-16 17:11 ` Noralf Trønnes [this message]
2018-01-16 10:35 ` [PATCH v16 08/10] drm/omapdrm: " Meghana Madhyastha
2018-01-16 10:36 ` [PATCH v16 09/10] drm/panel: Use of_find_backlight helper Meghana Madhyastha
2018-01-16 17:08 ` Noralf Trønnes
2018-01-18 12:07 ` Meghana Madhyastha
2018-01-18 14:51 ` Noralf Trønnes
2018-01-16 10:36 ` [PATCH v16 10/10] drm/omapdrm: " Meghana Madhyastha
2018-01-16 21:46 ` [PATCH v16 00/10] Add backlight helper functions Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e919ffdd-c94f-d808-5a89-afdcafd9a5d2@tronnes.org \
--to=noralf@tronnes.org \
--cc=daniel.thompson@linaro.org \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=meghana.madhyastha@gmail.com \
--cc=seanpaul@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®