mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexey Gladkov <legion@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>,
	Petr Pavlu <petr.pavlu@suse.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Sami Tolvanen <samitolvanen@google.com>,
	Daniel Gomez <da.gomez@samsung.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Nicolas Schier <nicolas.schier@linux.dev>
Cc: linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
	linux-kbuild@vger.kernel.org, linux-scsi@vger.kernel.org,
	Alexey Gladkov <legion@kernel.org>,
	Khalid Aziz <khalid@gonehiking.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: [PATCH v4 5/7] scsi: Always define blogic_pci_tbl structure
Date: Sat, 21 Jun 2025 15:57:17 +0200	[thread overview]
Message-ID: <e9225a5e06b2590ff73ef7b7355e3163517c900a.1750511018.git.legion@kernel.org> (raw)
In-Reply-To: <cover.1750511018.git.legion@kernel.org>

The blogic_pci_tbl structure is used by the MODULE_DEVICE_TABLE macro.
There is no longer a need to protect it with the MODULE condition, since
this no longer causes the compiler to warn about an unused variable.

Cc: Khalid Aziz <khalid@gonehiking.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Suggested-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Alexey Gladkov <legion@kernel.org>
---
 drivers/scsi/BusLogic.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c
index 1f100270cd38..08e12a3d6703 100644
--- a/drivers/scsi/BusLogic.c
+++ b/drivers/scsi/BusLogic.c
@@ -3715,7 +3715,6 @@ static void __exit blogic_exit(void)
 
 __setup("BusLogic=", blogic_setup);
 
-#ifdef MODULE
 /*static const struct pci_device_id blogic_pci_tbl[] = {
 	{ PCI_VENDOR_ID_BUSLOGIC, PCI_DEVICE_ID_BUSLOGIC_MULTIMASTER,
 	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
@@ -3731,7 +3730,6 @@ static const struct pci_device_id blogic_pci_tbl[] = {
 	{PCI_DEVICE(PCI_VENDOR_ID_BUSLOGIC, PCI_DEVICE_ID_BUSLOGIC_FLASHPOINT)},
 	{0, },
 };
-#endif
 MODULE_DEVICE_TABLE(pci, blogic_pci_tbl);
 
 module_init(blogic_init);
-- 
2.49.0


  parent reply	other threads:[~2025-06-21 13:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-21 13:57 [PATCH v4 0/7] Add generated modalias to modules.builtin.modinfo Alexey Gladkov
2025-06-21 13:57 ` [PATCH v4 1/7] module: remove meaningless 'name' parameter from __MODULE_INFO() Alexey Gladkov
2025-06-21 13:57 ` [PATCH v4 2/7] kbuild: always create intermediate vmlinux.unstripped Alexey Gladkov
2025-06-21 13:57 ` [PATCH v4 3/7] kbuild: keep .modinfo section in vmlinux.unstripped Alexey Gladkov
2025-06-21 13:57 ` [PATCH v4 4/7] kbuild: extract modules.builtin.modinfo from vmlinux.unstripped Alexey Gladkov
2025-06-21 13:57 ` Alexey Gladkov [this message]
2025-06-21 13:57 ` [PATCH v4 6/7] modpost: Add modname to mod_device_table alias Alexey Gladkov
2025-06-21 14:48   ` Miguel Ojeda
2025-06-21 15:20   ` Miguel Ojeda
2025-06-21 16:10     ` Alexey Gladkov
2025-06-23  6:15     ` FUJITA Tomonori
2025-06-21 13:57 ` [PATCH v4 7/7] modpost: Create modalias for builtin modules Alexey Gladkov
2025-07-14 13:41 ` [PATCH v4 0/7] Add generated modalias to modules.builtin.modinfo Alexey Gladkov
2025-07-15 16:23   ` Masahiro Yamada
2025-07-16 10:40     ` Alexey Gladkov
2025-07-22 10:05     ` Alexey Gladkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9225a5e06b2590ff73ef7b7355e3163517c900a.1750511018.git.legion@kernel.org \
    --to=legion@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=da.gomez@samsung.com \
    --cc=khalid@gonehiking.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=masahiroy@kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=nathan@kernel.org \
    --cc=nicolas.schier@linux.dev \
    --cc=petr.pavlu@suse.com \
    --cc=samitolvanen@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®