From: Joe Perches <joe@perches.com>
To: Jonathan Cameron <jic23@kernel.org>,
Marcelo Schmitt <marcelo.schmitt1@gmail.com>
Cc: lars@metafoo.de, knaack.h@gmx.de, pmeerw@pmeerw.net,
gregkh@linuxfoundation.org, michael.hennerich@analog.com,
stefan.popa@analog.com, alexandru.Ardelean@analog.com,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com
Subject: Re: [PATCH v5 2/2] staging: iio: ad5933: move out of staging
Date: Sun, 24 Mar 2019 11:01:22 -0700 [thread overview]
Message-ID: <e922a949de93202ac4b4c9d0548fd288efbad2c1.camel@perches.com> (raw)
In-Reply-To: <20190324163828.1acf5945@archlinux>
On Sun, 2019-03-24 at 16:38 +0000, Jonathan Cameron wrote:
> > diff --git a/drivers/iio/impedance-analyzer/ad5933.c b/drivers/iio/impedance-analyzer/ad5933.c
trivial note:
> > +static void ad5933_calc_out_ranges(struct ad5933_state *st)
> > +{
> > + int i;
> > + unsigned int normalized_3v3[4] = {1980, 198, 383, 970};
This could be static const which would make the code smaller.
prev parent reply other threads:[~2019-03-24 18:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 18:41 [PATCH v5 0/2] " Marcelo Schmitt
2019-03-21 18:42 ` [PATCH v5 1/2] staging: iio: ad5933: change attributes to match ABI Marcelo Schmitt
2019-03-24 16:34 ` Jonathan Cameron
2019-03-21 18:42 ` [PATCH v5 2/2] staging: iio: ad5933: move out of staging Marcelo Schmitt
2019-03-24 16:38 ` Jonathan Cameron
2019-03-24 18:01 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e922a949de93202ac4b4c9d0548fd288efbad2c1.camel@perches.com \
--to=joe@perches.com \
--cc=alexandru.Ardelean@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=kernel-usp@googlegroups.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=michael.hennerich@analog.com \
--cc=pmeerw@pmeerw.net \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®