From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6709364EB1 for ; Fri, 6 Feb 2026 10:07:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770372467; cv=none; b=bVxNr9yUaw6PaCJtpjLJctz0mrdhgz4dN0gVXSkOdxqOmqbXUS9lw/Cn0QiD98Q3MOaW2MH606hA0Pk5ywTTApAvNE0CaSfWTQULS2cbVwtpyUgrwMUVTxgTsvSSt4AlbSGMaBodpV/41MimezEMhzEDC2BuRXBkUUVbTWliNO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770372467; c=relaxed/simple; bh=jEvq53oMrqYEeQzv/eC2eWqajMXwQAx8xtAP8owsnCw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t/xUky3eEZk0o7f5Ly+tCxr3l1rPxaFkoW3tvpJlCCbVLR0ylQCKvJi6p0u7jRwxJfmvZWLgizyFH6wRTyhRaJtpgYHTtCm+60lPbItyAlxxbpk6FBniF2hByK2+fa3KnUqIkmQ0NLbKPeUW3R6VUJgfO1hhMh+VRkwQCBSeRqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=NX96ooyp; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="NX96ooyp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1770372465; bh=jEvq53oMrqYEeQzv/eC2eWqajMXwQAx8xtAP8owsnCw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=NX96ooypTynCmlKwtCAw/NkQRt9pF6gUhxECWCD71nzy+bBzRlYeKqKdsx5MSgYmx x/qTUhqfx1HhbZr9tcunJ0eP2c9zkunmy4pLmvnd00t3u620LR83QE4ldcaiZbIJWE 5YeHqNczrsaIaDRf29ywn7Vas3BS9BNp5xVpZu8YbX2Qb58X0XyYptfdPtnblhRylJ zla2Pd0kJBJzwtJT0UqfCckpFIoZSb41OLuiggBkSrhs/VuuZdvqydAPIvI63avUO+ /2wQqoEdyVfpw3RsP3mMY5lJDGjABXlBu3twmLwAwM5D35lMc/AcIDVUGbJ4W6HfAj tV3H/1AqP4Nbw== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 7CFC517E14F5; Fri, 6 Feb 2026 11:07:44 +0100 (CET) Message-ID: Date: Fri, 6 Feb 2026 11:07:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/11] drm/mediatek: ovl: Enable per-plane color operations on MT8195 To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, daniels@collabora.com, ariel.dalessandro@collabora.com, kernel@collabora.com References: <20251223-mtk-ovl-pre-blend-colorops-v1-0-0cb99bd0ab33@collabora.com> <20251223-mtk-ovl-pre-blend-colorops-v1-4-0cb99bd0ab33@collabora.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20251223-mtk-ovl-pre-blend-colorops-v1-4-0cb99bd0ab33@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Il 23/12/25 20:44, Nícolas F. R. A. Prado ha scritto: > MT8195's OVL hardware supports per-plane color operations. Enable > support for it in the driver. > > Signed-off-by: Nícolas F. R. A. Prado Agreed, but you're enabling something that doesn't exist. Please move this commit at the end, so that you enable it after it's all implemented. Cheers, Angelo > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > index 46238c21b0ac..cfc6a3154f73 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > @@ -738,6 +738,7 @@ static const struct mtk_disp_ovl_data mt8195_ovl_driver_data = { > .fmt_rgb565_is_0 = true, > .smi_id_en = true, > .supports_afbc = true, > + .supports_plane_colorops = true, > .blend_modes = BIT(DRM_MODE_BLEND_PREMULTI) | > BIT(DRM_MODE_BLEND_COVERAGE) | > BIT(DRM_MODE_BLEND_PIXEL_NONE), >