From: "李晓洁 (Xiaojie Li/13233)" <xiaojie.li2@unisoc.com>
To: Ulf Hansson <ulf.hansson@oss.qualcomm.com>
Cc: "Ulf Hansson" <ulfh@kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"陈文超 (Wenchao Chen)" <Wenchao.Chen@unisoc.com>,
"张如泉 (Rain Zhang)" <Rain.Zhang@unisoc.com>,
"唐月林 (Yuelin Tang)" <yuelin.tang@unisoc.com>,
"cixi.geng@linux.dev" <cixi.geng@linux.dev>
Subject: [PATCH] mmc: core: Modify the CMD1 transmission interval
Date: Mon, 14 Sep 2026 02:49:53 +0000 [thread overview]
Message-ID: <e92f094cbb354956aa0bf78060bd82cc@zeshmbx09.spreadtrum.com> (raw)
In-Reply-To: <CAPx+jO9Sw=pTq-925h0S7Urw2moANp=n+aScfwRxV9Dn642g3Q@mail.gmail.com>
> On Fri, Sep 11, 2026 at 4:45 AM 李晓洁 (Xiaojie Li/13233) <xiaojie.li2@unisoc.com> wrote:
>
> No, that's the whole point. We don't want open coded polling loops, it's just a nightmare to maintain. Please try to extend the existing
>__mmc_poll_for_busy() instead.
Understood. I will stop looking into a dedicated function and focus on extending the existing __mmc_poll_for_busy() to support CMD1's specific requirements.
I will follow up with an update once the code is debugged.
Thank you for your advice and reply.
Best regards,
Xiaojie.Li
-----邮件原件-----
发件人: Ulf Hansson <ulf.hansson@oss.qualcomm.com>
发送时间: 2026年9月11日 23:47
收件人: 李晓洁 (Xiaojie Li/13233) <xiaojie.li2@unisoc.com>
抄送: Ulf Hansson <ulfh@kernel.org>; linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org; 陈文超 (Wenchao Chen) <Wenchao.Chen@unisoc.com>; 张如泉 (Rain Zhang) <Rain.Zhang@unisoc.com>; 唐月林 (Yuelin Tang) <yuelin.tang@unisoc.com>; cixi.geng@linux.dev
主题: Re: [PATCH] mmc: core: Modify the CMD1 transmission interval
注意: 这封邮件来自于外部。除非你确定邮件内容安全,否则不要点击任何链接和附件。
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
On Fri, Sep 11, 2026 at 4:45 AM 李晓洁 (Xiaojie Li/13233) <xiaojie.li2@unisoc.com> wrote:
>
> Hi Uffe:
> Thank you for your reply.
> However, I noticed that __mmc_poll_for_busy() and mmc_poll_for_busy() are invoked either directly or indirectly by many other functions within the MMC driver.
> Modifying them directly could potentially introduce unintended side effects.
>
> Would it be acceptable to implement a dedicated function specifically for CMD1? We could create a CMD1-specific variant based on the existing __mmc_poll_for_busy().
> This approach would significantly minimize the potential impact on the rest of the codebase.
No, that's the whole point. We don't want open coded polling loops, it's just a nightmare to maintain. Please try to extend the existing
__mmc_poll_for_busy() instead.
And next time, please don't top post.
[...]
Kind regards
Uffe
prev parent reply other threads:[~2026-09-14 2:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 9:14 Xiaojie Li
2026-09-10 7:10 ` 李晓洁 (Xiaojie Li/13233)
2026-09-10 13:00 ` Ulf Hansson
2026-09-11 2:44 ` 答复: " 李晓洁 (Xiaojie Li/13233)
2026-09-11 15:46 ` Ulf Hansson
2026-09-14 2:49 ` 李晓洁 (Xiaojie Li/13233) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e92f094cbb354956aa0bf78060bd82cc@zeshmbx09.spreadtrum.com \
--to=xiaojie.li2@unisoc.com \
--cc=Rain.Zhang@unisoc.com \
--cc=Wenchao.Chen@unisoc.com \
--cc=cixi.geng@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@oss.qualcomm.com \
--cc=ulfh@kernel.org \
--cc=yuelin.tang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®