mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Rengarajan.S@microchip.com>
To: <jirislaby@kernel.org>, <linux-serial@vger.kernel.org>,
	<gregkh@linuxfoundation.org>, <UNGLinuxDriver@microchip.com>,
	<Kumaravel.Thiagarajan@microchip.com>,
	<linux-kernel@vger.kernel.org>,
	<Tharunkumar.Pasumarthi@microchip.com>
Subject: Re: [PATCH v1 tty] 8250: microchip: pci1xxxx: Refactor TX Burst code to use pre-existing APIs
Date: Fri, 23 Feb 2024 09:21:27 +0000	[thread overview]
Message-ID: <e93048e64c3f8aa2731575d4b296c473e8dadb82.camel@microchip.com> (raw)
In-Reply-To: <5bf4ba6d-d8e3-4ba6-a889-cfae8c3ddabe@kernel.org>

On Fri, 2024-02-23 at 07:08 +0100, Jiri Slaby wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> On 22. 02. 24, 14:49, Rengarajan S wrote:
> > Updated the TX Burst implementation by changing the circular buffer
> > processing with the pre-existing APIs in kernel. Also updated
> > conditional
> > statements and alignment issues for better readability.
> 
> Hi,
> 
> so why are you keeping the nested double loop?
> 

Hi, in order to differentiate Burst mode handling with byte mode had
seperate loops for both. Since, having single while loop also does not
align with rx implementation (where we have seperate handling for burst
and byte) have retained the double loop. 

> --
> js
> suse labs
> 


  reply	other threads:[~2024-02-23  9:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22 13:49 Rengarajan S
2024-02-22 16:01 ` Ilpo Järvinen
2024-02-23  9:22   ` Rengarajan.S
2024-02-23  6:08 ` Jiri Slaby
2024-02-23  9:21   ` Rengarajan.S [this message]
2024-02-23  9:26     ` Jiri Slaby
2024-02-23  9:36       ` Rengarajan.S
2024-03-04  4:37       ` Rengarajan.S
2024-03-04  6:19         ` Jiri Slaby
2024-03-05  4:15           ` Rengarajan.S
2024-03-05  7:19             ` Jiri Slaby
2024-03-06  6:55               ` Rengarajan.S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e93048e64c3f8aa2731575d4b296c473e8dadb82.camel@microchip.com \
    --to=rengarajan.s@microchip.com \
    --cc=Kumaravel.Thiagarajan@microchip.com \
    --cc=Tharunkumar.Pasumarthi@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®