From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Phil Auld <pauld@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arch/arm64: Fix topology initialization for core scheduling
Date: Thu, 31 Mar 2022 16:37:50 +0200 [thread overview]
Message-ID: <e93a7d66-7e43-d2c7-ad85-fb24d50effc5@arm.com> (raw)
In-Reply-To: <20220331132103.GB17613@pauld.bos.csb>
On 31/03/2022 15:21, Phil Auld wrote:
> On Thu, Mar 31, 2022 at 11:04:31AM +0200 Dietmar Eggemann wrote:
>> On 30/03/2022 17:56, Phil Auld wrote:
[...]
>> Ah, the reason is that smt_mask is not correctly setup, so we bail on
>> `cpumask_weight(smt_mask) == 1` for !leaders in:
>>
>> notify_cpu_starting()
>> cpuhp_invoke_callback_range()
>> sched_cpu_starting()
>> sched_core_cpu_starting()
>>
>> which leads to rq->core not being correctly set for !leader-rq's.
>>
>
> Exactly, sorry I was not clearer. smt_mask must be setup correctly
> by the time sched_core_cpu_starting() is called. (Maybe I should crib
> some of the above lines into the commit message?)
Yeah, maybe, it wouldn't hurt I guess. IMHO mentioning stress-ng's prctl
needs PR_SCHED_CORE support could also be handy since today's stress-ng
packages don't seem to have this yet.
next prev parent reply other threads:[~2022-03-31 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 15:56 Phil Auld
2022-03-31 9:04 ` Dietmar Eggemann
2022-03-31 13:21 ` Phil Auld
2022-03-31 14:37 ` Dietmar Eggemann [this message]
2022-03-31 14:53 ` Phil Auld
2022-03-31 15:49 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e93a7d66-7e43-d2c7-ad85-fb24d50effc5@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®