From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D130C433F5 for ; Wed, 1 Jun 2022 08:37:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350870AbiFAIhU (ORCPT ); Wed, 1 Jun 2022 04:37:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347154AbiFAIhL (ORCPT ); Wed, 1 Jun 2022 04:37:11 -0400 X-Greylist: delayed 516 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 01 Jun 2022 01:37:09 PDT Received: from smtp-bc09.mail.infomaniak.ch (smtp-bc09.mail.infomaniak.ch [IPv6:2001:1600:3:17::bc09]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C959721819 for ; Wed, 1 Jun 2022 01:37:09 -0700 (PDT) Received: from smtp-2-0000.mail.infomaniak.ch (unknown [10.5.36.107]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4LCj3106knzMprL9; Wed, 1 Jun 2022 10:28:29 +0200 (CEST) Received: from [10.0.0.141] (unknown [31.10.206.125]) by smtp-2-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4LCj300xmMzlhs7p; Wed, 1 Jun 2022 10:28:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pschenker.ch; s=20220412; t=1654072108; bh=Mxe97A1GNK58/rOoNSBOXmeHmHULjXJ31P/mKWrLzv4=; h=Subject:From:Reply-To:To:Cc:Date:In-Reply-To:References:From; b=I+VDQNdDVJO53tsfUev2HYDDi2xbfy+3H92LPzqKmqJBf57b1oH/UVgYjGKgs4Pdb wU0PTT2ybRQi5XSUqyvtb5AsTfFbuzSk7vdgjuDSSpSB2YqoIfjAWzqEYcQ/xBhJEP ChW2tB1NS/RJdQL+nA3t7oXYxTR0ukB7FXRaO9c8= Message-ID: Subject: Re: [PATCH] Revert "mt76: mt7921: enable aspm by default" From: Philippe Schenker Reply-To: dev@pschenker.ch To: Deren Wu , Kalle Valo Cc: linux-wireless@vger.kernel.org, Felix Fietkau , linux@leemhuis.info, "David S. Miller" , Jakub Kicinski , Lorenzo Bianconi , Matthias Brugger , Paolo Abeni , Ryder Lee , Sean Wang , Shayne Chen , YN Chen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org Date: Wed, 01 Jun 2022 10:28:27 +0200 In-Reply-To: <668f1310cc78b17c24ce7be10f5f907d5578e280.camel@mediatek.com> References: <20220412090415.17541-1-dev@pschenker.ch> <87y20aod5d.fsf@kernel.org> <668f1310cc78b17c24ce7be10f5f907d5578e280.camel@mediatek.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2022-04-12 at 19:06 +0800, Deren Wu wrote: > On Tue, 2022-04-12 at 12:37 +0300, Kalle Valo wrote: > > Philippe Schenker writes: > >=20 > > > This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8. > > >=20 > > > This commit introduces a regression on some systems where the > > > kernel is > > > crashing in different locations after a reboot was issued. > > >=20 > > > This issue was bisected on a Thinkpad P14s Gen2 (AMD) with latest > > > firmware. > > >=20 > > > Link:=20 > > > https://urldefense.com/v3/__https://lore.kernel.org/linux-wireless/50= 77a953487275837e81bdf1808ded00b9676f9f.camel@pschenker.ch/__;!!CTRNKA9wMg0A= Rbw!09tjyaQlMci3fVI3yiNiDJKUW_qwNA_CbVhoAraeIX96B99Q14J4iDycWA9cq36Y$ > > > =C2=A0 > > > Signed-off-by: Philippe Schenker > >=20 > > Can I take this to wireless tree? Felix, ack? > >=20 > > I'll also add: > >=20 > > Fixes: bf3747ae2e25 ("mt76: mt7921: enable aspm by default") > >=20 >=20 > Hi Kalle, >=20 > We have a patch for a similar problem. Can you wait for the > verification by Philippe? > Commit 602cc0c9618a81 ("mt76: mt7921e: fix possible probe failure > after > reboot") > Link:=20 > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit= /drivers/net/wireless/mediatek/mt76?id=3D602cc0c9618a819ab00ea3c9400742a0ca= 318380 >=20 > I can reproduce the problem in my v5.16-rc5 desktop. And the issue can > be fixed when the patch applied. >=20 >=20 > Hi Philippe, >=20 > Can you please help to check the patch in your platform? Hi Kalle and Deren, I just noticed on my system and mainline v5.18 reboots do now work however Bluetooth is no longer accessible after a reboot. Reverting commit bf3747ae2e25dda6a9e6c464a717c66118c588c8 on top of v5.18 solves this problem for me. @Deren are you aware of this bug? @Kalle Is there a bugtracker somewhere I can submit this? Thanks, Philippe >=20 >=20 > Regards, > Deren >=20