From: <Arun.Ramadoss@microchip.com>
To: <andrew@lunn.ch>, <olteanv@gmail.com>, <davem@davemloft.net>,
<linux@armlinux.org.uk>, <conor+dt@kernel.org>,
<Woojung.Huh@microchip.com>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <f.fainelli@gmail.com>, <kuba@kernel.org>,
<vtpieter@gmail.com>, <UNGLinuxDriver@microchip.com>,
<marex@denx.de>, <edumazet@google.com>, <pabeni@redhat.com>
Cc: <pieter.van.trappen@cern.ch>, <devicetree@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v4 5/5] net: dsa: microchip: apply KSZ87xx family fixes wrt datasheet
Date: Mon, 12 Aug 2024 10:45:50 +0000 [thread overview]
Message-ID: <e93d13b451a263470e93706faa3afbfe2b5cd57b.camel@microchip.com> (raw)
In-Reply-To: <20240812084945.578993-6-vtpieter@gmail.com>
Hi Pieter,
@@ -141,7 +141,7 @@ static struct sk_buff *ksz8795_rcv(struct sk_buff
> *skb, struct net_device *dev)
> {
> u8 *tag = skb_tail_pointer(skb) - KSZ_EGRESS_TAG_LEN;
>
> - return ksz_common_rcv(skb, dev, tag[0] & 7,
> KSZ_EGRESS_TAG_LEN);
> + return ksz_common_rcv(skb, dev, tag[0] & 3,
> KSZ_EGRESS_TAG_LEN);
> }
This change can be separate patch. since it is not related to
ksz87xx_dev_ops structure. Is it a fix or just good to have one. If it
is a fix then it should be point to net tree.
>
> static const struct dsa_device_ops ksz8795_netdev_ops = {
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-08-12 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 8:49 [PATCH net-next v4 0/5] net: dsa: microchip: ksz8795: add Wake on LAN support vtpieter
2024-08-12 8:49 ` [PATCH net-next v4 1/5] dt-bindings: net: dsa: microchip: add microchip,pme-active-high flag vtpieter
2024-08-12 8:49 ` [PATCH net-next v4 2/5] net: dsa: microchip: move KSZ9477 WoL functions to ksz_common vtpieter
2024-08-12 8:49 ` [PATCH net-next v4 3/5] net: dsa: microchip: generalize KSZ9477 WoL functions at ksz_common vtpieter
2024-08-12 8:49 ` [PATCH net-next v4 4/5] net: dsa: microchip: add WoL support for KSZ87xx family vtpieter
2024-08-12 10:39 ` Arun.Ramadoss
2024-08-12 8:49 ` [PATCH net-next v4 5/5] net: dsa: microchip: apply KSZ87xx family fixes wrt datasheet vtpieter
2024-08-12 10:45 ` Arun.Ramadoss [this message]
2024-08-12 10:55 ` Pieter
2024-08-12 14:29 ` Arun.Ramadoss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e93d13b451a263470e93706faa3afbfe2b5cd57b.camel@microchip.com \
--to=arun.ramadoss@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pieter.van.trappen@cern.ch \
--cc=robh@kernel.org \
--cc=vtpieter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®