From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011065.outbound.protection.outlook.com [40.93.194.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EDA0311C05 for ; Mon, 12 Jan 2026 06:48:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.65 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768200527; cv=fail; b=tMX22g9vk1gBalrU3rcpd/WTfofYSLRrOIBA1VRM0NWgH0P+UWPv7GbkoNPS8U0GdXJ77qhzxMjNG0I3Q/zBpFZdjZwvmgTNLNebxTKf6xYZkxYzfVhrueumqbnP0dWaed/gioGJQ1bQKncjifB4pfITmQXfVKzXxG/dPsOWEpk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768200527; c=relaxed/simple; bh=Hk3zxwjqBy+UQi3im3W5MDMFS1YXtbAHJdAi08f+lgI=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=jJduuAxrsnCh/6driw274qc19dd0ER7Ivd/KidntnDyhutY1vJGV27DOdEyWsDryAmOSvm5ycaqh+qbT/H/LJEEcimU16sNK+iZNsGuaztMcJaOJemDb4LjlQbDzogpfi28MR3rKb+SBIi2hLkj8grPP0B7tbz3avzEjz3zisdo= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=f2CR1gOu; arc=fail smtp.client-ip=40.93.194.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="f2CR1gOu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=he5i4Y98NzEZ72fI001XD4na/Ry278VdfuyHF2QG0Bf7Ab/sXeT0NC7B4c3aeIPBOInx53X9coz0DD7Cl6VlbMZLKLfYbrgJcz3/Q8kXwnSracxkOAN5/dKhCBx758Yu89pMaFXnKiuQyb9L/3GGxMo3QrPNikOAJW6pp8VQfqZogogr2oZve9LGY5BDs29oPC5AkRYTSxHaCXDutoKM9Rx0oNLPWZ3Nd/Zc4tLyVQNzpstgooWl4IXXurNqJZ699drLNPYryP6WkkkR4DDSx25sSwCKeOIg9cj+ofZnN1D7P1E4Bc3UtNwMzi60vpOufJrIslL1GgUOF3MXndrrnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Z3kErF0dwb9CxJ/EPlLtpvhZ21sul+Shd/+vXyYriw=; b=tjc6vN4qEFRKiQhsZjyKZDqIlZa/Q8r0TATyZ/QQyqyBYTqQZE1jqul3jdwoXXwMA6TCCp1wkr4IPkPMblRE1G9UTYUlXfexB0SNxImqOwi9dPQUf9u7Kmz+KxczIv0X8y1acxz4TUqxwPBp1O2MFxRAANM2rYfZNJkJn148dBQYiElXEeyXihL8oGVF1Bt1bAZ1gLalDGFztYCwv7Y8pySIN7ytJ40uaIZXMKMTbAiSNn/kHx+8uqy1hfD7Cyu5cosQzMg3/85JoKyAsm9l7ie524J7k401mI+Li5qou3l5l7rv4mn8l1RTamxOqVwQJ/lJZpBUdLh5DWrB8OZJzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Z3kErF0dwb9CxJ/EPlLtpvhZ21sul+Shd/+vXyYriw=; b=f2CR1gOuRiwY+uXufu2cU7J4lfRiayIvEWde1n/CVFaczSzLGfWqmvMkP6OuAb9703Nwvx02P6iGlAKVvP/wLD+TM0abDQsBTQJPjl+xIzopacuY/B5rWoOvJvusUEeMc5whIJiCf9bu+m6YXICt0yUrDnvd5zrAMebihuO/MuZ6MGCLkmIbcul7OjkP99eg3Jw5COBZqY//KFPIaq1Xg2GLgZAPQOjbxsbTq0Euz9EbBIoPYptXBvcKrZ87Zc6MfTU8kdCIRvsQ3hpk7cI1YIUBLwtsCRkzVsKXr4Eh//zzpwi5YYpKsfwDJgNBZxdYEsnXhjQTYRYgnUkRSVxzoA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from SA0PR12MB7003.namprd12.prod.outlook.com (2603:10b6:806:2c0::10) by DS7PR12MB5887.namprd12.prod.outlook.com (2603:10b6:8:7a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9499.7; Mon, 12 Jan 2026 06:48:43 +0000 Received: from SA0PR12MB7003.namprd12.prod.outlook.com ([fe80::4099:396e:1f40:169b]) by SA0PR12MB7003.namprd12.prod.outlook.com ([fe80::4099:396e:1f40:169b%4]) with mapi id 15.20.9499.005; Mon, 12 Jan 2026 06:48:42 +0000 Message-ID: Date: Mon, 12 Jan 2026 08:48:37 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] panic: only warn about deprecated panic_print on write access To: Feng Tang Cc: Petr Mladek , Andrew Morton , linux-kernel@vger.kernel.org, Mark Bloch , Nimrod Oren References: <20260106163321.83586-1-gal@nvidia.com> <0107a066-72bb-4632-9129-70dab0707316@nvidia.com> From: Gal Pressman Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: TL2P290CA0015.ISRP290.PROD.OUTLOOK.COM (2603:1096:950:2::18) To SA0PR12MB7003.namprd12.prod.outlook.com (2603:10b6:806:2c0::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA0PR12MB7003:EE_|DS7PR12MB5887:EE_ X-MS-Office365-Filtering-Correlation-Id: c1b4d638-6c10-444b-7bb5-08de51a6a02d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZHhDcm9DK3QrUGhYK21pTVhibEp4aElYR3laQmc2WmxrV2x5Z0ZRZi9VL0lv?= =?utf-8?B?YldRdzNuaC91emxGdDl2Nm9qT2RCMjc3a1dwL0l3MTRuL1ljOXcxcDc2MCs4?= =?utf-8?B?aDY3NlFyeVBjYU9OQnVzYmtRam12NmNPMXc5OGFtNWg2dzI5dHNtQ1ExVjRL?= =?utf-8?B?ZHp3NXVnK1Z0NUdBaC80THk0eCttU1VKNDN1dCsrODg1bHRGSXh4VTZUM3V3?= =?utf-8?B?cS84V1laU29taEo2R0ZKRktYaGgxOXRYRGpCQkZGbkVTVWlnMzNlMXQzTWRw?= =?utf-8?B?UjF0T3BQTEVBb0Q4UEVvNUE3dTYvYlZMeXFTWWtEd0Ztb1VuOXMzbDRydVJR?= =?utf-8?B?MGpWSUt6dTY4TytJU2cyR3pnMHNaS2dudTVUZUs1RDhqV3pQME1QUUpIZ29L?= =?utf-8?B?bkJKTWRoemRVZU5WNk4rbHc2b3Q0ZTBQeEpFQktrSzFSdDZEdVBNSXRJalp5?= =?utf-8?B?akdFUk12N3NGSDFuVVRpeTFhVDFnQ0pUcTlZeTdFU3RraDV4ZW8rVVc1eTVm?= =?utf-8?B?bytPUWkvWi9zUlkwSWtadXZveFBmQUswSGs4OHZ3VjZ1TGdYM3hRQmd5NUNi?= =?utf-8?B?NER3dVlVRUZRSFBGakt5NDgyanVkblVQWEsrVEcyU2ZSUytDVXIwemZsV0lm?= =?utf-8?B?aXR3SVpoemtwR2dmVUxDVWZjUFBjQlUxYU1FeVpOV3FJNEZXb1NQSzRYNVAy?= =?utf-8?B?TlpuQWRKQTNUSjhvakMwcUEvQVVoZWNLS3ZvcmRuZlBRVG5Ha0pDUlF0M2pR?= =?utf-8?B?SUhINU5LYTZVa2h1S2NneUFhTGpVdXFwSVpzYUkxVHNFZzZUYWFWU2E1Z3l3?= =?utf-8?B?bHVsb2FVbjU5ZW9hTHhxRzhlK09zanZhLzVvSkVuRVpZVHk1Sm9Kc3pHaVJX?= =?utf-8?B?TDE4NWNiayttTlFrQVVqSkdYa3ozWHJjQW9najdPdGFEY3VtWXE0ekdib1J3?= =?utf-8?B?QUIzYmdNQTBEcHpGVE92MDh2bitSTGdJNHpOd2JsNk9mTkZXbVAyL3lIOExk?= =?utf-8?B?N1ZXb3g4SExZOGgzNUlFaW56V3d1Z1hoQW5tbEkxclllYzVISmk5SyswbkZT?= =?utf-8?B?VFF2eGJycThWd3NXSHRCQXpaV1U4dXRrT1lmMHg5dC84bDkwbXFoMStsWG5k?= =?utf-8?B?ZldmZ2pjZ3Z3L3JsV1Y1QllFeTM3KzhiTGpudFQrUDdpdy9ZdXcyMk1ZdjJM?= =?utf-8?B?TXFpY21pL2UyNjY0czBzMFUzRTBkQ2lsT0VmUitvU2U4QzI3WDRLM3UxNm9z?= =?utf-8?B?TEZpZW80b0NyVTV3Nm13bGdDWXZQdjFKdkZJclJ5OENuQ05KQUxZMU9HVUMr?= =?utf-8?B?bXlKcWlJVjgvK1BUbzd2Q2ZXWGVNM2I0ZGtHZWRUUVpCdnUzaGpESk9IcFpn?= =?utf-8?B?RlgxelBIUmlkYUZrQlVTV1dpUWYwYXhxWWdEN281SEZ3aVpzSmM1MHJuRkh6?= =?utf-8?B?T3l0UzQ1MDBVMnFKYWkwU2dCZGZxTVhmK3hId1psbjhQU1UyVkNCSWRkRmV5?= =?utf-8?B?cFpzWGVBVlIrUXcyemlIV0hEaVNEQ05GZDRWTFBaZzZDc0xPNGJ2NmFWbEl6?= =?utf-8?B?OW9GTThiZVMxaWZLQVBiMlFqZHlNVTBvajVFcDR5bWFEbWpKZTlWc0xCRlVu?= =?utf-8?B?aXVDcjZNVkpIY3JkQWRnS0F4UkluVi9EajhJbGpEZGh3Wnc5Y0xDenJXcnIy?= =?utf-8?B?Zzc3dlZ1WlJ2U0o4STJDTmRzYXhrWGxhbDVXUzRhd0NxME41ZUpnUkNNNCtw?= =?utf-8?B?RENWc3FCcEZwM1hHYjlZUHVpT0JIdFZGaFRNVTY1bTUvK0VIdm5GUTRZYVZQ?= =?utf-8?B?a2dxTnZzdi9aMXdVbWFoTFZ1bVNqbXA1aXBJS2NGNzVjWTBuQmFYaWIvT2Ez?= =?utf-8?B?M0VRQ3EwRDhPM0thNk9LRFBiMkNSZ0xmcU5FVWZTNHlWUHd0NGRkelJwNjk4?= =?utf-8?Q?WW8S/+WqmsJwIMOZvG5NXoSKi3JMZMAC?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA0PR12MB7003.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGQzQ0dZOTBYdEhEVlVNeURHeTZXN29UZlMrRThHNW43YXZ4YnpXb0wxb3I3?= =?utf-8?B?YjBxN2N5VG9UUFJWbTVRQnM2WjZ6SitXTzJ0RmhrREttb2RKclFaZ2VnYVZy?= =?utf-8?B?enBuOHh3R2h4NTFkZ0Z1WUFnRXltQkx2VzBiSWd0YkVlZWQyZEFuN0IyVnFX?= =?utf-8?B?bElRMlhhOHRpWnQ0WE5SaXRpOTBydG56cHNMRlZUalg1cWxHTkpNZUMyNHhJ?= =?utf-8?B?amFqdWxQc2h4WU1abVZJd2RXYmovUys4VS94QzdnL3dXMjY2R3NYUDEwQnVq?= =?utf-8?B?ZUJ6bE1rR2dFc25qZ0s1ZlhKdUFvT2c4Ymd0Wk9LTFFNUVlieXovMWlvRjJL?= =?utf-8?B?a2FJTFF6Nk03dElZNnV0aWdNbGVJWmtxVThiNGtsSHB6c3lLYlByeDU0YVFD?= =?utf-8?B?NUIxMkcraXV0UkVhWFBVQ0ozMjl6dldpUnkyMVg5aXVsc0pUUWczTlowSHdM?= =?utf-8?B?Q1lJbWh6aWtaZXd3dER1VUZZaUNmR2xlbDRIRWN0TFZkazZROVBjNkpTWXM5?= =?utf-8?B?dmI4L0txdkkyR2dSUU5kVDNqaVkrVmpvTnpXUmxYV212dm1DMjRpaEUxZmVj?= =?utf-8?B?MWhSRHZMODZpelV4RHNreE5ZWDdOTkJtR29CU2NrMThCeHRQenl4R0hVMGNP?= =?utf-8?B?bjc3Y2FLRXVqT1lHVm1oZ2pHaVExMVFmbEJ0Q1FUUVhETWQxOGFyVjZoSzV2?= =?utf-8?B?TVpIR1ZtMVZ3MU5Zbm5DUHVPUTJCVi9lcXdSZHRFUGc5TGhGZHZEb1I4ekZW?= =?utf-8?B?Y1BMSVlKeHF0V3JqdjRlckZmVUZob1JldXJmSjU2RE41VnhDZTB5WVVnUEpW?= =?utf-8?B?Sjljdm9EbVZ6dVB0WTE1R3NIS3ZXbnIrZytZNjlpaDJ6N3ZaRStDSzlmN3I4?= =?utf-8?B?TVduV3pDM1BUd0tiaERWMWszR1VqQ2I2Q0w3ZlVXa2t1MVBnUmU3STFhZGhR?= =?utf-8?B?aEpWVWlXUDBzbkwvaWRyL1N2amh2VU94Rk5ZOGJDRnBtS0JIL0Y2eVRNS2p3?= =?utf-8?B?QkJoRFNYRlVYWjFFbmcxMTBKUXM4VDFTYjVuU001YmoxSWJ6OTlNcG5NeVRS?= =?utf-8?B?cGFKSm42VHlkY2dQTERPVmtjbUpLL29jZWhuanNGbEFCeTZJVXE3Z3VjbDZC?= =?utf-8?B?K2QzR3lKRDlndEs3eXlrTFNnRmFSRmZhSG5lSitKSERWZUlqZ0RTdEhnZjdk?= =?utf-8?B?V0tTT1R1Y0xDWGtSblREOVlIcW12WkI2OC9MaE9wYlZMejZvL2l0aExyQkF0?= =?utf-8?B?dDh3NVdWMmxUNWpHOFl4Sk42cVgyNGErdEZJSkhFNDF2UXpQVWE2T1N5RUcy?= =?utf-8?B?RFhXbzdSRGtnekhTRExyUHRIUWYvY3A3QlF1Sk9BV3RFb1p1UGlseS9UeDVV?= =?utf-8?B?YnkwU25seHVESVoyaE04RExqY1ZOcTZQTEhMdnVFWXNrRDRIbHVBc2lvcnlG?= =?utf-8?B?bzNEZ0J4ZlJvVnVHZUYrTThNcVhlTEMyRzV2SE8vM3V2b0FkUHQ2VWo0dGJY?= =?utf-8?B?UUZ1RjJMbGl0Q0NGWVYyV0c1Y3h3K2JSSDR2ZFlGYmh5cis3Y0daN3BDbkpl?= =?utf-8?B?WGFaekpnMlY4RzZINUdMVm1TTFRKTDJaOE1iQko5dHZLWTBUYmUrZkNNeis4?= =?utf-8?B?RkI2YXd0aUcvUDUwNDlVdERQZGtlYzZudEw5akkzcGlaaU1VNjBaSXhHa3Fk?= =?utf-8?B?djJ5c2hDaGd4VVNyZWZHUkVPT1luVmkyeDRobGsvQ05JZ2cySGRseXpDaENx?= =?utf-8?B?c0x4RDZidmpQakorZFIrK21NQ1ljbm5VUzVUbHNJMWdUbVpZbmsyN3d6WC9G?= =?utf-8?B?VktpbVRJY3hDT2ZpZ3BGZ0kvNkl3eEM4djU2WndYaEV0d3ZodTNDcUxKMEZk?= =?utf-8?B?Ti94VHdEMWFXczJXQitIQjhzNlpWSjZMWkY5V0lyb1o1UlVKU0FGYVVpcDhM?= =?utf-8?B?WThpaXphN1RWaWM5RjRhZGxia2hITzNzQ240b2YveHJ1VTBVZU12OVhReWxw?= =?utf-8?B?UkFIdWZnQitqbzRqNHdsNHZoVnVvNnB4d01nVGpTcjNJSWEyU2RMdDJaKzF6?= =?utf-8?B?OExNZVNHamhKWVkwRFJEditaeTg5QUZ1My8wZm1VN2lLZ0xIam9IQzdQVzcy?= =?utf-8?B?MWlYQ3p0QVg1SUxqRXlhUHVyZFE0L0J1dkdWNzdzaUNnV1d6dGxQQlA5SWkx?= =?utf-8?B?VGx2K3JlKzZlTS9PMnJneTJFdXJQT3RiQ0p5bG5mVHpOZmE1aDNWaVphV29k?= =?utf-8?B?NTRiSW9naHFUbXNLVTRBenRXSGVGSGlOKzloRGlKaGFlOG5sQXZUVDhwRUFp?= =?utf-8?Q?Umlnt9PbNulC6MI5zu?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1b4d638-6c10-444b-7bb5-08de51a6a02d X-MS-Exchange-CrossTenant-AuthSource: SA0PR12MB7003.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2026 06:48:42.8260 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Qsf6PWALTCT0oa2YwaWJbismS4XR4e3L/IXVLPM2tlp8caQLZ9kl3Xu37Bjk6MuY X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5887 On 12/01/2026 5:32, Feng Tang wrote: > On Sun, Jan 11, 2026 at 10:28:55AM +0200, Gal Pressman wrote: >> On 08/01/2026 17:52, Petr Mladek wrote: >>> On Wed 2026-01-07 15:20:44, Feng Tang wrote: >>>> On Wed, Jan 07, 2026 at 08:41:22AM +0200, Gal Pressman wrote: >>>>> On 07/01/2026 5:00, Feng Tang wrote: >>>>>>> @@ -1014,7 +1015,6 @@ static int panic_print_set(const char *val, const struct kernel_param *kp) >>>>>>> >>>>>>> static int panic_print_get(char *val, const struct kernel_param *kp) >>>>>>> { >>>>>>> - panic_print_deprecated(); >>>>>> >>>>>> Actually this was intentional, in one of the patch version, this >>>>>> panic_print_get() was not there but reusing the param_get_ulong(). >>>>>> >>>>>> It was added later as sometimes developer do want to runtime check >>>>>> the current 'panic_print' setting through /sys/module/kernel/parameters/ >>>>>> interface, and I thought it may be better to give the warning. >>>>> >>>>> I figured it would make sense to keep the behaviors consistent. >>> >>> I see. >>> >>>> When people run 'sysctl -a', in 99.9% cases, the users don't care >>>> 'panic_print' or even don't know what 'panic_print' is, that's why >>>> I think removing it makes sense. >>>> >>>> But for a user running 'cat /sys/module/kernel/parameters/panic_rint', >>>> giving a warning is meaningful. >>> >>> Makes perfect sense. >>> >>> We need to make people aware that "panic_print" will eventually go >>> away. 'sysctl -a' is different because it prints all values and >>> there is big chance that the caller is not interested in "panic_print" >>> at all. >>> >>> It makes sense to remove the warning from sysctl read. But I would >>> keep it in sysfs read. >> >> The sysfs entry exhibits the same issue, just different command: >> >> # systool -m kernel -v >> >> Or: >> >> # grep . /sys/module/kernel/parameters/* > > Yes, when user checks the kernel parameters, I think it's better to > give them a notice (it's a pr_info_once(), which only prints once > for the whole power cycle). This log message causes a lot of noise for people who have no idea what panic_print is. We started seeing this print internally, and it took a long time and significant resources to figure out what changed and if we were doing anything wrong in our environments. Seeing a deprecation notice is alarming, especially if you don't know what is being deprecated or how it affects you. In my opinion, we shouldn't print this unless someone actually uses panic_print.