From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DEEC24BBFD for ; Tue, 13 Jan 2026 06:01:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768284089; cv=none; b=bKIXm1WibMqtIuRaGyFG/8Gm38wGKA721xjsvt9bvwvIYw672N5IWxbbshxPN+IBb5Qc0ZzhJXLI5pOWks5W2IxTOArkaXBq2hYh+hwMIrHbh2Vh4hwejYVim6UAW5ur4cH4qsPQMTL8PmmQ3GryvNQEteEeorwW4NQUhtoQT1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768284089; c=relaxed/simple; bh=ExFtf1dq3lSreIpntFmRGLkfTfR1R3Y1ehLQ2GfmSN0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DjZzBeX5eV41uhECsbnRbGtJWpSH9sIjJsCCI+fa0sAy0KYyoanRirqiF/v6ezO6M3GkTQzok03klf3ke79uXtAU0f3dH3ghszDR4tcMFGDsMG5PyLzvKnwVe77CXanEagk59koyqXWpBZ2S9Mj68Uv1PpSeN7+tXkEXfCUNw0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=faCJqzdj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KsJq8/q/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="faCJqzdj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KsJq8/q/" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60CN4w8q3299726 for ; Tue, 13 Jan 2026 06:01:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UE8MfK0gQU/+v4SfmTZbwuu2WaGJyuUhtz4oKoxzIJE=; b=faCJqzdjZysdhUgc zJHG/ANGupldsybM1PgJTYlZ8JBLmqKbNWfSrR2AEHcyIUaQyJWYOdqklLUbmO2f AYp0LrH5jpHBLIaAtUB0jGEvCX5I7Kfj910tupRTsnqRIIJZn31YwU3b9OA8/yn2 4U8gTsBnBlMCLHDriRRzuPs+4a7KfepiRpw7k+BYLjcLlNDu5e839fbblT1+B1/+ wfLQw1fxF5v1jGs2q11ezrWPQOVrG5T+gd8T0EQhO/XvBUZdA5/9Q51e4efeXpUY RpVSNWLHeRvROH+1G1WCs/yTFUU9GHq7lXEtaFA9kbl9GaQZZhQKItu2xYqTxXc8 3ETpnQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bn6jm9jht-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 13 Jan 2026 06:01:26 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8bc4493d315so1883950085a.1 for ; Mon, 12 Jan 2026 22:01:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768284086; x=1768888886; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UE8MfK0gQU/+v4SfmTZbwuu2WaGJyuUhtz4oKoxzIJE=; b=KsJq8/q/U/g+IQXkEDtrBGZu+YkqaZ7d0CT8BLfq+MHFeyVVdbiDYpSXni0W3iQcsn GBsIl//oEk1eWhoORZveUC599eNGvNTTF7fTdSBlDOoLzK+Q2P8dquZEJTlhvykTdadv JifnbPbILGskolRkxdHMI37vKEGH9PAxjvPHR27Fce18OXhcWpdEjP6sfa0uZGkDm2cp OB3XLfeZ3GFJLvuNgNT/7fbr/ETRBSa3Mb9ytIZuFvc3ym4cMbZj2U0rX7uC+u1NmU0E RximaozqyreOuE/ylZ7z5kNEvzYMZHlTnnWlCKyCjTI4BewmMqz6SXKzisfXqjRZN81d qE1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768284086; x=1768888886; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UE8MfK0gQU/+v4SfmTZbwuu2WaGJyuUhtz4oKoxzIJE=; b=LCnUaEeHwu824kHQHjFZzSSgo1TEG+GBFQOOLQ9fwnDyCB63I5P5EVf5GHSGvNXaTH +ugxpNFeB3VGVnHv6ra+Wwd4NzxUUE5BSHHIBOMZDnz38kPrTN5Y52H+GEZ/JlGAW2k9 DLWu57Lb2lPw+4fH34yIuAuW/hwovy2kOYdVJdL06OD9A+pgqQNJR9La9vm4wJHF9V9J WgzbdC4YfvZrJkfY4kM/LhxgxY7g8349n+V41+Lv+wd5dD7WMhslS294s7adWFBHFsRJ 0MVuG/F7W5TpucYPtKngR+Ju5CfJ5C/z1FIh70RM82lliog/kYuzHkEdwyUP2g2mTsOl ubKg== X-Gm-Message-State: AOJu0YwMVFHRtwPDFPYGnEsri4HGubQbtgIi+4X1XhqP7KmQDcD9FObu Dmm/dxG/r2aH8NM3sqejupZHaGZGn7ACRDbRzEyYYW946HXuP0geUrXaBPo51jy760ZKAePR4ZN +J7YVndSMmsHFqtmmPnrBK4xG7tmHwKOPFkAHiggfDc/8nFRMNWyIxrUI0eOebaOgwEI= X-Gm-Gg: AY/fxX4aTWwb8O06bH8qsCk/k+a/jNgSvp/mgrpSFehYwxSL1BPWROPESXcQRr63egt 0WmtYc0/kq13+HXdxD2aH9Kgwmby3FsKwMD4ZV6KZTV66Osjkeq9HGt96W7TktG50iMiVHDvZ0G GmDQ7vrsGgZ/8L25rPK/PRAoOIxHku3AttNN2AT5InonF/FdtvqgFcF789ceKxtHDQg0ONwTIDV 1wnPISPYXCqzgP85ZNlhkvmhA8KmKgD9ERUGIuE42bWvl/Cus2fCr9kPfFUfOu1rms6736S8LuT 62VYyBA62rlegtSqm7ocP0bL17pQWKmd3n5Z3qpyDdABiquouQI2ZCZaQ5eS781kV6XBkxaHNtz X/4DDUx2NW80gH5G4VGv8RQCHceBr8/YtTAiYI1kei4UPAsuejn0QfiKe0SjqTiM9ZjVIRjCy X-Received: by 2002:a05:620a:2a0b:b0:8b3:eb4:720a with SMTP id af79cd13be357-8c3893a28dcmr2960772385a.38.1768284085985; Mon, 12 Jan 2026 22:01:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IEyKSW6/UDtn6iXo+OfnG5T1IMbLQQ6Qo5k6ywT1sJoHyq2E0QCBHbEYFD0ECiXarD+FMZ4Qg== X-Received: by 2002:a05:620a:2a0b:b0:8b3:eb4:720a with SMTP id af79cd13be357-8c3893a28dcmr2960767885a.38.1768284085362; Mon, 12 Jan 2026 22:01:25 -0800 (PST) Received: from [10.38.241.242] (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c37f51bf8csm1649498885a.28.2026.01.12.22.01.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jan 2026 22:01:24 -0800 (PST) Message-ID: Date: Tue, 13 Jan 2026 14:01:20 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 3/3] media: qcom: camss: tpg: Add TPG support for multiple targets To: Bryan O'Donoghue , Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20251226-camss_tpg-v7-0-ccb536734805@oss.qualcomm.com> <20251226-camss_tpg-v7-3-ccb536734805@oss.qualcomm.com> <250743e3-66d8-4a39-a487-947ae1c831b8@linaro.org> Content-Language: en-US From: Wenmeng Liu In-Reply-To: <250743e3-66d8-4a39-a487-947ae1c831b8@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: gLlgJM23LvWJbfNPR3eqMuFL7xw_DboU X-Authority-Analysis: v=2.4 cv=SK1PlevH c=1 sm=1 tr=0 ts=6965dfb6 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=yaJj5qA20OuGLx1VwxsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: gLlgJM23LvWJbfNPR3eqMuFL7xw_DboU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEzMDA0OCBTYWx0ZWRfXw0BOGsbXGbZw VnlBK2ydYmlzaNaCGCRsIJhQZZJg0DReja4NvqZ8KrBpae3QJ8wduXMHvXh3HN/HsXjlNcYgkte /6gPlfqCCFwLgNF6Dn75A/TGQJl0dAHpyweb/59g8UKbkI18uEZ86y2Q43eSfq6KaptimJFLF1v /dwjY0uVRy1eCinq44vnae4wtFvB6HO7/pmUE/BUCOr5MFz7eY5MU82O6ZsM6afTN7XJI5C/+iV 1N/R2aHPF8liffIRd3uDu3d8OHM4VtOBykYWh2UZ6OMpFs8Ex6eTdAMEvGAy8YnOmSxYq62IWY5 kELEKh3Pr2RQlglCO6CC9d/77d/hpqMXHUDtx5qD3oiuDrkYEyl7sa4R/jbBGitXhTBTqf6+bsl gO0oaOBlkp3BSOJZdp7h4E0hYMTJGMoS99AvROvfi96IWyWht1vY+iIwEmt+M/+i7UvuzqsskbZ 0TdqrT/cxXSadL850RA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-13_01,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 clxscore=1015 adultscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601130048 On 1/12/2026 11:43 PM, Bryan O'Donoghue wrote: > On 26/12/2025 09:19, Wenmeng Liu wrote: >> Add support for TPG found on LeMans, Monaco, Hamoa. >> >> Signed-off-by: Wenmeng Liu >> --- >>   drivers/media/platform/qcom/camss/Makefile         |   1 + >>   drivers/media/platform/qcom/camss/camss-csid-680.c |  16 ++ >>   .../media/platform/qcom/camss/camss-csid-gen3.c    |  16 ++ >>   drivers/media/platform/qcom/camss/camss-tpg-gen1.c | 257 +++++++++++ >> ++++++++++ >>   drivers/media/platform/qcom/camss/camss.c          | 128 ++++++++++ >>   5 files changed, 418 insertions(+) > This is causing a regression on Hamoa. > > Did you check the camera itself still streams ? For me, camera streaming > breaks when this patch is applied. > > Please look into this. > > ➞  git bisect good >                 [git:60c1b50b1f2f5] ✖ > 9d1d90cca34ca66617ade951d42c94d5f086717f is the first bad commit > commit 9d1d90cca34ca66617ade951d42c94d5f086717f > Author: Wenmeng Liu > Date:   Fri Dec 26 17:19:12 2025 +0800 > >     media: qcom: camss: tpg: Add TPG support for multiple targets > >     Add support for TPG found on LeMans, Monaco, Hamoa. > >     Signed-off-by: Wenmeng Liu >     Signed-off-by: Bryan O'Donoghue > >  drivers/media/platform/qcom/camss/Makefile          |   1 + >  drivers/media/platform/qcom/camss/camss-csid-680.c  |  16 ++++++++ >  drivers/media/platform/qcom/camss/camss-csid-gen3.c |  16 ++++++++ >  drivers/media/platform/qcom/camss/camss-tpg-gen1.c  | 257 ++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > +++++++++++++++++++++++++++++++++++++++++ >  drivers/media/platform/qcom/camss/camss.c           | 128 ++++++++++++ > ++++++++++++++++++++++++++++++++++++++++++++++++++ >  5 files changed, 418 insertions(+) >  create mode 100644 drivers/media/platform/qcom/camss/camss-tpg-gen1.c > > ➞  git bisect log >                 [git:60c1b50b1f2f5] ✖ > git bisect start > # status: waiting for both good and bad commits > # bad: [2ae8c3645005e9115f39e8aa61dea9ea48cc356e] media: qcom: camss: > add support for SM6150 camss > > git bisect bad 2ae8c3645005e9115f39e8aa61dea9ea48cc356e > # status: waiting for good commit(s), bad commit known > # good: [f89c11002f67740aaed818137d513d6c3dbc348a] dt-bindings: media: > qcom,x1e80100-camss: Add missing regs, clocks, iommus > > git bisect good f89c11002f67740aaed818137d513d6c3dbc348a > # good: [18f74c5866cb470123eb0b39cf3248a09fab3ef9] media: qcom: camss: > Add common TPG support > > git bisect good 18f74c5866cb470123eb0b39cf3248a09fab3ef9 > # bad: [9aaf62e09bb1bb17c186addc49984343623df50e] media: qcom: camss: > csid-340: Fix unused variables > > git bisect bad 9aaf62e09bb1bb17c186addc49984343623df50e > # bad: [9d1d90cca34ca66617ade951d42c94d5f086717f] media: qcom: camss: > tpg: Add TPG support for multiple targets > > git bisect bad 9d1d90cca34ca66617ade951d42c94d5f086717f > # good: [60c1b50b1f2f5466c07aeb4148df25227b5f6d55] media: qcom: camss: > Add link support for TPG > > git bisect good 60c1b50b1f2f5466c07aeb4148df25227b5f6d55 > # first bad commit: [9d1d90cca34ca66617ade951d42c94d5f086717f] media: > qcom: camss: tpg: Add TPG support for multiple targets > > --- > bod The actual result of CSI2_RX_CFG0_TPG_NUM_SEL | CSI2_RX_CFG0_TPG_NUM_EN is 28 | 27 = 31, which is just an integer rather than a mask. Sorry for lack this error code fix. will fix it in next version. Thanks, Wenmeng