Re: [PATCH v4 1/8] KVM: s390: pv: Use VM_SPARSE area for guest variable storage area

[Alexander Gordeev <agordeev@linux.ibm.com>]

On Mon, Jul 20, 2026 at 10:58:27AM +0200, Heiko Carstens wrote:
...
> This assumes that s390 will gain full support for lazy_mmu_mode_enable()
> and lazy_mmu_mode_disable() in the future, since as of now the used
> ptep_get_and_clear() in vunmap_pte_range() does indeed invalidate and
> flush every single pte entry, but only for s390.
...
> +static int uv_alloc_range_cb(pte_t *ptep, unsigned long addr, void *data)
> +{
> +	struct page *page;
> +	pte_t pte;
> +
> +	page = alloc_page(GFP_KERNEL_ACCOUNT | __GFP_ZERO);

In lazy mode this callback is called with preemption disabled, so it leads to:

    [  138.709287] BUG: sleeping function called from invalid context at ./include/linux/sched/mm.h:322
    [  138.709535] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 6092, name: qemu-kvm
    [  138.709540] preempt_count: 1, expected: 0
    [  138.709545] RCU nest depth: 0, expected: 0
    [  138.709549] locks held by qemu-kvm/6092: 1, last CPU#1:
    [  138.709554]  #0: 00000162368b8ba8 (&kvm->lock){+.+.}-{3:3}, at: kvm_s390_handle_pv+0x7c/0xf70 [kvm]
    [  138.709612] Preemption disabled at:
    [  138.709614] [<000002690b609a76>] enter_ipte_range.part.0+0x36/0xb0
    [  138.709627] CPU: 1 UID: 107 PID: 6092 Comm: qemu-kvm Not tainted 7.3.0-20260901.rc1.git22.7cbe5e7f09fc.300.mm.fc44.s390x+debug #1 PREEMPT
    [  138.709629] Hardware name: IBM 3931 A01 701 (LPAR)
    [  138.709630] Call Trace:
    [  138.709631]  [<000002690b5d0d4e>] dump_stack_lvl+0xae/0x108
    [  138.709634]  [<000002690b67bbde>] __might_resched+0x1de/0x2f0
    [  138.709637]  [<000002690ba1d23a>] prepare_alloc_pages+0x1ba/0x220
    [  138.709641]  [<000002690ba1f936>] __alloc_frozen_pages_noprof+0xc6/0x390
    [  138.709643]  [<000002690ba6e9d6>] alloc_pages_mpol+0xe6/0x220
    [  138.709647]  [<000002690ba6f1dc>] alloc_frozen_pages_noprof+0x5c/0x80
    [  138.709649]  [<000002690ba6f222>] alloc_pages_noprof+0x22/0x80
    [  138.709652]  [<000002690b5ef6a0>] uv_alloc_range_cb+0x30/0x300
    [  138.709655]  [<000002690b9d22fa>] apply_to_pte_range+0x11a/0x3b0
    [  138.709656]  [<000002690b9dbf5a>] apply_to_pmd_range+0x13a/0x250
    [  138.709658]  [<000002690b9dcef2>] __apply_to_page_range+0x232/0x4d0
    [  138.709660]  [<000002690b9dd1b8>] apply_to_page_range+0x28/0x40
    [  138.709662]  [<000002690b5eebfe>] uv_alloc_stor_var+0x5e/0x90
    [  138.709664]  [<000002688b73ffe8>] kvm_s390_pv_alloc_vm+0x118/0x1e0 [kvm]
    [  138.709685]  [<000002688b741274>] kvm_s390_pv_init_vm+0x84/0x2e0 [kvm]
    [  138.709705]  [<000002688b71cf92>] kvm_s390_handle_pv+0x502/0xf70 [kvm]
    [  138.709726]  [<000002688b71fd44>] kvm_arch_vm_ioctl+0x234/0xdd0 [kvm]
    [  138.709747]  [<000002688b7070fa>] kvm_vm_ioctl+0x33a/0x890 [kvm]
    [  138.709765]  [<000002690bb046ca>] __s390x_sys_ioctl+0xfa/0x130
    [  138.709767]  [<000002690c78cffc>] __do_syscall+0x1fc/0x700
    [  138.709772]  [<000002690c7a21e2>] system_call+0x72/0x90
    [  138.709774] locks held by qemu-kvm/6092: 1, last CPU#1:
    [  138.709775]  #0: 00000162368b8ba8 (&kvm->lock){+.+.}-{3:3}, at: kvm_s390_handle_pv+0x7c/0xf70 [kvm]

This could be solved using the below fixup:

diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
index 8ea9dd7704ff..9af0358aa7f2 100644
--- a/arch/s390/kernel/uv.c
+++ b/arch/s390/kernel/uv.c
@@ -247,7 +247,9 @@ static int uv_alloc_range_cb(pte_t *ptep, unsigned long addr, void *data)
 	struct page *page;
 	pte_t pte;
 
+	lazy_mmu_mode_pause();
 	page = alloc_page(GFP_KERNEL_ACCOUNT | __GFP_ZERO);
+	lazy_mmu_mode_resume();
 	if (!page)
 		return -ENOMEM;
 	pte = __pte(page_to_phys(page) | pgprot_val(PAGE_KERNEL));

The downside is lazy_mmu_mode_resume() does not really re-enable
the caching and the performance will stay the same even when the
lazy mode is supported on s390.

This is the same pattern as kasan_populate_vmalloc_pte() - which
was the only occurrence so far.

Alternatively, the page could be allocated atomically, but I think
that is less preferrable.

> +	if (!page)
> +		return -ENOMEM;
> +	pte = __pte(page_to_phys(page) | pgprot_val(PAGE_KERNEL));
> +	set_pte(ptep, pte);
> +	return 0;
> +}
> +
> +void *uv_alloc_stor_var(unsigned long size)
> +{
> +	struct vm_struct *area;
> +	unsigned long addr;
> +
> +	size = PAGE_ALIGN(size);
> +	area = get_vm_area(size, VM_SPARSE);
> +	if (!area)
> +		return NULL;
> +	addr = (unsigned long)area->addr;
> +	if (apply_to_page_range(&init_mm, addr, size, uv_alloc_range_cb, NULL))

lazy_mmu_mode_enable_with_ptes() called from apply_to_pte_range()
disables preemption.

> +		goto out;
> +	return area->addr;
> +out:
> +	uv_free_stor_var(area->addr);
> +	return NULL;
> +}
> +EXPORT_SYMBOL_FOR_MODULES(uv_alloc_stor_var, "kvm");

Thanks!