From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDCDC3E3150 for ; Tue, 24 Mar 2026 10:39:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774348744; cv=none; b=hX32PqSvckWLysjbBBNJdexepd6YWna5DpCEyIaG7MG6eI9of6IboU3vatU+c0C43HgF+2Hg2mVNHbfnb8J9d5I21uNzV+RbKtDyPiO7YlOWsqW+604gF6NTw4hKyadul7z0dzuhgNurZGi8bU7qGaCinuO8lRbaUQ/OGv0iXjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774348744; c=relaxed/simple; bh=ji4Q4buCdBt/nwjhvDAVS5p5y2cqvZ0ye4owGzsxLNc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Oj0I0vV709i5DCwtVVQE2mSrO2Fg175TKBMkzthHMlL2eWR72qYFxr+dZ1oFYc0DYhc3+gzYOewsV294wNlLsbKpbu/tIKCV+R+p57Q43MAyDV6brADwLdn/77cw0fuVZzMvgUfvJchtkBLZD0Eq58+jQ6gFVWsmy/wWtAYI1vs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=R2cu2WVj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=X+j5YDmI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="R2cu2WVj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="X+j5YDmI" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62O9Z22m3634272 for ; Tue, 24 Mar 2026 10:39:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2Pmh8hicjiF4UT4+vCZbMqrok0SPFJ1WtADq/O2gJng=; b=R2cu2WVjlP+Du0Nt ros+fY+qR8U+RzBh48yb0XWOgahE5pIcU/cs3QuM6dLyVTyVCrsIXe2Z/ytj9utO m/NIfyJS1e1W+DgUFxUPAEC4NH1K9nuQgZiAkNdMjYkPoNZMeJ6VdfXx9e56JWfC HiFsMQmYdA1HGwmGP+5lAZHbxy0zx0bZoUFHYckNnZmkvqrhfsNAVs4tdAnjExMo j0ltUtb5ljiwmFV2+XRliThNOC7hNMmC3SUeHg3L4w6CewB6jhqHsJcRG6mwFzGU 6y5rPmaXGzw99D28IWEoxLYFXwQhxTeAf881z1qBdnnLAuamlAHIf4mh6G3Nm1vT uUawZQ== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d34k4mmbf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 10:38:59 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-82c649dc145so273894b3a.3 for ; Tue, 24 Mar 2026 03:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774348739; x=1774953539; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2Pmh8hicjiF4UT4+vCZbMqrok0SPFJ1WtADq/O2gJng=; b=X+j5YDmIvKQrxxOu8zwNG8BZOpMa7GhKbI02n+mpMFScNCjuP/Y2NQb/zPPblkpQli yE2RC2BWX0+OCwKtCHy2gQXpO0aicKHP+UyqI2G1LwLK5ET2JRpLS1p+XBtVqdQsBIMo DR4VC3Hssds8b4rqJEEIOoGhht3ZL8lGnCMX6BHCDLSAeTTkDOFUcfclGL5SxKuvA9tH 17p2tvhzU6hEM57hje+26OuUAUyGLwYvJVyVeBRhR2u9GHFnHp8HgnWlEyod13TRLa7G pUj7X5ZcKNLqh4DgmiLMboPCKceCYguiNigkZLJwUywjASNNtABbM1es+p//4PE6X8xQ SWjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774348739; x=1774953539; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2Pmh8hicjiF4UT4+vCZbMqrok0SPFJ1WtADq/O2gJng=; b=N4rUfrkzRqhtvWCWBkw/DJSRCdxkeA24d6RAhbcFbAi1TEbW1M2RzwN+sSxVF5n27K V1z2gMBnjvKhHrUuBy4YUS6+o6hGoJ0FI66qJhIGqK8NCnjq09VmxOnMiL4tRCSJU7FS 32zVHg1BAWbDTeaod4VtwL8vOpRzJUjokDQJ6kfytuCd0jTetLG9gJOKX3hYARq/XBqD lJCksA9gCdaKKqM80/ErSu2y3NwutG2e3YVzsNA+q8yESsNWdIN9XM3jFWsLor4bZkDx 7d4LY/tmzZpcZDEs9DeZhCDqJSnLJPLo5itRb1HtVGeLtgvqwjQQLD8QIYRsJTVYu7zK uBGw== X-Forwarded-Encrypted: i=1; AJvYcCXcTRrME+RYlFPBwkEIQM2Kr30LAOrfZxa0IREWX0rlWm9tVyK+DZlQUEu0M5hg+xUibIF0I96rxQTbBg8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4VAGUfusGTa5VQp5R+ApVJCSVS/VqbUGuUbq6e6ogfj5cvyMG 5p2TC/dxKe+qUrQP6JzX0Zb9oAsKtl141e66OzUmVjS74Ng4fidVFIfA7iA3H2AALoyBZnPxTks 1AQWm18kXgLRVTpcu+FLS+ng358YTWnvFPo/NsBYdvz1liBqyT3Wjq/OVfLSharji8kM= X-Gm-Gg: ATEYQzzylvBTi30fbCxqSOp9BcV/pEvclZoaVznbOgo6CIFowM6CPMBMW4lCAyA3tj8 gH2GOcxTM5b7n7x7J0y4uIzV88sjjOrzCGnAayzD8wV3Vv1QPeM6C6kRkYCt+ZmGmsSj3N8/W91 677gXDEf8JXikxleSwXGrYrOmotouXGSjumuIZRfPDxpMfMSiuSeULsTkWd0pgTHiHeAAi+IN4E NTC0TrXr4oDSK491pd1s3G+jQA9I69AkwBq5ANZT3i50lLJhAZem9raMCJQ5FBEef2PEUGhRC/8 5Ro7HvJjzr546lMQncQKEJ+WYioYM7vFVJ09jSzUuC2L9jUYEniza81a7fij3WGGHf/wplx8kZK ehD7Q+/jTuZscn6a8XEninm8k1gmbiqocl7W3BMYgQY0iaLzuFJjD X-Received: by 2002:a05:6a00:1789:b0:81d:dd3a:b8f5 with SMTP id d2e1a72fcca58-82a8c35dcc8mr13802699b3a.38.1774348738947; Tue, 24 Mar 2026 03:38:58 -0700 (PDT) X-Received: by 2002:a05:6a00:1789:b0:81d:dd3a:b8f5 with SMTP id d2e1a72fcca58-82a8c35dcc8mr13802670b3a.38.1774348738405; Tue, 24 Mar 2026 03:38:58 -0700 (PDT) Received: from [10.218.44.178] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82b040da3easm11603694b3a.41.2026.03.24.03.38.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 03:38:57 -0700 (PDT) Message-ID: Date: Tue, 24 Mar 2026 16:08:48 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 08/11] arm64: dts: qcom: sm8450: Add power-domain and iface clk for ice node To: Harshal Dev , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Krzysztof Kozlowski References: <20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com> <20260323-qcom_ice_power_and_clk_vote-v4-8-e36044bbdfe9@oss.qualcomm.com> Content-Language: en-US From: Kuldeep Singh In-Reply-To: <20260323-qcom_ice_power_and_clk_vote-v4-8-e36044bbdfe9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Z4_cWUgpQMLs3QRfN_eujZcwhZlD4jJB X-Proofpoint-ORIG-GUID: Z4_cWUgpQMLs3QRfN_eujZcwhZlD4jJB X-Authority-Analysis: v=2.4 cv=c+imgB9l c=1 sm=1 tr=0 ts=69c269c3 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=RcdfdvLsBkETvr5PKcUA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDA4NCBTYWx0ZWRfX9lu0u3dZkdeP U1lGZW6vaSZNDmpbczCKYGbfKjb2QIV3UGevrRgxyYEcLrvMBzOp+tZuE7iXE2dNum9kzFH0J9i DbRe6fZDdlt45aSwNtC0DJWSYKPaf1MJkRtZ47YBIC6qYYSCBQTsDna8vrqoUFF9Hawk/Rnq+Iq KVVSQPbGGgPlD2APnVCU8DHcWn+aFwuMU1xD/m32Aai68/F+cz29Nz8VetbW8H4T5wv/AjnW61u KrWH8M0hIlk7mI/YXnFVdJRi3zwQJ1TWj7U9zWB/X50zCwQ0Hox4/dodVWKQzXYlrR2Wh2hnEKy sr/uQSgiMLQNwsljWG5Oa8cTPkdo0FopvxEVu6g2xHJkWXRtvYuHbVulYsTt+THhkPOFkTrDq8/ kJxqpuFdNtKyuVPMnTQ8ohiQzquQ47TUGyivoMa5km/Yu57qUhTW15/wPxREfH/2n+hR34CMXay 6hR89/c1vFxD9+ZxWsw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_02,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 phishscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240084 On 3/23/2026 2:48 PM, Harshal Dev wrote: > Qualcomm in-line crypto engine (ICE) platform driver specifies and votes > for its own resources. Before accessing ICE hardware during probe, to > avoid potential unclocked register access issues (when clk_ignore_unused > is not passed on the kernel command line), in addition to the 'core' clock > the 'iface' clock should also be turned on by the driver. This can only be > done if the UFS_PHY_GDSC power domain is enabled. Specify both the > UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8450. > > Fixes: 86b0aef435851 ("arm64: dts: qcom: sm8450: Use standalone ICE node for UFS") > Reviewed-by: Konrad Dybcio > Signed-off-by: Harshal Dev Reviewed-by: Kuldeep Singh -- Regards Kuldeep