From: Stuart Hayes <stuart.w.hayes@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org, Douglas_Warzecha@Dell.com
Subject: Re: [PATCH v3] dell_rbu: make firmware payload memory uncachable
Date: Fri, 6 Apr 2018 08:02:56 -0500 [thread overview]
Message-ID: <e94e085f-6b66-5a2f-9654-0ba47d13249b@gmail.com> (raw)
In-Reply-To: <s5hsh8ayasq.wl-tiwai@suse.de>
On 4/4/2018 3:30 PM, Takashi Iwai wrote:
> On Wed, 28 Mar 2018 17:07:47 +0200,
> Stuart Hayes wrote:
>>
>> @@ -180,6 +181,12 @@ static int create_packet(void *data, size_t length)
>> invalid_addr_packet_array[idx++] = packet_data_temp_buf;
>> packet_data_temp_buf = NULL;
>> }
>> + /*
>> + * set to uncachable or it may never get written back before
>> + * reboot
>> + */
>> + set_memory_uc((unsigned long)packet_data_temp_buf,
>> + 1 << ordernum);
>
> Won't this cause Oops when the if-condition above meets?
> Namely packet_data_temp_buf is set to NULL there.
>
> Maybe better to try a fault injection to check the error handling.
>
>
> thanks,
>
> Takashi
>
Yes, thank you for catching my mistake.
Stuart
prev parent reply other threads:[~2018-04-06 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 15:07 Stuart Hayes
2018-04-04 20:30 ` Takashi Iwai
2018-04-06 13:02 ` Stuart Hayes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e94e085f-6b66-5a2f-9654-0ba47d13249b@gmail.com \
--to=stuart.w.hayes@gmail.com \
--cc=Douglas_Warzecha@Dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®