From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 010391FF1B5 for ; Thu, 15 Jan 2026 15:54:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768492460; cv=none; b=ARTqWB8pWQQsmugIJBws8vdrj9840uo937+enOny96F0RVv+ademUl7Jus16aGUIZ85xwJQgZ22QmvQCwAf8vQfIowPEG0cJZNymI37QQ3h8OXoFryS76Q25w9mV2x2msARAQuH0JFxWmNfKyz7FTexLsD+TsN/W/F01C6HGuMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768492460; c=relaxed/simple; bh=Ske1nYGRXQK4PyUXkOyknKoa8+u+jcut+L+FXzFSQhA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q4Dyttg7j7HucZd2eVM8KwroE5tR0Ws+Doi8M93Bt1M9FpMA6GQAfaXIFw4WC1nltheozqxAK/OyWMWH5qMPKRr05fpyecQ949jSjvPlOO/oXVoCy3zrkJFAkKsjyMTZ6kSm694tH88xTODNBcN/2ld22HuYCOaqY9cYE+pZFsk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lfAGhMxK; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lfAGhMxK" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-47edd9024b1so6730225e9.3 for ; Thu, 15 Jan 2026 07:54:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768492457; x=1769097257; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=giMlm7L2g+M4CFMM8/nACLMgbMspj8AJvUXN07mxYlg=; b=lfAGhMxKEqvX1CfZ1GJdahUGj/ROD56xC91aK1qQysmzZGEg0v0xLmrXzS+vBXDsX2 OWblT13a3Mompj3Qapc7gIcrpfBkWwzev8UuV9XpVMNdCCRZBj4aumNntkov/95pCtNp U1EflQyGEkYxgpLg8T17aJyoy7pvFX0LJwgvSOpW0rVJseXo2Ih/5pxDUCk9ebGR9JBd OEvy9Gvc9sHdWTfytpsZdBzC6YxxuFAFdA8+PZU4RI8TzP3HEoIa9yWlQOz6ws6LhPLB w0GXt50u9DylYVXWakzDfQRAB3z3rEOzhtdtPLyg39q/0q2Yt/ghJiS+rCfM6B0OwB7v NYwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768492457; x=1769097257; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=giMlm7L2g+M4CFMM8/nACLMgbMspj8AJvUXN07mxYlg=; b=DnobKBP9lvVGQNVk/2urYaxgxkauZfMQXAoDXEJEwNHSYeo3JDxAxTm0q3eyefeI26 26PX3bqTKsCJU1TxL60trl6tOL9hYNEa1splGohhjhCRn+nAdJ+/qC/ufZiddSrL5sb3 QMxRhjZsV0BjKvFvfFnjc5ciqatiqoGiLhjwvAeLsr0u5mnDbAeAoYONnxXPBhFvJRuu SJr/SRdaaY0T8wiSn9Jo5Kdt15bT2bnVtjiP8hNW7kFyWn6TSdAC1BxwSv3MtuGgby52 GkKUj2vfjSCKu7k7laU6Hdoqk1AnHN3jOZGTWfWZK5mNLnsSMj/ngKAndY/WjtoHmqMu KFnA== X-Gm-Message-State: AOJu0YydtRRyxrAbGFHGr7bJ6vGkKTDiFELtc/9RIFoDF+BTKbLqLDaX 5UFQ+Lz1qMSAFDShFFW19Byr6Npj2oUsFs9kdg656ln+2+vc/fPFPTWsAlqtxyWLOGI= X-Gm-Gg: AY/fxX52HYxsaQgeldg0BZ8oGSbt2uOzNLTNgtOUzcjSj/gqn+Dig0DeoxgHOhVGEiL FXJbRFNmRoSojoGHFd6Jrwz9N44jRZTRTpSsS9snm8ZYsQ4kFV6ndOTEh9hFASu5MuSEYnKc+9c bMS4JOCKX8tXC0ugVFJuUX82laIMZwn3tLpvcy7XlbJbCKbxCXj8Gh6qJtaX1Uwjd7ZB4LcBS/1 iDVmdG7VGtbYp5JSXssCoXXWyUJFSvx6VmccFSpN7fDPQeThF35AvQyQSjno8IVmn//OIgIl2AW oVEppLMEd4CEFEDnI0N+i12IRFEZ7XZaWLTV5iBKzzsFuWx4A/col9EauRwbR4nKgsL+0OxwOwO PFwGnOb71a9dZvFDIv4kXL9TlKmr6fIN4SoPFRdE8tYkMuxOeFxDqW4SO4eEC6hO+QS8AvygHJx vdLPU54Uf6xHz3AOTh02OcVCU2ZtNHJOjKv76FY22Qm5rwDFkHKsyyuDprXhp+IJ8= X-Received: by 2002:a05:600c:8b30:b0:480:1aae:676c with SMTP id 5b1f17b1804b1-4801e337219mr2560995e9.18.1768492457318; Thu, 15 Jan 2026 07:54:17 -0800 (PST) Received: from [192.168.0.40] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f42907141sm52933395e9.9.2026.01.15.07.54.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jan 2026 07:54:16 -0800 (PST) Message-ID: Date: Thu, 15 Jan 2026 15:54:15 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 1/3] media: qcom: camss: Add common TPG support To: Vladimir Zapolskiy , Wenmeng Liu , Robert Foss , Todor Tomov , Mauro Carvalho Chehab Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260113-camss_tpg-v8-0-fa2cb186a018@oss.qualcomm.com> <20260113-camss_tpg-v8-1-fa2cb186a018@oss.qualcomm.com> <87a31d4e-b604-4b9a-92e9-75fd2748489a@linaro.org> <98a26638-675b-4654-a940-898ba9e1af9c@oss.qualcomm.com> <641421a6-bf42-49f4-8f94-9cb0bce8e97c@linaro.org> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15/01/2026 02:58, Vladimir Zapolskiy wrote: >>> Writing proper values to registers should be a concern on the driver >>> level, >>> it sounds improper to push this simple task and responsibility to >>> userspace. >> >> I think we should stick to the same format as is already upstream for >> the CSID version of this - which is the same data. >> > > It is not the same and it will not be the same, if the currently presented > version is taken. If TPG modes in CSID are continuous, here they are not, > so it makes a big difference for userspace, and better it should be > removed. Not sure I follow you here. The set of strings for camss-csid we have now is: const char * const csid_testgen_modes[] = { "Disabled", "Incrementing", "Alternating 0x55/0xAA", "All Zeros 0x00", "All Ones 0xFF", "Pseudo-random Data", "User Specified", "Complex pattern", "Color box", "Color bars", NULL }; Wengmeng has +const char * const testgen_payload_modes[] = { + "Disabled", + "Incrementing", + "Alternating 0x55/0xAA", + "Reserved", + "Reserved", + "Pseudo-random Data", + "User Specified", + "Reserved", + "Reserved", + "Color bars", + "Reserved" +}; I think the "Reserved" should go away but, other than that we should keep namespace consistency between CSID-TPG and standalone-TPG. --- bod