From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E20E2D7DDD for ; Mon, 20 Apr 2026 12:49:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776689381; cv=none; b=BzIaaV3oj9kYmgX9m9e4O14fmqL45TqLKi7GsuCHARwe6eINzaLqwxqNA0wTnLa1JlfCUD/siYCNhrPyK+4J02ENzDEGEWWM59mytE/sY/At89Gjh2NuqjYIfj/3UIh2WrGrY5LZvJaByFONafkxcdLcNahuhoNTndlTbuBom1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776689381; c=relaxed/simple; bh=x2+f/NDMEGO1jcf6OLu43Ay4pRcJDh3q9uE/A2+jBcc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HRFRQeKdaj9/bZU5yYLg0AjwHCJK75ULwE3iqfzpx2d9TamWscNCfVECkFudwzqNscQ3nMd7pE7xbchtqUvNJWDkqgAK122IUWTHH1wOi0TgjMqulWqhtru/BTGQzgNyUt4Tfmmzq5lZJ4elmGbOqZypjGLQRr6TbBN1C+Qv4R8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CDqWVq6e; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=H0T4ajrQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CDqWVq6e"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="H0T4ajrQ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63KCbiMO1532092 for ; Mon, 20 Apr 2026 12:49:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sRtwY56nBQbf1x0k86FqJm1BNTc/81FVIoSrk2ABFhU=; b=CDqWVq6e9QRVF6zp I4xFHZNE4Mf8ew6c0GXJAZBqfn8efH/FwUwPjuVOGAiLKx950bvsqH0w7qUqzZxy vGpULUXVnw8UUBRMSmf8hG+vLjPEm5guU22WI76AmkUcVunMX3UlCTMkNf8ydumv vMPf/ecCD4vh2EdqXAUfzPmc5MQGBnGi4F5UyBE/ioGU6dGwzFiXbfpE/eFHNE7G 2GnuVR5kxu7kYruQzeAaUp0V9wB7b6YdZNmqkj1TyvLcptiqD0HB5QqHW5jT14sO xskU90iRIsYrU37rH3IPpJ4L6eZbTEX6/KaeQVY+kkPJSDI+yWieglydyUVSpI9A hjvLcw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dnfus1dhk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Apr 2026 12:49:39 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50e576143baso3038921cf.2 for ; Mon, 20 Apr 2026 05:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776689378; x=1777294178; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sRtwY56nBQbf1x0k86FqJm1BNTc/81FVIoSrk2ABFhU=; b=H0T4ajrQcy9eXGC/KU3C2nMmqsFn2v6sIq4MTkyuZj6SpSNPYLLdOU+fd/+TVBpBh/ 381zcDtIF4hQD3/z30843HNN86NBSUNeLsUD8A5NQyoc92KgFvsD5VgSn8gUMp13JGfr paTVSc4LliPs3urSqAD/brDJl15Ukwm9FnTmgdZPA1o6wiRFcCCDaHIRiX5CDKS6tsVO VY0i4cVHYifaw2MwH0nKb5oxncGa5VV5uPIWFa+W3kiMZ6zmorRnb2zhdxM18dIgd8qM GCRL5fyVhbZzNyCVWX9h7JFtrvKQ/qbwlzIx4ZY1AOplwqx9qtEhw8oil5/+Qldzkwa5 JQOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776689378; x=1777294178; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sRtwY56nBQbf1x0k86FqJm1BNTc/81FVIoSrk2ABFhU=; b=SjEGzag0oq8pRCKif3re9pIjZOUO4OsrrVj16HoNebWGLt/C83bGCfLfB7Xff0uVK0 MDCK3dAKrMQMxoQbUfCHCcX89A9c1blh4BJ78t22BQFIQZ7Iz+2T/Tsz22Agf3nyxDGl Gnh9oiSIioOE0Dl/Ccjq4DN9XFi9mY077iJenEoAQcvGFtefQNC/tKhEm2w2rNKhvc3C E8Gu3OEac4mC393BxQhUb9JOJCYtXzL84+9HTJ2tdu0ycJNcO2UgzceY/XtaY/m3loKR +DZifM+rwxfWXznj65pEkBUclOKm7apJU36ShSAs8XCwzyc8WDvZTUgJWQs+qbP96Q7o WtYA== X-Forwarded-Encrypted: i=1; AFNElJ+SxMAX7VPBrD3m4l/yXD8+/K4CMvVgL+FG9pkKo8ZQdOANZDoV5+DOSIpcFYN5HJJEItBEgGoV18Yb7Ds=@vger.kernel.org X-Gm-Message-State: AOJu0YxTGTW2o1RMCiko4N20i9z4kuIJj8z/GHxUF+PAExQ2kBwCCxWl +9b2AP5taa8WqmPHjJH9CFhl9Q2dzI1EUnIzrXgb9zAViEROAum0xsienAL7sLQqE4GFbdBVD5P LZ8/1YsHTE6UrZe0WSKXAn7der60/sCNtf6WGOhILfro0RGJEAwpLoXw9UMQLWL5B9Ak= X-Gm-Gg: AeBDiesuANd4vaQPxElOPk9Xxz2WGRiF1xoHM9mDbh0lF23OfYO5w5SeERMARsB9Zgg ygf7uWzLEr7HEMFgPAtvCamHzqcHMI8JaLYx3bjBcLW0L7s7vHAdnR+6iM5wlinkBRcUdtWofxH dS211vC09fX6+VZoi17y4bIOKbTjSfkXwXEcO+O6QOgviQ9j+KZPALVnXSnhR0imXDOTWVY8yK6 G4EqdlilTkRyywteepiU4v2Ol7n0qVPDpDf+6uLfbO99bthD0aJZ8fom7CacrwImrr/jnxrQxpf QDK8F3uL1I3nsc1ZpgNEEdOiG8AMIf1NYawZ4lSSeN2Y01O/rY5r5iLmdeyDX1LVZeLLFIjxD4L X6TJbWzhJejmgB6CBDelgBdyYfdk3SnQXuNl8lK9bqgjcZnmpn775UAajAV/J4TaFSDbSCeBWl+ QPNF0t9FH/jmG4gg== X-Received: by 2002:a05:622a:4cce:b0:509:2b5a:808 with SMTP id d75a77b69052e-50e3683910cmr123783481cf.2.1776689378423; Mon, 20 Apr 2026 05:49:38 -0700 (PDT) X-Received: by 2002:a05:622a:4cce:b0:509:2b5a:808 with SMTP id d75a77b69052e-50e3683910cmr123783251cf.2.1776689377998; Mon, 20 Apr 2026 05:49:37 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba451210e1bsm350415966b.3.2026.04.20.05.49.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2026 05:49:37 -0700 (PDT) Message-ID: Date: Mon, 20 Apr 2026 14:49:35 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] phy: qcom: edp: Add eDP/DP mode switch support To: Yongxing Mou , Vinod Koul , Neil Armstrong , Stephen Boyd , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260302-edp_phy-v3-0-ca8888d793b0@oss.qualcomm.com> <20260302-edp_phy-v3-1-ca8888d793b0@oss.qualcomm.com> <245f4589-d7ca-4d6b-8162-a86972752bd8@oss.qualcomm.com> <12e8a8de-49b8-463a-8b88-2cbbf1ab901c@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <12e8a8de-49b8-463a-8b88-2cbbf1ab901c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIwMDEyNCBTYWx0ZWRfX+eU+2r6h40bu g0nB82q/CNS2w/CENUfBfBCWKXlt2H8PDwzkVZIRszsXZtmE/eXAIU7ydUPsU3/13nN9ZgmWwpj uZ/KPN2MEG2odv+1AaGqdLfT2Uz9/H9xVpXnQJbxdiirGjiUr1pBlrbcrpvTd+sFL3AL9xglwe6 5a6EpKkH58vPrN3pqirh3gkalIbSdAS8vlsjM1dDaaO+n/t+w93DIKzC/Hzeb0OWbsaZTEugFct i3TCZPmJcX535c8XKj96c41o5kl8wXfXp2oYDyW6mJhIj57nCptiMOqUFDwWGlkdQgQWw5SF7Ji Fr/DBwp6Sdr3PM5oKdPBO3MuaSWArdOwjIMGRcrvkyuPu4YDlcUlezSueCG5w8qYkpWW6kMAKBl ixk8B8k5IdxEV0TOFKcKm6NhNA52ySz9oc0hTSxxmWuipInGVOAU7oc1o1uuTKhHwZNt/ES9taS KYD4/zMf1jANzsadeIw== X-Proofpoint-GUID: bIbAHa5a40mE2S8XtoxmdXDoZr6b0RyO X-Authority-Analysis: v=2.4 cv=PMQ/P/qC c=1 sm=1 tr=0 ts=69e620e3 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ij7slcz6KMvQTOyTLR8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: bIbAHa5a40mE2S8XtoxmdXDoZr6b0RyO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-20_02,2026-04-17_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604200124 On 4/20/26 2:48 PM, Yongxing Mou wrote: > > > On 4/16/2026 5:34 PM, Konrad Dybcio wrote: >> On 3/2/26 9:28 AM, Yongxing Mou wrote: >>> The eDP PHY supports both eDP&DP modes, each requires a different table. >>> The current driver doesn't fully support every combo PHY mode and use >>> either the eDP or DP table when enable the platform. In addition, some >>> platforms mismatch between the mode and the table where DP mode uses >>> the eDP table or eDP mode use the DP table. >>> >>> Clean up and correct the tables for currently supported platforms based on >>> the HPG specification. >>> >>> Here lists the tables can be reused across current platforms. >>> DP mode： >>>     -sa8775p/sc7280/sc8280xp/x1e80100 >>>     -glymur >>> eDP mode(low vdiff): >>>     -glymur/sa8775p/sc8280xp/x1e80100 >>>     -sc7280 >>> >>> Cc: stable@vger.kernel.org >>> Fixes: f199223cb490 ("phy: qcom: Introduce new eDP PHY driver") >>> Signed-off-by: Yongxing Mou >>> --- >> >> I went through everything and all the sequences are OK. >> >> SC8180X will need changes, but it's already incorrect so this >> doesn't necessarily affect it >> >> Thanks! >> >> Reviewed-by: Konrad Dybcio >> >> Konrad > Thanks here.. I didn’t notice before that SC8180X is different from SC7280, and will correct it in the next version. Please make it another patch on top of these two, so that we don't have to re-validate the existing diff Konrad