From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB1DA406810 for ; Tue, 9 Jun 2026 12:03:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781006624; cv=none; b=t6epMK89PuFCW8OoVgoBMJSPq7ykh+i0N5SwRq8QkSf2s8pneEb8Syzec+MV4XO4LSwfPa9upMOBWWhfZcPk4H/u5GCiZedMoev6A6gVeilsGfC4bMp20T3AhlRuvwqMABkFFqEOzPciAs+1zX/UYPKcPI5fi3zRi1ga/lxcliM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781006624; c=relaxed/simple; bh=HfvR5gvfgsOcrHJ3L3OGl/zGy5KibbcsIuOZax3I7w4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S43YzvrX5VTNbdavPq4/9kc++vJH7DLzHg05szw0BHFVuAX7ciiKldiLww2wdS6mPP78L48dFJB0eS6ZRGeP2gHtSaJgjdIiZmJoTMxFgE04a8ekJLtQF378u0aG39xvv0G0KauFtTbGjbT7uu+WRkuOvhalz1RqjFOeW191uSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BxoC9Ezl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=g5t44r2Y; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BxoC9Ezl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g5t44r2Y" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 659BnJmF2566210 for ; Tue, 9 Jun 2026 12:03:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= t2yOM2NAjtAyFgfFhbJW5TqogRr+sQYkIoqann+cFi4=; b=BxoC9Ezl00y3ZCc9 V6RNTeDCYrLxnHn5u7ZXXjKT4JnD0EgVuhlR4G00zRngdGw33S2w9srfMOuBkcaG WRpFzJWsFNLyTNKiyxW0Dha0ail5foTmmkZ0CC8U6BiWF/nYWr2F0hIKANz8T7kM jJgtD+3gVE1y2W/4LEVIs188XujqZt+98a+NohmZMUfmBe33rJIOdv803v3qisB+ UaICFliMjPL/7Wo8iU9rf/jK4EynXDGN3mggxMvd3Yn3tDKMM76/wQ9ibsJRno7y TAmCiGjXOMho3NgIuuEcmCqNPu+UqYBWoVfsiVY+63RxMxRJF9yuPYgCglJ59+al vOs2QQ== Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epeeas3du-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 12:03:40 +0000 (GMT) Received: by mail-vk1-f198.google.com with SMTP id 71dfb90a1353d-59ebb69ecfbso347590e0c.1 for ; Tue, 09 Jun 2026 05:03:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781006620; x=1781611420; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=t2yOM2NAjtAyFgfFhbJW5TqogRr+sQYkIoqann+cFi4=; b=g5t44r2Yxp3ABwCqoK4hyF91HHK26M+5ziG9iRld25cqucLaEWOZlbRILWSqM9SBNC jCDBS55rgycn7ZzCUAcQ6MaT/inK9SefCkuVTleosEZe6bjxvOcjJBFiOiUgKsjhEruM z7AEoOn6oVOvE6+sxVJXazmGUrAR5PQk1CYF/h1s/NfvcjwK9sTZWs8VFP2PXBW6HyxO DyzJFBJkXphPGMxXQfu37lVA4xOWL8I/2xm0mwVd+Vw5zzMPq9pMBSYhHBCptvbcywCI NstuT282qr2zdxPdTOMFyzqDKLL9lfJ2WfieS5P2IL3iCiPMhr57Rd2u7Addm45ZdlVw 55+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781006620; x=1781611420; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t2yOM2NAjtAyFgfFhbJW5TqogRr+sQYkIoqann+cFi4=; b=kiGPNIOiU9VGlhBkR4mHhBjD3qGB9z++5GsI27kV4bnftpGDhQwxa/bKYpyDEDSijh r7O8v6MhT+gPwTzshYD7gy867cpal7uKSHIFlsHGVKMIo1Vrv4IaRkOhIMX8pufoaxQr 4P2dNuIx+xJ2EvkiuiFeLCYMj7RI/i1v4kfl92fQhHmDgmnBKDkvADDJ5HlPKiW1t89o n0WI4VxqdwhMbkCYpSlDh1DHLQLNObauPyeaEVttLWrIFiHXvFFRNu7IqKVO8lNpO8QC 6cA4O/7SvL931BoCJBaz5ugMlo5ED+/N00QaHujm391wwoM2KUyJllaNbJWMFr0xW6zG eFhA== X-Forwarded-Encrypted: i=1; AFNElJ/vBIu6VdW//lNffK/kNE46LZd6rWOOKctHPYkKJbWogDS40qMyX7l9KiUr5KJT0jgItn4oaSafQZavNEQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyIqXxe7c06A1OJ8bJArvd9dkDJnT2RNaaZ+Y3XsAQqMCbBbWjN oxWwCbDFVV6Nnl1HROjY053HGdLKSgreVdLVIxfz0TULyl86/hXUDRp9ex4SDem4MX6odkZGUwx mRjcl7ljzkZjVxPuAjdURrdyGNFBZg2U0wJLK5xoBAfPoF+EtTeMFhU4ClItDKtRkJp4= X-Gm-Gg: Acq92OE8oiRIl+UWRlwThs4v7ggsp8iH+CpT6Xj2x8gmyoXLi6sDFLUp7wjOKrSjctz NOUkyj4+aBfNKSvhnRR+CzYbpaNHv8cI7w9FJ0XYCjfX6NMj4v3rflNNUzL1M1xEJE+26sUS5vr uVY9HWzVQY1q5gWAFAHxdntgzG8EaXFRVIGCBakMX7vdxNA41l2qHNkf0ZoDStVKP8dKp3oQ6oe AGg3QrG/vgi0EKZR256tqjCg2uFUpvRhWnEDWfq8b+Ho+j98iJSpAClB6BQfE+u3AFDf+oavXUw CHWefXEwwYd21VCgWra4vtO1hOERmqPCr3cDA108lH1oS+8D7Gj9ffFrTHKaaPKkxXiuQX/QnIP sa+1Wca355vODnT7iW8q5HiyDqVgL7bV4wi1nnRLSC1ntJT7mbqNLZaGn X-Received: by 2002:a05:6102:5a92:b0:631:b312:a2a6 with SMTP id ada2fe7eead31-71913522647mr343119137.0.1781006619631; Tue, 09 Jun 2026 05:03:39 -0700 (PDT) X-Received: by 2002:a05:6102:5a92:b0:631:b312:a2a6 with SMTP id ada2fe7eead31-71913522647mr343091137.0.1781006619215; Tue, 09 Jun 2026 05:03:39 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e64e29c0esm8716512a12.7.2026.06.09.05.03.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 05:03:38 -0700 (PDT) Message-ID: Date: Tue, 9 Jun 2026 14:03:35 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/8] remoteproc: qcom: pas: register TMD thermal cooling devices To: Gaurav Kohli , Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Daniel Lezcano , Amit Kucheria , Manivannan Sadhasivam , Konrad Dybcio , Kees Cook , "Gustavo A. R. Silva" , cros-qcom-dts-watchers@chromium.org Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, Manaf Meethalavalappu Pallikunhi References: <20260609-qmi-tmd-v3-0-291a2ff4c634@oss.qualcomm.com> <20260609-qmi-tmd-v3-3-291a2ff4c634@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260609-qmi-tmd-v3-3-291a2ff4c634@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: HVdywmXFs_Xinq4T4_eK_7nQrGCxRbEL X-Authority-Analysis: v=2.4 cv=Iey3n2qa c=1 sm=1 tr=0 ts=6a28011c cx=c_pps a=1Os3MKEOqt8YzSjcPV0cFA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=x89XBY5VHgNHtdzuPNgA:9 a=QEXdDO2ut3YA:10 a=hhpmQAJR8DioWGSBphRh:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDExNCBTYWx0ZWRfX4z0b62cyHYS+ eKFRR5gKurzZOAtMZg0c2adknPyonfnGGF9zmhCgex7WAmabcmZZ+9N/0lhMGN1h7k3969YHHl7 vMu4BKlvNvF+6BmERtaGxjQMp/bhfw22cf5KXqUnP3OKRuIORk4mMuyyoteG4H51aGtpkKtpu7S AGU1dGMBfu24396EHG1iY3hEmYCQs3Nnl86LAQMhIUWJ/etTXYCxVaNws487ZHlhPuJ2D7cPCMw eAA/x/Kadh3vdkGO/XSZV50QaEbPICPRKYXOe0zSclMWLW2ik5GoCZUfwk+rZWl5czywsYbAQ13 yY0c/2yg3db69Vk0jmi4jxI82af1/Ur7BF7zXlgcEKyzN7hz9+5E9Pwoj+tpcRe21VbMHBEF15V ymEqqarn/SkiAeIDr85jVXIIuDTZmalxydEiVrAMe/1VTQVRKXOjMC5ljx4WaexclzQKufoHhH5 b8hIc8nn3bRCuP3QGxw== X-Proofpoint-GUID: HVdywmXFs_Xinq4T4_eK_7nQrGCxRbEL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_02,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 bulkscore=0 phishscore=0 clxscore=1015 priorityscore=1501 adultscore=0 suspectscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090114 On 6/9/26 12:22 PM, Gaurav Kohli wrote: > Add support for Thermal Mitigation Devices (TMDs) to enable > thermal throttling of remote processors through QMI. > > This enables the thermal framework to request mitigation when remote > subsystems (modem, CDSP) contribute to thermal issues. > > Signed-off-by: Gaurav Kohli > Signed-off-by: Daniel Lezcano There's no other signs of Daniel in this patch, please fix the tags chain [...] > +static int qcom_pas_setup_tmd(struct qcom_pas *pas) > +{ > + struct device *dev = pas->dev; > + struct device_node *np = dev->of_node; > + const char **tmd_names; > + int num_tmds, ret, i; > + > + if (!of_find_property(np, "tmd-names", NULL)) Let's use device_property_present() instead > + return 0; > + > + /* Get the TMD names array */ > + num_tmds = of_property_count_strings(np, "tmd-names"); Is this something we can stuff into platform_data for a given rproc on a given SoC (for which we already store *some* data in the PAS driver)? Konrad