From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Sidharth Seela <sidharthseela@gmail.com>
Cc: <ntfs3@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<syzbot+332bd4e9d148f11a87dc@syzkaller.appspotmail.com>
Subject: Re: [PATCH v1] ntfs3: Fix uninit buffer allocated by __getname()
Date: Thu, 20 Nov 2025 09:47:31 +0100 [thread overview]
Message-ID: <e957a100-9639-4b1e-9215-ce07ccd508c4@paragon-software.com> (raw)
In-Reply-To: <20250923064015.178554-2-sidharthseela@gmail.com>
On 9/23/25 08:40, Sidharth Seela wrote:
> Fix uninit errors caused after buffer allocation given to 'de'; by
> initializing the buffer with zeroes. The fix was found by using KMSAN.
>
> Reported-by: syzbot+332bd4e9d148f11a87dc@syzkaller.appspotmail.com
> Fixes: 78ab59fee07f2 ("fs/ntfs3: Rework file operations")
> Signed-off-by: Sidharth Seela <sidharthseela@gmail.com>
>
> --
>
> diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
> index 37cbbee7fa58..6b14c13bda68 100644
> --- a/fs/ntfs3/inode.c
> +++ b/fs/ntfs3/inode.c
> @@ -1716,6 +1716,7 @@ int ntfs_link_inode(struct inode *inode, struct dentry *dentry)
> de = __getname();
> if (!de)
> return -ENOMEM;
> + memset(de, 0, PATH_MAX);
>
> /* Mark rw ntfs as dirty. It will be cleared at umount. */
> ntfs_set_state(sbi, NTFS_DIRTY_DIRTY);
Patch looks good — applied. Thanks.
Regards,
Konstantin
prev parent reply other threads:[~2025-11-20 8:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-23 6:40 Sidharth Seela
2025-11-20 8:47 ` Konstantin Komarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e957a100-9639-4b1e-9215-ce07ccd508c4@paragon-software.com \
--to=almaz.alexandrovich@paragon-software.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=sidharthseela@gmail.com \
--cc=syzbot+332bd4e9d148f11a87dc@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®