From: Tejun Heo <tj@kernel.org>
To: Tao Yu <tao1.yu@intel.com>
Cc: hannes@cmpxchg.org, mkoutny@suse.com, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+bb2e19a1190a556c01b1@syzkaller.appspotmail.com
Subject: Re: [PATCH] cgroup: reject controller re-enable while css teardown is pending
Date: Wed, 02 Sep 2026 13:07:35 -1000 [thread overview]
Message-ID: <e959dbda2f689ed524e2a83d4affdfe0@kernel.org> (raw)
In-Reply-To: <20260901012342.855056-1-tao1.yu@intel.com>
Hello,
On Tue, Sep 01, 2026 at 09:23:42AM +0800, Tao Yu wrote:
> Stop draining offline csses from subtree_control and cgroup.type writes.
> Instead, reject the operation with -EBUSY if it would reuse a subsystem which
> still has dying csses in the target subtree.
Failing the re-enable isn't the right trade-off. "-cpu" followed by "+cpu"
has always succeeded eventually, and nr_dying_subsys stays non-zero until
the css is released, so it also counts removed cgroups and offlined but
still pinned csses. The -EBUSY would persist well past the actual conflict.
The writer shouldn't be sitting in D state waiting for exiting tasks in the
first place, so I posted a patchset which makes the drain interruptible
instead:
https://lore.kernel.org/all/20260902230313.530839-1-tj@kernel.org/
Thanks.
--
tejun
prev parent reply other threads:[~2026-09-02 23:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 1:23 Tao Yu
2026-09-02 23:07 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e959dbda2f689ed524e2a83d4affdfe0@kernel.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=syzbot+bb2e19a1190a556c01b1@syzkaller.appspotmail.com \
--cc=tao1.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®