From: Tejun Heo <tj@kernel.org>
To: Tao Cui <cui.tao@linux.dev>
Cc: tj@kernel.org, josef@toxicopanda.com, axboe@kernel.dk,
ameryhung@gmail.com, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org, andrii@kernel.org, eddyz87@gmail.com,
ast@kernel.org, daniel@iogearbox.net,
linux-kselftest@vger.kernel.org, Tao Cui <cuitao@kylinos.cn>
Subject: Re: [RFC PATCH v6 1/5] blk-iocost: add BPF struct_ops cost model support
Date: Mon, 21 Sep 2026 09:37:15 -1000 [thread overview]
Message-ID: <e95fad14874587df6ca17c5cf767d24e@kernel.org> (raw)
In-Reply-To: <20260918055001.1273840-2-cui.tao@linux.dev>
Hello, Tao.
On Fri, 18 Sep 2026 13:49:57 +0800, Tao Cui wrote:
> + mutex_lock(&iocost_bpf_reg_lock);
> + {
> + struct iocost_bpf_model *other;
> +
> + list_for_each_entry(other, &iocost_bpf_models, list) {
No need for a block to scope a variable. Declare it at the top of the
function, or in the body if it has to sit inside an #ifdef block. Same for
the other blocks in this patch and the cursor block in the 2x example
model.
Thanks.
--
tejun
next prev parent reply other threads:[~2026-09-21 19:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 5:49 [RFC PATCH v6 0/5] blk-iocost: BPF struct_ops cost model Tao Cui
2026-09-18 5:49 ` [RFC PATCH v6 1/5] blk-iocost: add BPF struct_ops cost model support Tao Cui
2026-09-21 19:37 ` Tejun Heo [this message]
2026-09-22 13:17 ` Tao Cui
2026-09-18 5:49 ` [RFC PATCH v6 2/5] selftests/bpf: add iocost cost model test Tao Cui
2026-09-18 5:49 ` [RFC PATCH v6 3/5] blk-iocost: add iocost_ioc_tick tracepoint for per-period device summary Tao Cui
2026-09-21 19:37 ` Tejun Heo
2026-09-22 13:18 ` Tao Cui
2026-09-18 5:50 ` [RFC PATCH v6 4/5] selftests/bpf: add multi-stream sequentiality example model Tao Cui
2026-09-18 5:50 ` [RFC PATCH v6 5/5] docs: cgroup-v2: document io.cost model=<name> binding Tao Cui
2026-09-21 19:37 ` [RFC PATCH v6 0/5] blk-iocost: BPF struct_ops cost model Tejun Heo
2026-09-22 13:11 ` Tao Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e95fad14874587df6ca17c5cf767d24e@kernel.org \
--to=tj@kernel.org \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=axboe@kernel.dk \
--cc=bpf@vger.kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=cui.tao@linux.dev \
--cc=cuitao@kylinos.cn \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=josef@toxicopanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®