mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Simon Horman <horms@kernel.org>, Allen <allen.lkml@gmail.com>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
	Allen Pais <apais@linux.microsoft.com>,
	netdev@vger.kernel.org, jes@trained-monkey.org,
	 davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	kda@linux-powerpc.org,  cai.huoqing@linux.dev,
	dougmill@linux.ibm.com, npiggin@gmail.com,
	 christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org,
	naveen.n.rao@linux.ibm.com,  nnac123@linux.ibm.com,
	tlfalcon@linux.ibm.com, cooldavid@cooldavid.org,
	 marcin.s.wojtas@gmail.com, mlindner@marvell.com,
	stephen@networkplumber.org,  nbd@nbd.name,
	sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com,
	lorenzo@kernel.org,  matthias.bgg@gmail.com,
	angelogioacchino.delregno@collabora.com,  borisp@nvidia.com,
	bryan.whitehead@microchip.com, UNGLinuxDriver@microchip.com,
	 louis.peens@corigine.com, richardcochran@gmail.com,
	linux-rdma@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-acenic@sunsite.dk,  linux-arm-kernel@lists.infradead.org,
	linuxppc-dev@lists.ozlabs.org,
	 linux-mediatek@lists.infradead.org, oss-drivers@corigine.com,
	 linux-net-drivers@amd.com
Subject: Re: [PATCH 1/1] [RFC] ethernet: Convert from tasklet to BH workqueue
Date: Thu, 09 May 2024 09:59:22 +0200	[thread overview]
Message-ID: <e9633d41d0d004db3ec6e2b6d9dcb95d029dbb94.camel@redhat.com> (raw)
In-Reply-To: <20240508201654.GA2248333@kernel.org>

On Wed, 2024-05-08 at 21:16 +0100, Simon Horman wrote:
> * As this patch seems to involve many non-trivial changes
>   it seems to me that it would be best to break it up somehow.
>   To allow proper review.

I would like to stress this latest point: it looks like the changes to
all the drivers are completely independent. If so, you have to break
the series on a per driver basis. Since the total number of patch will
be higher then 15 (maximum size allowed on netdev) you will have to
split this in several smaller series.

Beyond making the change reviewable, it will allow eventually reverting
the changes individually, should that cause any regressions.

Thanks,

Paolo


  reply	other threads:[~2024-05-09  7:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-07 19:01 [PATCH 0/1] Convert tasklets to BH workqueues in ethernet drivers Allen Pais
2024-05-07 19:01 ` [PATCH 1/1] [RFC] ethernet: Convert from tasklet to BH workqueue Allen Pais
2024-05-07 19:22   ` Russell King (Oracle)
2024-05-07 19:27     ` Allen
2024-05-08 20:16       ` Simon Horman
2024-05-09  7:59         ` Paolo Abeni [this message]
2024-05-09 21:38           ` Allen
2024-05-09 21:35         ` Allen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9633d41d0d004db3ec6e2b6d9dcb95d029dbb94.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=Mark-MC.Lee@mediatek.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=allen.lkml@gmail.com \
    --cc=aneesh.kumar@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=apais@linux.microsoft.com \
    --cc=borisp@nvidia.com \
    --cc=bryan.whitehead@microchip.com \
    --cc=cai.huoqing@linux.dev \
    --cc=christophe.leroy@csgroup.eu \
    --cc=cooldavid@cooldavid.org \
    --cc=davem@davemloft.net \
    --cc=dougmill@linux.ibm.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jes@trained-monkey.org \
    --cc=kda@linux-powerpc.org \
    --cc=kuba@kernel.org \
    --cc=linux-acenic@sunsite.dk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-net-drivers@amd.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lorenzo@kernel.org \
    --cc=louis.peens@corigine.com \
    --cc=marcin.s.wojtas@gmail.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mlindner@marvell.com \
    --cc=naveen.n.rao@linux.ibm.com \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=nnac123@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=oss-drivers@corigine.com \
    --cc=richardcochran@gmail.com \
    --cc=sean.wang@mediatek.com \
    --cc=stephen@networkplumber.org \
    --cc=tlfalcon@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®