mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	x86@kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
	it+linux-x86@molgen.mpg.de, Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: smpboot: CPU numbers printed as warning
Date: Mon, 15 Feb 2021 20:22:34 +0100	[thread overview]
Message-ID: <e964b2ae-7a15-a510-e76a-56d704949d62@molgen.mpg.de> (raw)

Dear Linux folks,


Using Linux 5.10.13 (and before), looking at the Linux kernel warnings, 
the CPU numbers show up. For example with 12 cpus/threads:

```
$ sudo dmesg --level=warn
[    0.216103]   #2
[    0.220105]   #3
[    0.224103]   #4
[    0.228104]   #5
[    0.232110]   #6
[    0.236101]   #7
[    0.240102]   #8
[    0.244102]   #9
[    0.248100]  #10
[    0.252098]  #11
```

If I am not mistaken, this is from `announce_cpu()` in 
`arch/x86/kernel/smpboot.c`, and the `pr_cont()` in their “forgets” the 
log level it belongs to, maybe because of SMP and other messages are 
printed in between.

```
         if (system_state < SYSTEM_RUNNING) {
                 if (node != current_node) {
                         if (current_node > (-1))
                                 pr_cont("\n");
                         current_node = node;

                         printk(KERN_INFO ".... node %*s#%d, CPUs:  ",
                                node_width - num_digits(node), " ", node);
                 }

                 /* Add padding for the BSP */
                 if (cpu == 1)
                         pr_cont("%*s", width + 1, " ");

                 pr_cont("%*s#%d", width - num_digits(cpu), " ", cpu);

         } else
                 pr_info("Booting Node %d Processor %d APIC 0x%x\n",
                         node, cpu, apicid);
```

Would using `pr_info()` instead be an acceptable fix?


Kind regards,

Paul

             reply	other threads:[~2021-02-15 19:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15 19:22 Paul Menzel [this message]
2021-02-16  9:49 ` Petr Mladek
2021-02-16 10:14   ` Borislav Petkov
2021-02-16 11:11     ` John Ogness
2021-02-16 11:39       ` Borislav Petkov
2021-02-16 11:58     ` Paul Menzel
2021-02-16 12:35       ` Peter Zijlstra
2021-02-16 10:38   ` Paul Menzel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e964b2ae-7a15-a510-e76a-56d704949d62@molgen.mpg.de \
    --to=pmenzel@molgen.mpg.de \
    --cc=bp@alien8.de \
    --cc=it+linux-x86@molgen.mpg.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pmladek@suse.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®