From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Ondrej Zary <linux@zary.sk>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Tim Waugh <tim@cyberelk.net>, <linux-block@vger.kernel.org>,
<linux-parport@lists.infradead.org>, <linux-ide@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/18] pata_parport: remove devtype from struct pi_adapter
Date: Sat, 18 Feb 2023 19:16:03 +0300 [thread overview]
Message-ID: <e965c234-517f-007d-6839-a6afa5f054ad@omp.ru> (raw)
In-Reply-To: <20230215194554.25632-7-linux@zary.sk>
On 2/15/23 10:45 PM, Ondrej Zary wrote:
> Only bpck driver uses devtype but it never gets set in pata_parport.
> Remove it.
> As most bpck devices are CD-ROMs, always run the code that depends
> on devtype == PI_PCD.
>
> Signed-off-by: Ondrej Zary <linux@zary.sk>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
> diff --git a/drivers/ata/pata_parport/bpck.c b/drivers/ata/pata_parport/bpck.c
> index b9174cf8863c..96386a10c22f 100644
> --- a/drivers/ata/pata_parport/bpck.c
> +++ b/drivers/ata/pata_parport/bpck.c
> @@ -241,14 +241,14 @@ static void bpck_connect ( PIA *pi )
>
> WR(5,8);
>
> - if (pi->devtype == PI_PCD) {
> +/* if (pi->devtype == PI_PCD) { possibly wrong, purpose unknown */
> WR(0x46,0x10); /* fiddle with ESS logic ??? */
> WR(0x4c,0x38);
> WR(0x4d,0x88);
> WR(0x46,0xa0);
> WR(0x41,0);
> WR(0x4e,8);
> - }
> +/* }*/
You could have used // here, scripts/checkpatch.pl has nothing against it now...
[...]
MBR, Sergey
next prev parent reply other threads:[~2023-02-18 16:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 19:45 [PATCH v3 0/18] pata_parport: protocol drivers fixes and cleanups Ondrej Zary
2023-02-15 19:45 ` [PATCH 01/18] pata_parport: fix EPAT C7/C8 Kconfig Ondrej Zary
2023-02-15 19:45 ` [PATCH 02/18] pata_parport: probe all units automatically Ondrej Zary
2023-02-18 15:55 ` Sergey Shtylyov
2023-02-15 19:45 ` [PATCH 03/18] pata_parport: Remove pi_swab16 and pi_swab32 Ondrej Zary
2023-02-15 19:45 ` [PATCH 04/18] pata_parport: remove useless printks at module_init of bpck6 Ondrej Zary
2023-02-18 15:47 ` Sergey Shtylyov
2023-02-15 19:45 ` [PATCH 05/18] pata_parport: Introduce module_pata_parport_driver macro Ondrej Zary
2023-02-18 16:07 ` Sergey Shtylyov
2023-02-18 16:07 ` Sergey Shtylyov
2023-02-15 19:45 ` [PATCH 06/18] pata_parport: remove devtype from struct pi_adapter Ondrej Zary
2023-02-18 16:16 ` Sergey Shtylyov [this message]
2023-02-15 19:45 ` [PATCH 07/18] pata_parport: remove device " Ondrej Zary
2023-02-15 19:45 ` [PATCH 08/18] pata_parport: remove typedef struct PIA Ondrej Zary
2023-02-15 19:45 ` [PATCH 09/18] pata_parport: remove verbose parameter from log_adapter() Ondrej Zary
2023-02-15 19:45 ` [PATCH 10/18] pata_parport: remove scratch " Ondrej Zary
2023-02-15 19:45 ` [PATCH 11/18] pata_parport: use dev_* instead of printk Ondrej Zary
2023-02-18 16:51 ` Sergey Shtylyov
2023-02-15 19:45 ` [PATCH 12/18] pata_parport: use print_hex_* Ondrej Zary
2023-02-18 17:04 ` Sergey Shtylyov
2023-02-15 19:45 ` [PATCH 13/18] pata_parport: simplify log_adapter prints, remove VERSION defines Ondrej Zary
2023-02-18 17:28 ` Sergey Shtylyov
2023-02-15 19:45 ` [PATCH 14/18] pata_parport: remove bpck6 verbose parameter Ondrej Zary
2023-02-18 17:38 ` Sergey Shtylyov
2023-02-15 19:45 ` [PATCH 15/18] pata_parport: remove verbose parameter from test_proto() Ondrej Zary
2023-02-18 17:40 ` Sergey Shtylyov
2023-02-15 19:45 ` [PATCH 16/18] pata_parport: remove scratch " Ondrej Zary
2023-02-15 19:45 ` [PATCH 17/18] pata_parport: remove obsolete changelogs Ondrej Zary
2023-02-15 19:45 ` [PATCH 18/18] pata_parport: move pata_parport.h to drivers/ata/pata_parport Ondrej Zary
-- strict thread matches above, loose matches on Subject: below --
2023-03-06 17:27 [PATCH RESEND v4 0/18] pata_parport: protocol drivers fixes and cleanups Ondrej Zary
2023-03-06 17:27 ` [PATCH 06/18] pata_parport: remove devtype from struct pi_adapter Ondrej Zary
2023-02-18 22:01 [PATCH v4 0/18] pata_parport: protocol drivers fixes and cleanups Ondrej Zary
2023-02-18 22:01 ` [PATCH 06/18] pata_parport: remove devtype from struct pi_adapter Ondrej Zary
2023-02-14 22:59 [PATCH v2 0/18] pata_parport: protocol drivers fixes and cleanups Ondrej Zary
2023-02-14 22:59 ` [PATCH 06/18] pata_parport: remove devtype from struct pi_adapter Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e965c234-517f-007d-6839-a6afa5f054ad@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parport@lists.infradead.org \
--cc=linux@zary.sk \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®