mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>,
	Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
	Hans Verkuil <hverkuil@xs4all.nl>
Subject: [PATCH v4 01/11] drm/sun4i: tcon: Add channel debug
Date: Sat, 27 May 2017 18:09:26 +0200	[thread overview]
Message-ID: <e96b4bf8f28ae808bb431f099d1e9b60a9e7933c.1495900658.git-series.maxime.ripard@free-electrons.com> (raw)
In-Reply-To: <cover.c61cbe60123a4aeb24f255bca7927218dda6283e.1495900658.git-series.maxime.ripard@free-electrons.com>
In-Reply-To: <cover.c61cbe60123a4aeb24f255bca7927218dda6283e.1495900658.git-series.maxime.ripard@free-electrons.com>

While all functions have debug logs, the channel enable and disable are not
logged. Make sure this is the case.

Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
---
 drivers/gpu/drm/sun4i/sun4i_tcon.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
index f44a37a5993d..b79d3a277fbf 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
@@ -55,6 +55,8 @@ EXPORT_SYMBOL(sun4i_tcon_enable);
 
 void sun4i_tcon_channel_disable(struct sun4i_tcon *tcon, int channel)
 {
+	DRM_DEBUG_DRIVER("Disabling TCON channel %d\n", channel);
+
 	/* Disable the TCON's channel */
 	if (channel == 0) {
 		regmap_update_bits(tcon->regs, SUN4I_TCON0_CTL_REG,
@@ -72,6 +74,8 @@ EXPORT_SYMBOL(sun4i_tcon_channel_disable);
 
 void sun4i_tcon_channel_enable(struct sun4i_tcon *tcon, int channel)
 {
+	DRM_DEBUG_DRIVER("Enabling TCON channel %d\n", channel);
+
 	/* Enable the TCON's channel */
 	if (channel == 0) {
 		regmap_update_bits(tcon->regs, SUN4I_TCON0_CTL_REG,
-- 
git-series 0.9.1

  reply	other threads:[~2017-05-27 16:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-27 16:09 [PATCH v4 00/11] drm: sun4i: Add support for the HDMI controller Maxime Ripard
2017-05-27 16:09 ` Maxime Ripard [this message]
2017-05-27 16:09 ` [PATCH v4 02/11] drm/sun4i: tcon: Move the muxing out of the mode set function Maxime Ripard
2017-05-27 16:09 ` [PATCH v4 03/11] drm/sun4i: tcon: Switch mux on only for composite Maxime Ripard
2017-05-27 16:09 ` [PATCH v4 04/11] drm/sun4i: tcon: Fix tcon channel 1 backporch calculation Maxime Ripard
2017-05-27 16:09 ` [PATCH v4 05/11] drm/sun4i: tcon: Change vertical total size computation inconsistency Maxime Ripard
2017-05-27 16:09 ` [PATCH v4 06/11] drm/sun4i: tcon: multiply the vtotal when not in interlace Maxime Ripard
2017-05-28 14:55   ` Chen-Yu Tsai
2017-05-27 16:09 ` [PATCH v4 07/11] drm/sun4i: Ignore the generic connectors for components Maxime Ripard
2017-05-27 16:09 ` [PATCH v4 08/11] dt-bindings: display: sun4i: Add HDMI display bindings Maxime Ripard
2017-05-27 16:09 ` [PATCH v4 09/11] dt-bindings: display: sun4i: Add allwinner,tcon-channel property Maxime Ripard
2017-05-27 16:09 ` [PATCH v4 10/11] drm/sun4i: Add HDMI support Maxime Ripard
2017-05-27 16:09 ` [PATCH v4 11/11] drm/sun4i: Add compatible for the A10s pipeline Maxime Ripard
2017-05-29  9:16 ` [PATCH v4 00/11] drm: sun4i: Add support for the HDMI controller Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e96b4bf8f28ae808bb431f099d1e9b60a9e7933c.1495900658.git-series.maxime.ripard@free-electrons.com \
    --to=maxime.ripard@free-electrons.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®