mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Takashi Iwai <tiwai@suse.de>, Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of Linus' tree
Date: Mon, 29 Jul 2019 09:03:14 +0200	[thread overview]
Message-ID: <e96cf8a57c4633e807cfe82762397ad15ba19ed8.camel@sipsolutions.net> (raw)
In-Reply-To: <s5h8sshpbt3.wl-tiwai@suse.de>

On Mon, 2019-07-29 at 08:58 +0200, Takashi Iwai wrote:
> On Mon, 29 Jul 2019 06:04:04 +0200,
> Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the origin tree, today's linux-next build (powerpc
> > allyesconfig) produced this warning:
> > 
> > sound/aoa/codecs/onyx.c: In function 'onyx_snd_single_bit_get':
> > sound/aoa/codecs/onyx.c:377:37: warning: 'c' may be used uninitialized in this function [-Wmaybe-uninitialized]
> >   ucontrol->value.integer.value[0] = !!(c & mask) ^ polarity;
> >                                      ^~~~~~~~~~~~
> > 
> > Introduced by commit
> > 
> >   f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa")
> > 
> > This warning has been around for a long time.  It could possibly be
> > suppressed by checking for errors returned by onyx_read_register().
> 
> Yes, or simply zero-ing the variable in onyx_read_register().  The
> current code ignores the read error and it's been OK over a decade :)

Yeah, it's pretty weird that it never showed up before. I was wondering
for a minute why I was CC'ed on a sound merge issue :-)

Do you want me to send a patch or just commit something to suppress
this?

johannes


  reply	other threads:[~2019-07-29  7:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-29  4:04 Stephen Rothwell
2019-07-29  6:58 ` Takashi Iwai
2019-07-29  7:03   ` Johannes Berg [this message]
2019-07-29  7:07     ` Takashi Iwai
2019-07-29  8:20       ` Stephen Rothwell
2021-10-01  7:18 Stephen Rothwell
2021-10-01 16:33 ` Eric Dumazet
2021-10-05  9:18 Stephen Rothwell
2021-10-05 10:10 ` Jeff Layton
2021-11-23  5:29 Stephen Rothwell
2022-01-20  3:27 ` Stephen Rothwell
2023-05-08  4:44 Stephen Rothwell
2023-05-08  6:28 ` Sakari Ailus
2024-03-13  4:04 Stephen Rothwell
2024-10-01  3:47 Stephen Rothwell
2024-10-01 15:02 ` Christian Brauner
2025-03-05  9:46 Stephen Rothwell
2025-04-22 10:47 Stephen Rothwell
2025-04-22 15:59 ` Linus Torvalds
2025-04-22 17:50   ` Thomas Weißschuh
2025-04-22 18:20     ` Linus Torvalds
2025-04-22 20:48       ` Nathan Chancellor
2025-04-22 20:49       ` Linus Torvalds
2025-04-27 11:42       ` David Laight
2025-04-22 23:55   ` Stephen Rothwell
2025-11-27  2:10 Stephen Rothwell
2025-12-16  1:08 ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e96cf8a57c4633e807cfe82762397ad15ba19ed8.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®