mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bean Huo <huobean@gmail.com>
To: Alexey Charkov <alchark@flipper.net>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	 Avri Altman <avri.altman@wdc.com>,
	Bart Van Assche <bvanassche@acm.org>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Bean Huo <beanhuo@micron.com>, Can Guo <can.guo@oss.qualcomm.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	 stable@vger.kernel.org
Subject: Re: [PATCH v2] scsi: ufs: core: Fix RPMB region size detection for UFS 2.2
Date: Mon, 09 Feb 2026 15:51:50 +0100	[thread overview]
Message-ID: <e96f69b108eb13a87838581aef9325dd74c556d0.camel@gmail.com> (raw)
In-Reply-To: <20260205-ufs-rpmb-v2-1-5e1572ee52bf@flipper.net>

On Thu, 2026-02-05 at 12:30 +0400, Alexey Charkov wrote:
> Older UFS spec devices (2.2 and earlier) do not expose per-region RPMB
> sizes, as only one RPMB region is supported. In such cases, the size of
> the single RPMB region can be deduced from the Logical Block Count and
> Logical Block Size fields in the RPMB Unit Descriptor.
> 
> Add a fallback mechanism to calculate the RPMB region size from these
> fields if the device implements an older spec, so that the RPMB driver
> can work with such devices - otherwise it silently skips the whole RPMB.
> 
>         Section 14.1.4.6 (RPMB Unit Descriptor)
> 
> Link: https://www.jedec.org/system/files/docs/JESD220C-2_2.pdf
> Cc: stable@vger.kernel.org
> Fixes: b06b8c421485 ("scsi: ufs: core: Add OP-TEE based RPMB driver for UFS
> devices")
> Signed-off-by: Alexey Charkov <alchark@flipper.net>

Hi Alexey,

please address Bart's suggestion in the next version, and add my reviewed tag.

Reviewed-by: Bean Huo <beanhuo@micron.com>


Kind regards,
Bean

  parent reply	other threads:[~2026-02-09 14:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-05  8:30 Alexey Charkov
2026-02-05 16:08 ` Bart Van Assche
2026-02-06  6:49   ` Alexey Charkov
2026-02-09 14:51 ` Bean Huo [this message]
2026-02-09 15:18   ` Alexey Charkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e96f69b108eb13a87838581aef9325dd74c556d0.camel@gmail.com \
    --to=huobean@gmail.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alchark@flipper.net \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=can.guo@oss.qualcomm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®