From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 770DEC32793 for ; Wed, 18 Jan 2023 13:08:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231358AbjARNIY (ORCPT ); Wed, 18 Jan 2023 08:08:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231304AbjARNHb (ORCPT ); Wed, 18 Jan 2023 08:07:31 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBE115257 for ; Wed, 18 Jan 2023 04:29:56 -0800 (PST) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id AD6956602DFF; Wed, 18 Jan 2023 12:29:54 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1674044995; bh=pum+JmCfAkepIxkkNByMAkyC1GI2OMonhqfRFmshYoE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nZhfNYhIleSeEWuzQ9i+JdDvgI+2h6Zj9MBAIESDo8pycH1bhSQDar1C4xs+KYnnY S/ASTqTVVz4PvrmUaMJc0mm+AmsFRPtoNZwEBBmYP9K7im093NiUtTPAOQRn/2B9kz V94PHbnh6/z2WwxDP95syv+Kei/05ONru95kr79WbSXC+tTgZUg/vCrMzTeJ16m4Ll 62SpPbAkfiAwnpz9A1Sy/Z+N/hG5ryUiEfZHN0giXLlhF0tDJwp7SX9oBB/zHXdyTS axHPdeVmOqsbZXWr+WWgjx74lEbyaFjcQKwvMQSBsXRNiudUbCAIe6MXC9oIT/05vK Ue1u7eSer/i8Q== Message-ID: Date: Wed, 18 Jan 2023 13:29:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v7 1/3] phy: mediatek: remove temporary variable @mask_ Content-Language: en-US To: Chunfeng Yun , Vinod Koul Cc: Kishon Vijay Abraham I , Matthias Brugger , Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Eddie Hung , kernel test robot References: <20230118084343.26913-1-chunfeng.yun@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230118084343.26913-1-chunfeng.yun@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 18/01/23 09:43, Chunfeng Yun ha scritto: > Remove the temporary @mask_, this may cause build warning when use clang > compiler for powerpc, but can't reproduce it when compile for arm64. > the build warning is caused by: > > "warning: result of comparison of constant 18446744073709551615 with > expression of type (aka 'unsigned long') is always false > [-Wtautological-constant-out-of-range-compare]" > > More information provided in below lore link. > > After removing @mask_, there is a "CHECK:MACRO_ARG_REUSE" when run > checkpatch.pl, but due to @mask is constant, no reuse problem will happen. > > Link: https://lore.kernel.org/lkml/202212160357.jJuesD8n-lkp@intel.com/t/ > Fixes: 84513eccd678 ("phy: mediatek: fix build warning of FIELD_PREP()") > Reported-by: kernel test robot > Signed-off-by: Chunfeng Yun Reviewed-by: AngeloGioacchino Del Regno