From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD039C4707A for ; Fri, 21 May 2021 18:08:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4B3E613CB for ; Fri, 21 May 2021 18:08:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238627AbhEUSJ7 (ORCPT ); Fri, 21 May 2021 14:09:59 -0400 Received: from 13.mo3.mail-out.ovh.net ([188.165.33.202]:46518 "EHLO 13.mo3.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238624AbhEUSJ5 (ORCPT ); Fri, 21 May 2021 14:09:57 -0400 X-Greylist: delayed 917 seconds by postgrey-1.27 at vger.kernel.org; Fri, 21 May 2021 14:09:57 EDT Received: from player726.ha.ovh.net (unknown [10.108.4.183]) by mo3.mail-out.ovh.net (Postfix) with ESMTP id 4F05728B54E for ; Fri, 21 May 2021 19:53:16 +0200 (CEST) Received: from milecki.pl (apn-37-248-218-55.dynamic.gprs.plus.pl [37.248.218.55]) (Authenticated sender: rafal@milecki.pl) by player726.ha.ovh.net (Postfix) with ESMTPSA id CB0301E50B410; Fri, 21 May 2021 17:53:05 +0000 (UTC) Authentication-Results: garm.ovh; auth=pass (GARM-98R002b7378bfe-4074-4308-8238-a0549ece8f55, 4CBC7BFF0D712EF435A3407F9D93963C24D256AC) smtp.auth=rafal@milecki.pl X-OVh-ClientIp: 37.248.218.55 Subject: Re: [PATCH net] net: dsa: bcm_sf2: Fix bcm_sf2_reg_rgmii_cntrl() call for non-RGMII port To: Florian Fainelli , netdev@vger.kernel.org Cc: zajec5@gmail.com, Andrew Lunn , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , open list References: <20210521174614.2535824-1-f.fainelli@gmail.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Message-ID: Date: Fri, 21 May 2021 19:53:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210521174614.2535824-1-f.fainelli@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 17549401848744807959 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduledrvdejfedguddukecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefuvfhfhffkffgfgggjtgfgsehtkeertddtfeejnecuhfhrohhmpeftrghfrghlucfoihhlvggtkhhiuceorhgrfhgrlhesmhhilhgvtghkihdrphhlqeenucggtffrrghtthgvrhhnpeekudehjeehffdufefhgffhgeejjeelteekveeuleevgeekhffhffeiheellefgveenucfkpheptddrtddrtddrtddpfeejrddvgeekrddvudekrdehheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrhejvdeirdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheprhgrfhgrlhesmhhilhgvtghkihdrphhlpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhg Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.05.2021 19:46, Florian Fainelli wrote: > We cannot call bcm_sf2_reg_rgmii_cntrl() for a port that is not RGMII, > yet we do that in bcm_sf2_sw_mac_link_up() irrespective of the port's > interface. Move that read until we have properly qualified the PHY > interface mode. This avoids triggering a warning on 7278 platforms that > have GMII ports. > > Fixes: 55cfeb396965 ("net: dsa: bcm_sf2: add function finding RGMII register") > Signed-off-by: Florian Fainelli Acked-by: Rafał Miłecki