From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E17F347FFE for ; Mon, 13 Jul 2026 08:30:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783931459; cv=none; b=LR3as1YeuWmxVQMd9KMIfTE/iPJGK19MWuA7mkrVzzYOkwZpf2yYbOxWoHHspZiQc3wu3ehqe4rIocS64exnV8yRKKtsj7CaCkAhlThtUOEvsbbWudfGTgYbagXHSRzFZgME5xAgcJ4ppfW4WOsNEI6FKA0buqpdjfMVf9Em7/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783931459; c=relaxed/simple; bh=ox6Z94BZRgLqASrZyKkY5G6KpcMeLAUyU7fdgaJxuKo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KgHkja+aSjJDtW2H+xUYLZvcCSu12OtDG9zjI9m9fXehXnASddyww7axVZs3CkYzRayi/6PMEOm3u4iMpieUBvLkzhsWc53GivAIMAUAi7LRGrleqbFqkT3MV91H42wuOewrVKCfC1H1VD6fZ42J8Pz/tbZWJo0pgRk/+pCYQL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WNzN2v5b; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GGjcnfc4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WNzN2v5b"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GGjcnfc4" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66D6NhMj648372 for ; Mon, 13 Jul 2026 08:30:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +dtBJLacOGGttlAIKQe354mVWyqsRLsF0Nl3YOfEBx8=; b=WNzN2v5bhN69YL/9 ky/gO34vBXIlAV1Evbp5dsfLonGY36gh7xKfxuh242cO7i2mnZgVUju6/7SZI5Wu Yk9yBX3JqntlgGXaDnL61gjL65X0z0mHQ2kGZSFWPuMdtL0b6iDDimPXA4+vQrpo u0WS48z2BqpeK2xlSo6uHsQlOoWiGKc5KSWxoeaD/XkBxsxSCdCnatSnXs6fxeDG y+kC8EdVN+BCqShzei3lSFbZdqZMOeL4+AMrXL6HCqH3D03CROPoxrlSyAk+cYnD Hy4vGVlIz+XafPI0tnFz+9s6DChwn6i40E4Mfs/nLJSK8W7q/poMZ5gh5bmBxglC gcDTZw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fbebr53a3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Jul 2026 08:30:56 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51c083f1818so40011251cf.0 for ; Mon, 13 Jul 2026 01:30:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783931455; x=1784536255; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+dtBJLacOGGttlAIKQe354mVWyqsRLsF0Nl3YOfEBx8=; b=GGjcnfc4lsCsdpAm4F4tsI8XCUeW+cpUYSclBbOdCVl+8YmpfA8j0lrtZXGlFcm/eT fVCDMjLoDXfC7YOHr9jn6bPRZ57BBQc82P//VvskkwaSBihD6jDvBiHYMJvbgcuRG+Ck gY16kqzQrA/XjxR7yZo5/B7Lzxb6/NLbaO7rbkBCT3oY13P1B9vGKSXGUxnIQGrUgVCo w85jaFQPnnxhdCwA5vcNdCluOrP0tq5Jnwjkac3tuPfZztQ55czoybzPKtprHHc5GGf8 GzWXv9u+hFUj7J8Yh2YntxIZHuyOkO1d+/REZ72gu+SzyJjeeZZS5eWe/PzRpIk9Z18p caDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783931455; x=1784536255; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+dtBJLacOGGttlAIKQe354mVWyqsRLsF0Nl3YOfEBx8=; b=XGX6V8LxD7F5Lz0ucgJ7Y48zzPyQx2npx9IuN0Bl5OcneRmrhF49r5DP88iigHyQi0 GOlZjfvkd14JiGz8gs3JnTNe6udHkuK/N/qKchVOq6LrEPtKF5mTQoBYyGSHYxtFi/ye hoqI4FTD6XcezGbPMRVv84v785TCFYO0lWXMYl6kQVv/vhPe4CjuTuljmE8NhDKQqsBs cA6J/TkiOKc0JCpARI3bp+5QUBYwWMUk6j2JAd4yL7ojdZLhDgrp2UMATQXrQTBrVPQO I4vgO8wPf2nnqA3+JSAYM+fYJup3RLlb3ULeEgZHPsl3ejE9H/9ehe9zJg7iA5FDGGv9 0iow== X-Forwarded-Encrypted: i=1; AHgh+RpeLm+jsuSrsASGiBDJzPUMpH0/5Bbg7E7jTgLz2w/Z8Mo9zmqaWi/h0GuJqzocxxoZzF9MwyyHrGl+Dro=@vger.kernel.org X-Gm-Message-State: AOJu0YwvIJ6tfkw4BAB90QLcsCSOWrRY+tEJ7IGFNCDzFVEnEiQ8WDj6 AtZpC8RlFsUTk3hyU6+gt7/5ciQCM3REI7fCfVPhdNEHhxb1DwSmue7eUeQiOm9OuhmYqNnVj4P 70aIthI0aO42mVO/uGYV8dQ1A89Ozjn1pBosYhyLuyGnVYfyrFfUrfuHLFtVAG7iE1jw= X-Gm-Gg: AfdE7clFZoXvzqFoQROPIyyfK9iIbHWubYKTWCmIXMBZaOY2nN31EuP3+By/i4KKy+K aRd/QZuC1br1brUrOobZ9+bqO4Ch0r1innDvqm4K0HwUKGY8Ab916WIwxG5L1Ix5YrvRdHT1skk QydIB6seMwmpPTXSbmpgbLZStpboBhWuZC1lRqepWFavRZlju2DfaJ1eOPqm0CSNH9Z+e3bYKPc TFPdYG6ZTuBcgeW07XkfdGNDyTB3wKyYBDzVqzHuaf1O6ygiQQES2QCNNGGV5KshnEUM2OMAta7 3xiMVE9ANASsXFhl9YCmnZqq7jIK9qRccu+Nva4AkYHZKFHBYuooZlSFj2yoNrrSwPMhL7NH8tT ixv3CNw/0PEiCU914mJhmJY39RnV/NRngpWatj1T5ktY= X-Received: by 2002:a05:622a:5c0b:b0:51c:7d0:7ed7 with SMTP id d75a77b69052e-51cbf24a901mr81763801cf.39.1783931453367; Mon, 13 Jul 2026 01:30:53 -0700 (PDT) X-Received: by 2002:a05:622a:5c0b:b0:51c:7d0:7ed7 with SMTP id d75a77b69052e-51cbf24a901mr81763651cf.39.1783931452962; Mon, 13 Jul 2026 01:30:52 -0700 (PDT) Received: from [192.168.1.73] ([92.247.57.178]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15eb1dbdc9sm569475766b.10.2026.07.13.01.30.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2026 01:30:52 -0700 (PDT) Message-ID: Date: Mon, 13 Jul 2026 11:30:50 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/5] media: qcom: jpeg: Add Qualcomm JPEG V4L2 encoder To: Krzysztof Kozlowski , linux-media@vger.kernel.org Cc: bryan.odonoghue@linaro.org, vladimir.zapolskiy@linaro.org, loic.poulain@oss.qualcomm.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260706071113.383215-1-atanas.filipov@oss.qualcomm.com> <20260706071113.383215-6-atanas.filipov@oss.qualcomm.com> <06834dd6-1221-463f-9543-600814c8fc83@kernel.org> Content-Language: en-US From: Atanas Filipov In-Reply-To: <06834dd6-1221-463f-9543-600814c8fc83@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEzMDA4NyBTYWx0ZWRfX7ftqVBNgi93u 8efa33ctOI45EyNdUIuDKx+C2RJAVzTP6ZI4YxFh4yIWQRo+lSI00TUv5lTjtFgGuqSsHvnvHbr GNz/JjOthTf6w4oyVKf8Xw5Gx6zKMK8= X-Authority-Analysis: v=2.4 cv=OK8XGyaB c=1 sm=1 tr=0 ts=6a54a240 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=ybD9qRDIDfZaXNPQ7Ca20A==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=TB4z-ivqILPobOqkYRMA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: XNdJ9KyBl_aDovD6nxYu2Z9byK7zMZMu X-Proofpoint-ORIG-GUID: XNdJ9KyBl_aDovD6nxYu2Z9byK7zMZMu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEzMDA4NyBTYWx0ZWRfXyslhCbmZgg6V Ml0RYfOs1eprQ/E26L9cFobmu+qZuIQzn/1EaLoWBm36TRMvWTKxjAbTbD3AfANzPfZVReG5XCB 6GeETIvql0icsyPlYYrb2O/WGuPioyjE/Hv2M36eviJoWmP3Udch/+V7m+X1SVK6VDNBZmiMQSC Dt/x9Trie+ltVQ4U1pj7Y3q/pqshjlmWVor2SWPEdhsz+J3UOZRwufYuedWiP8g9P07PZSFLZCZ 3mzYooX43wEKJef+fwwUwPekfJCc721t9PoUNn0RpaJFwXFBbUUEAcpqIhxppRBuikOtJZz7FAw 9TXbcldNTSnWvDmhxGWIzh9dLLHOO4QXwrsbErSR6/7mBzkaKvi5n7rK77v37gDovTV+PfOB56i 8FEnTKWkcvdJNnrL/+FXHF683/HpoT6BcWUxIiJxjV8307H5VtzLFcebfQ293Psli/fZXeWLzhK /AnkI2dzfYFxG0oX7Cw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-13_02,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 phishscore=0 spamscore=0 adultscore=0 clxscore=1015 impostorscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607130087 On 7/6/2026 3:19 PM, Krzysztof Kozlowski wrote: > On 06/07/2026 09:11, Atanas Filipov wrote: >> Add a Qualcomm JPEG encoder driver implemented on top of the >> V4L2 mem2mem framework. >> >> The driver wires vb2 queue handling, format negotiation, JPEG header >> handling, interrupt-driven job completion, and runtime PM/clock/ICC >> integration for the standalone JPEG encode hardware block. >> >> This series targets SM8250 (Kona) platforms. >> >> The jpeg-encoder node is described as a child node of the CAMSS block >> and is probed automatically via of_platform_populate() in camss_probe(). >> >> Usage examples: >> >> - Check of related video node: v4l2-ctl --list-devices >> The expected result: >> qcom-jpeg-enc (platform:qcom-jpeg-enc): >> /dev/videoX >> >> V4L2 Examples: >> >> v4l2-ctl -d /dev/video14 \ >> --set-fmt-video-out=width=1920,height=1080,pixelformat=NM12 \ >> --stream-mmap --stream-out-mmap >> >> v4l2-ctl -d /dev/video14 \ >> -c compression_quality=100 \ >> --set-fmt-video-out=width=1920,height=1080,pixelformat=NM12 \ >> --stream-mmap --stream-out-mmap \ >> --stream-count=100 >> >> v4l2-ctl -d /dev/video14 \ >> --set-fmt-video-out=width=1920,height=1080,pixelformat=NM12 \ >> --stream-mmap --stream-out-mmap \ >> --set-ctrl=perf_level_auto=1 \ >> --set-ctrl=fps_target=30 \ >> --stream-count=100 >> >> v4l2-ctl -d /dev/video14 \ >> --set-fmt-video-out=width=8192,height=8192,pixelformat=NM12 \ >> --stream-mmap --stream-out-mmap \ >> --stream-count=1 \ >> --stream-to=8192x8192_NM12.jpg >> >> v4l2-ctl -d /dev/video14 \ >> --set-fmt-video-out=width=8192,height=8192,pixelformat=GREY \ >> --stream-mmap --stream-out-mmap \ >> --stream-count=1 \ >> --stream-to=OUT_8192x8192.jpg >> >> v4l2-ctl -d /dev/video14 \ >> -c compression_quality=100 \ >> --set-fmt-video-out=width=1920,height=1088,pixelformat=NM12 \ >> --stream-mmap=4 --stream-out-mmap=4 \ >> --stream-count=100 \ >> --stream-out-pattern=21 \ >> --stream-to=OUT_1920x1088_100F.mjpg >> >> GStreamer examples: >> >> gst-launch-1.0 videotestsrc \ >> is-live=false pattern=ball num-buffers=50 ! \ >> video/x-raw,format=NV12,width=1920,height=1080 ! \ >> videoscale ! videoconvert ! \ >> video/x-raw,format=NV12,width=1920,height=1088 ! \ >> v4l2jpegenc ! \ >> fakesink sync=false >> >> gst-launch-1.0 videotestsrc is-live=true pattern=smpte ! \ >> video/x-raw,format=NV12,width=1920,height=1088 ! \ >> v4l2jpegenc extra-controls="controls,compression_quality=85" ! \ >> fpsdisplaysink -v sync=false >> >> Performance measurements on SM8250 >> (NV12, quality=100, GStreamer v4l2jpegenc vs jpegenc): >> >> +------------+-----------------------------+-------------------+ >> | Resolution | HW v4l2jpegenc (q100) | SW jpegenc (q100) | >> | | Execution | avrFPS | maxFPS | Execution | FPS | >> +------------+-----------+--------+--------+-----------+-------+ >> | 512x512 | 2.2332 | 1139.1 | 1195.4 | 7.1055 | 358.0 | >> | 1280x720 | 1.7300 | 418.5 | 457.2 | 5.0585 | 143.1 | >> | 1024x1024 | 1.6991 | 374.3 | 397.4 | 4.7304 | 134.4 | >> | 1920x1088 | 1.6596 | 192.8 | 193.8 | 3.7913 | 84.4 | >> | 2048x2048 | 1.7277 | 92.0 | 91.6 | 3.6343 | 43.7 | >> | 4096x4096 | 1.5887 | 25.2 | 25.3 | 4.2163 | 9.5 | >> | 8192x8192 | 1.3104 | 7.6 | 8.0 | 2.9987 | 3.3 | >> +------------+-----------+--------+--------+-----------+-------+ >> >> Signed-off-by: Atanas Filipov >> --- >> .../bindings/media/qcom,jpeg-encoder.yaml | 143 +- > > > NAK > > > ... > > >> diff --git a/drivers/media/platform/qcom/Kconfig b/drivers/media/platform/qcom/Kconfig >> index 4f4d3a68e6e5..f33d53a754a0 100644 >> --- a/drivers/media/platform/qcom/Kconfig >> +++ b/drivers/media/platform/qcom/Kconfig >> @@ -5,3 +5,4 @@ comment "Qualcomm media platform drivers" >> source "drivers/media/platform/qcom/camss/Kconfig" >> source "drivers/media/platform/qcom/iris/Kconfig" >> source "drivers/media/platform/qcom/venus/Kconfig" >> +source "drivers/media/platform/qcom/jpeg/Kconfig" > > Just like for other patch, you ignored reviewers' feedback. > > I already asked you to go through previous comments around v3. I do not > see improvements, so I assume you do it deliberately. > > NAK > > Best regards, > Krzysztof Acknowledged. Inline replies to all previous comments have been sent. v5 will address all outstanding items. Best regards, Atanas