From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EDBCC282C3 for ; Thu, 24 Jan 2019 07:54:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 143662184C for ; Thu, 24 Jan 2019 07:54:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726516AbfAXHyi (ORCPT ); Thu, 24 Jan 2019 02:54:38 -0500 Received: from mx2.suse.de ([195.135.220.15]:44174 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725931AbfAXHyi (ORCPT ); Thu, 24 Jan 2019 02:54:38 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id BE01EAFD9; Thu, 24 Jan 2019 07:54:36 +0000 (UTC) Subject: Re: [PATCH] SCSI: fcoe: remove unneeded fcoe_ctlr_destroy_store export To: Greg Kroah-Hartman , Johannes Thumshirn , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org References: <20190122142818.GC18225@kroah.com> From: Hannes Reinecke Message-ID: Date: Thu, 24 Jan 2019 08:54:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20190122142818.GC18225@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/22/19 3:28 PM, Greg Kroah-Hartman wrote: > There's no need to export fcoe_ctlr_destroy_store as a symbol, so remove > the EXPORT_SYMBOL() line for it. > > Cc: Johannes Thumshirn > Cc: "James E.J. Bottomley" > Cc: "Martin K. Petersen" > Signed-off-by: Greg Kroah-Hartman > --- > drivers/scsi/fcoe/fcoe_transport.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c > index f4909cd206d3..6d3949b687ef 100644 > --- a/drivers/scsi/fcoe/fcoe_transport.c > +++ b/drivers/scsi/fcoe/fcoe_transport.c > @@ -855,7 +855,6 @@ ssize_t fcoe_ctlr_destroy_store(struct bus_type *bus, > mutex_unlock(&ft_mutex); > return rc; > } > -EXPORT_SYMBOL(fcoe_ctlr_destroy_store); > > /** > * fcoe_transport_create() - Create a fcoe interface > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)