Re: [PATCH] ALSA: hda/realtek: Add quirk for Legion S7 15IMH

[Eric Naim <dnaim@cachyos.org>]

[-- Attachment #1: Type: text/plain, Size: 1572 bytes --]

On 4/14/26 3:06 PM, Takashi Iwai wrote:
> On Tue, 14 Apr 2026 05:28:00 +0200,
> Eric Naim wrote:
>>
>> On 4/13/26 11:56 PM, Takashi Iwai wrote:
>>> On Mon, 13 Apr 2026 17:48:17 +0200,
>>> Eric Naim wrote:
>>>>
>>>> Fix speaker output on the Lenovo Legion S7 15IMH05.
>>>>
>>>> Cc: stable@vger.kernel.org
>>>> Signed-off-by: Eric Naim <dnaim@cachyos.org>
>>>
>>> Thanks, applied now.
>>>
>>>
>>> Takashi
>>
>> Sorry Takashi, can you remove this from your tree? I seem to have gotten the
>> PID wrong for this device. I'll follow up with a v2 or fixup once I've
>> confirmed I got the correct PID. Let me know which of the two resolutions you
>> prefer.
> 
> As the tree was published, could you rather a correction patch on the
> top?  Put Fixes tag for pointing to the corrected commit.
> 
> 
> thanks,
> 
> Takashi

Alright, I finally got a reply from the user that requested this from me.
After looking at [1] and reading through [2], it looks like the HDA verbs for
ALC287_FIXUP_LEGION_15IMHG05_SPEAKERS are just copied from
ALC287_FIXUP_YOGA7_14ITL_SPEAKERS, and is different from the original patch
that was tested in [2] and the provided verbs from [1].

Cameron, you submitted the original patch for this. Can you confirm?

Attached is my proposal fix for the ALC287_FIXUP_LEGION_15IMHG05_SPEAKERS
quirk. I'll get the reporter to test this and report back.

[1]
https://github.com/thiagotei/linux-realtek-alc287/blob/2a3a57c14adf3313d4c14df1a0a8a8bd3f544369/lenovo-legion/verbs-legion.txt

[2] https://bugzilla.kernel.org/show_bug.cgi?id=208555

-- 
Regards,
  Eric

[-- Attachment #2: 15imh-fixup.patch --]
[-- Type: text/x-patch, Size: 721 bytes --]

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index ae74e1b69eb3..1f174b70ec57 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -6107,12 +6107,6 @@ static const struct hda_fixup alc269_fixups[] = {
 			 { 0x20, AC_VERB_SET_COEF_INDEX, 0x24 },
 			 { 0x20, AC_VERB_SET_PROC_COEF, 0x41 },
 
-			 { 0x20, AC_VERB_SET_COEF_INDEX, 0x26 },
-			 { 0x20, AC_VERB_SET_PROC_COEF, 0xc },
-			 { 0x20, AC_VERB_SET_PROC_COEF, 0x0 },
-			 { 0x20, AC_VERB_SET_PROC_COEF, 0x1a },
-			 { 0x20, AC_VERB_SET_PROC_COEF, 0xb020 },
-
 			 { 0x20, AC_VERB_SET_COEF_INDEX, 0x26 },
 			 { 0x20, AC_VERB_SET_PROC_COEF, 0x2 },
 			 { 0x20, AC_VERB_SET_PROC_COEF, 0x0 },