From: Adam Manzanares <Adam.Manzanares@wdc.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"bcrl@kvack.org" <bcrl@kvack.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-aio@kvack.org" <linux-aio@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] fs: add RWF_IOPRIO
Date: Wed, 2 May 2018 17:51:25 +0000 [thread overview]
Message-ID: <e97ca367-a5d2-5780-a339-0be1aac33f03@wdc.com> (raw)
In-Reply-To: <20180502173207.GA27997@infradead.org>
On 5/2/18 10:32 AM, Christoph Hellwig wrote:
> On Mon, Apr 30, 2018 at 09:57:39AM -0700, adam.manzanares@wdc.com wrote:
>> From: Adam Manzanares <adam.manzanares@wdc.com>
>>
>> This is the per-I/O equivalent of the ioprio_set system call.
>>
>> When the RWF_IOPRIO flag is set then the aio_reqprio field of the iocb
>> is interpreted as an I/O scheduling class and priority.
>
> I think this belongs into the IOCB_FLAG_* flags namespace for aio_flags
> field as it isn't a field valid for plain read/write.
>
> Also you probably want to merge both patches as they only really
> make sense together.
>
I will make the changes and send out a v2.
next prev parent reply other threads:[~2018-05-02 17:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 16:57 [PATCH 0/2] AIO add per-command iopriority adam.manzanares
2018-04-30 16:57 ` [PATCH 1/2] fs: add RWF_IOPRIO adam.manzanares
2018-05-02 17:32 ` Christoph Hellwig
2018-05-02 17:51 ` Adam Manzanares [this message]
2018-04-30 16:57 ` [PATCH 2/2] fs: Add aio priority support for block_dev adam.manzanares
2018-05-02 17:33 ` Christoph Hellwig
2018-05-02 18:07 ` Adam Manzanares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e97ca367-a5d2-5780-a339-0be1aac33f03@wdc.com \
--to=adam.manzanares@wdc.com \
--cc=bcrl@kvack.org \
--cc=hch@infradead.org \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®