From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751494AbdJXQF0 (ORCPT ); Tue, 24 Oct 2017 12:05:26 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:47484 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbdJXQFX (ORCPT ); Tue, 24 Oct 2017 12:05:23 -0400 Subject: Re: [PATCH] rds: Fix inaccurate accounting of unsignaled wrs To: =?UTF-8?Q?H=c3=a5kon_Bugge?= Cc: "David S . Miller" , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org References: <20171024141628.14637-1-Haakon.Bugge@oracle.com> From: Santosh Shilimkar Organization: Oracle Corporation Message-ID: Date: Tue, 24 Oct 2017 09:05:59 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171024141628.14637-1-Haakon.Bugge@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/24/2017 7:16 AM, Håkon Bugge wrote: > The number of unsignaled work-requests posted to the IB send queue is > tracked by a counter in the rds_ib_connection struct. When it reaches > zero, or the caller explicitly asks for it, the send-signaled bit is > set in send_flags and the counter is reset. This is performed by the > rds_ib_set_wr_signal_state() function. > > However, this function is not always used which yields inaccurate > accounting. This commit fixes this, re-factors a code bloat related to > the matter, and makes the actual parameter type to the function > consistent. > > Signed-off-by: Håkon Bugge > --- Instead of partially doing changes inside/outside helper, can also add inline helper for solicited state like rds_ib_set_wr_solicited_state() and use that along with this change. Regards, Santosh