Re: [PATCH v3 4/5] dt-bindings: rtc: at91: Use macros for the IRQ type

[Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>]

On 04/03/2022 15:27, Sergiu Moga wrote:
> Prefer using macros for the IRQ type of the example node's
> interrupt property.
> 
> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com>
> ---
>  Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml b/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
> index af25cc275356..d2452067bfe4 100644
> --- a/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
> @@ -54,10 +54,12 @@ unevaluatedProperties: false
>  
>  examples:
>    - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
>      rtc@fffffd20 {
>          compatible = "atmel,at91sam9260-rtt";
>          reg = <0xfffffd20 0x10>;
> -        interrupts = <1 4 7>;
> +        interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;

Ah, I see the change now. This should be squashed with previous patch.
There is no point to add imperfect DTS code which is being changed a
commit later. Example is not bindings.

Best regards,
Krzysztof