From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78A713C8737 for ; Wed, 1 Apr 2026 09:20:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775035255; cv=none; b=D0nmsLyXGvUK4q7JoC0Td6mLCbQSYNzb8+6Gj/XTGBiD9JFcLE1Kna5G3SUDIRXdSXbc8QKBvmjqeGpC5y4WDtgLoa5piEpza1+fKif93r2n1hzbkz897Tgusi8GN9UasSx4lGUWzR13pF/FE1A0N+dwnZjV/+8I3hj7RfTWsRU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775035255; c=relaxed/simple; bh=DGtvIpbiWD7ytTqar1h4W/k/GUYAQhsU+yvPvBppFgQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iEPVvaNg/5CR2hS3n7Q7rOjVKvCbXsP5f+Q+1jxDzuv31tSvMx5ofua0neTSAW4SroU7QCRQjv0KPM/m9m7UvPO416rX96uA5LoiEdJh37Y2A0lETYgXa/89P34k8ylms1YufvRntuD7GVYBdurAxKHzLCCdz2cL3PjXgUJaqyI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VhrPv9Ky; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TBWJpMS3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VhrPv9Ky"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TBWJpMS3" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6317eLjw3081386 for ; Wed, 1 Apr 2026 09:20:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rd6i6PS13zNbPN8wfoARw23Hz+l/0tkOZmobKVqMN0M=; b=VhrPv9Ky/buoEFuf vjdJOy0Z0aAS90fBmY/VcagFtYl4sj3rcq3R0A/FNIf3X0JHVudK+b2YPftaqLrR ZZ6td5Vfk1QkvRaExzvXiK2BwY1/G7HdV5gEOKLJOUafkSQqEgXZYCf9kB3HbaG8 wY2HsuahYCqEn8t0QlWGDYBl+8dgeLPchC7JsJgglGtMuU22swLI/M2v90AjweGO aphOSNAhrEt9TaVGMbubpzJnydinZLq/x5HSKHUfsY9FtuK2gMMzWp2Ls1GLqDEq I5DEdnhuJbmQsxBlbEsrR0nmXK8BTUNmmb8AN3UvItkb94XjUarCHT3H/GKN3pFJ 3YsY9w== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d8kdku9wx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Apr 2026 09:20:53 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-89ccf10567dso33523386d6.3 for ; Wed, 01 Apr 2026 02:20:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775035253; x=1775640053; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rd6i6PS13zNbPN8wfoARw23Hz+l/0tkOZmobKVqMN0M=; b=TBWJpMS3Hd7tSdnrENgWimGBOEkGbGXScDfEPP0Mr1RB1EEKFQRgaZb9rOzX/h41TX oNciIIlODAMQQEPEuw1zYMHXR2mClh2IZHcVvgutR64kNqH+k0SR5czIIJB8kHgExlyO 7TifclXBXaWQ9JzJrgt35P33ODjEN0SpNCUY0PMfDq0yY9XCp1CJ+QYm1OWtGzeQ/kUx 742+Q27dlSUGQaxeDQtWfDhOC5tBrTecLo1B+WdcVYVgJYMIU218z5CMbgsdKiPAYGqw oTyuYptMTR0az/SxOS/GGXEqGo/jFitRemq9GJgh7FPVwNHcjqFWsO4z6MpVOB41Vydy KV2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775035253; x=1775640053; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rd6i6PS13zNbPN8wfoARw23Hz+l/0tkOZmobKVqMN0M=; b=mOvFjPBcv8JVYXhzrwLrtfrddMq3ykhzLUCgrUVEBph+spDsETjOY729/nRx4hJwQZ pcaear2K7HvF038vv/atDurufmcN5iLnLdSxUXxu42FSErq8UmSanuFZh4KpBJeoJU36 QhQmlWKp5WMxj9oUnrHtSJ7diJ/KGUw4yahEBYTF89jv1CBY1gTSnNvKNU6C+6X3PRMw M8ztiNBTQFqBEo4fUiS+SZs25YARQvIlZ/KIZhYIRgwvHPPkwT2EksskqXKzaJFymGAP gWM23FrQqvVpNKjrDKhvTwgudxQNvA/QT897t39JPSqT722L+Zexjm7x7mNDgIGUI9LZ IfHA== X-Forwarded-Encrypted: i=1; AJvYcCVg9zSTjWFWSvut6XnQ30ogrscWE2RRYSfkYpmQWb1GtYg6zJ51Nhxz3czAfcaOe7OcihG4P6Zd3/6h1p0=@vger.kernel.org X-Gm-Message-State: AOJu0YybYvQXtDT2vE5II9Q3xpdbD0qM01XYk14IX/yOYTcfVl5RjOG0 +nuVom5Y+psEpogD181bQ+eSfy09LVatLkfK2YY3SwHz2o6+MHOsm2v1tYx7dxbwQJzcN4CuPAS hnR+tytD5OZLE6K3N5UwrciBgn+e+gwMiahJdhBsuJQ6it6hLgfmdX2HoEeq9LD9NJmc= X-Gm-Gg: ATEYQzyH4wofAquCcmF+gehpJvFW6fx9c8tU9cnKfflym6XsJllWKQz19d9vvXXZ8Dh DfLa+Ipx+MFyKkogagReW0i1mjFdp69ozQOVrGkf17kGlkGzoveTKxkx+mxTFpe5Ttg95AZ0FtT NUEDeLevS9qormF6LGY9mxujLoQp909R5FAeGtab2iQjnVXclXCZcw2GceyfxyM3wy78qtZ3uwZ TeMxeBHRip4adbRr6IMat8v5KDhmv3N5tZmi6vZ7gYu7kq4RWU3s6tjzOTvpWgrt2FB1OZmt2uS kPDU+3K6Zl5eSisapdaOWuKwdoLf5aobyH8f4A32CZc6lTk4EfIJe7v9mpQ/zwAQ4agxq8kqnSR KMbAl8Ha8XLtNVbJysawsGH493AaB5xT1EGrUD+xHUh2IYVUDoRLj/TiaWZa27sHATtiW9PDXr/ VIS40= X-Received: by 2002:a05:6214:c2c:b0:89a:575e:ec01 with SMTP id 6a1803df08f44-8a436d10877mr30371086d6.1.1775035252934; Wed, 01 Apr 2026 02:20:52 -0700 (PDT) X-Received: by 2002:a05:6214:c2c:b0:89a:575e:ec01 with SMTP id 6a1803df08f44-8a436d10877mr30370816d6.1.1775035252445; Wed, 01 Apr 2026 02:20:52 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b7ae51ef5sm491498966b.18.2026.04.01.02.20.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Apr 2026 02:20:51 -0700 (PDT) Message-ID: Date: Wed, 1 Apr 2026 11:20:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] arm64: dts: qcom: x1e80100-dell-xps13-9345: introduce EC To: Aleksandrs Vinarskis , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, laurentiu.tudor1@dell.com, Abel Vesa , Tobias Heider , Val Packett References: <20260401-dell-xps-9345-ec-v1-0-afa5cacd49be@vinarskis.com> <20260401-dell-xps-9345-ec-v1-4-afa5cacd49be@vinarskis.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260401-dell-xps-9345-ec-v1-4-afa5cacd49be@vinarskis.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDA4MiBTYWx0ZWRfX4N7h0i5Ix8Om wJ1DW4FhMnjn/rrVffMMbOEdVWoJRoQUWQ9dy10tv9SQtVyN0gIlCf2851HW0g/F3LUAHvZQYp3 AQ6gJ5G9VQUydxPEKCGAGsIyfLx+vgNe+ZEtmZsjzDIGxuBgI0jZZfdnoqL1x7FP14mJ3OBn5Q2 edbFTLZkKVJP1btP+Nlo/EVz6uwete+iY/GINJotDj4lpN4CwXEhHpi8zBWPO6DB6dpZ1IiU6FQ YvEcW/yTx8l1OZDj3qVoarfWgAwfMj2qrRxo58UB5q99f74RIQzEJFCOf9+Oy/k5S7o45P/be0Y ypnaH7yPXV0GcWq+JOq2M6OQ3C3n7Vk9zCW0intMlSmr7oEiUQ0Xc1WHJj3JvEbggVDIZoHpJQC vsI77o4zRwndTlvYVGUSWmPVegX46AegkmAF9vfeaejjkadtg8scVzbkwq2sPHA0WTiZSFjhYFT Cb7DnRwPqXQxRx2uKXA== X-Proofpoint-GUID: C1u8YLz8gPQTM_mmIQtLaOiqgyFLJkNk X-Authority-Analysis: v=2.4 cv=YsQChoYX c=1 sm=1 tr=0 ts=69cce375 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=I76Qk8w-AAAA:8 a=JKr7C61JAH-ZL2TGNHYA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 a=vUPM0Wvl0xcrLs4nqPIT:22 X-Proofpoint-ORIG-GUID: C1u8YLz8gPQTM_mmIQtLaOiqgyFLJkNk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_03,2026-04-01_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 bulkscore=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604010082 On 4/1/26 9:33 AM, Aleksandrs Vinarskis wrote: > Describe embedded controller, its interrupt and required thermal zones. > Add EC's reset GPIO to reserved range, as triggering it during device > operation leads to unrecoverable and unusable state. > > Signed-off-by: Aleksandrs Vinarskis > --- [...] > + io-channels = <&pmk8550_vadc PM8350_ADC7_GPIO3_100K_PU(1)>, > + <&pmk8550_vadc PM8350_ADC7_GPIO4_100K_PU(1)>, > + <&pmk8550_vadc PM8350_ADC7_AMUX_THM1_100K_PU(1)>, > + <&pmk8550_vadc PM8350_ADC7_AMUX_THM2_100K_PU(1)>, > + <&pmk8550_vadc PM8350_ADC7_AMUX_THM3_100K_PU(1)>, > + <&pmk8550_vadc PM8350_ADC7_AMUX_THM4_100K_PU(1)>, > + <&pmk8550_vadc PM8350_ADC7_AMUX_THM5_100K_PU(1)>; > + > + io-channel-names = "sys_therm0", "sys_therm1", "sys_therm2", > + "sys_therm3", "sys_therm4", "sys_therm5", > + "sys_therm6"; nit: one a line please, without a separating \n between x and x-names [...] > +&pmk8550_vadc { > + /* sys_therm0, around DRAM */ another nit: I think repeating the name set in the label in each comment is a little excessive [...] > &tlmm { > gpio-reserved-ranges = <44 4>, /* SPI11 (TPM) */ > + <65 1>, /* EC Reset */ Is that a "this may not be accessed" or rather "you can, but it has dire consequences"? Would the EC driver/binding benefit from having a reference to that pin? Konrad