From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To: "Germán Poo-Caamaño" <gpoo@igalia.com>
Cc: "Mark Brown" <broonie@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Peter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
"Germán Poo-Caamaño" <gpoo@igalia.com>
Subject: Re: [PATCH 0/3] ASoC: hdac_hda/soc-pcm: fix NULL ops.open() call and failed BE open cleanup
Date: Tue, 17 Nov 2026 11:45:28 +0200 (EET) [thread overview]
Message-ID: <e98302a0-faf1-7912-47b6-f8d9c0637716@linux.intel.com> (raw)
In-Reply-To: <20261114024706.2659774-1-gpoo@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 797 bytes --]
Hello,
On Fri, 13 Nov 2026, Germán Poo-Caamaño wrote:
> From: Germán Poo-Caamaño <gpoo@igalia.com>
>
> On a ThinkPad X1 Carbon Gen 10 (ALC287, SOF with skl_hda_dsp_generic),
> the codec sometimes comes up without pin configuration and the
> analog PCM has no playback stream. Opening the SOF analog playback
> PCM then calls a NULL ops.open() in hdac_hda_dai_open(). The task
> dies holding the card's DPCM mutex and system suspend can no longer
> freeze tasks.
thank you, for the series:
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Covering the history with commit 06f07e236537 ("ASoC: hdac_hda: fix
deadlock after PCM open error") and commit 00a0b46c99e2 ("ASoC: soc-dai:
add mark for snd_soc_dai_startup/shutdown()") in third patch is very
helpful. And looks good.
Br, Kai
parent reply other threads:[~2026-11-17 9:45 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20261114024706.2659774-1-gpoo@igalia.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e98302a0-faf1-7912-47b6-f8d9c0637716@linux.intel.com \
--to=kai.vehmanen@linux.intel.com \
--cc=broonie@kernel.org \
--cc=gpoo@igalia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®