From: Florian Fainelli <florian.fainelli@broadcom.com>
To: zakkemble@gmail.com, Doug Berger <opendmb@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: bcmgenet: tidy up stats, expose more stats in ethtool
Date: Mon, 12 May 2025 16:35:50 +0200 [thread overview]
Message-ID: <e9830d60-d711-4fab-a4e8-329c5a3353f5@broadcom.com> (raw)
In-Reply-To: <20250511214037.2805-1-zakkemble@gmail.com>
On 5/11/2025 11:40 PM, zakkemble@gmail.com wrote:
> From: Zak Kemble <zakkemble@gmail.com>
>
> This patch exposes more statistics counters in ethtool and tidies up the
> counters so that they are all per-queue. The netdev counters are now only
> updated synchronously in bcmgenet_get_stats instead of a mix of sync/async
> throughout the driver. Hardware discarded packets are now counted in their
> own missed stat instead of being lumped in with general errors.
>
> Signed-off-by: Zak Kemble <zakkemble@gmail.com>
If you are making changes to the driver around statistics, I would
rather you modernize the driver to report statistics according to how it
should be done, that is following what bcmasp2 does. Thank you.
--
Florian
next prev parent reply other threads:[~2025-05-12 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-11 21:40 zakkemble
2025-05-12 9:57 ` kernel test robot
2025-05-12 12:24 ` Andrew Lunn
2025-05-12 14:35 ` Florian Fainelli [this message]
2025-05-13 19:20 ` Zak Kemble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9830d60-d711-4fab-a4e8-329c5a3353f5@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=zakkemble@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®