mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nitin Gupta <nitin.m.gupta@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: mike.kravetz@oracle.com, akpm@linux-foundation.org,
	kirill.shutemov@linux.intel.com, julian.calaby@gmail.com,
	hughd@google.com, adam.buchbinder@gmail.com, minchan@kernel.org,
	sfr@canb.auug.org.au, paul.gortmaker@windriver.com,
	thomas.tai@oracle.com, chris.hyser@oracle.com,
	atish.patra@oracle.com, mhocko@suse.com,
	sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] sparc64: Multi-page size support
Date: Tue, 3 Jan 2017 17:22:39 -0800	[thread overview]
Message-ID: <e9870606-812c-5efe-bc35-ea31fac303a6@oracle.com> (raw)
In-Reply-To: <20161227.123409.1061591712732030012.davem@davemloft.net>



On 12/27/2016 09:34 AM, David Miller wrote:
> From: Nitin Gupta <nitin.m.gupta@oracle.com>
> Date: Tue, 13 Dec 2016 10:03:18 -0800
> 
>> +static unsigned int sun4u_huge_tte_to_shift(pte_t entry)
>> +{
>> +	unsigned long tte_szbits = pte_val(entry) & _PAGE_SZALL_4V;
>> +	unsigned int shift;
>> +
>> +	switch (tte_szbits) {
>> +	case _PAGE_SZ256MB_4U:
>> +		shift = HPAGE_256MB_SHIFT;
>> +		break;
> 
> You added all the code necessary to do this on the sun4u chips that support
> 256MB TTEs, so you might as well enable it in the initialization code.
> 
> I'm pretty sure this is an UltraSPARC-IV and later feature.
> 

I added sun4u related changes just for completeness sake. I don't have
access to a sun4u machine so can't be sure if sun4u would work.
That's why that _PAGE_SZALL_4V typo escaped my notice.

I will enable setup_hugepagesz() for non-hypervisor case and send a v5.

Thanks,
Nitin

  reply	other threads:[~2017-01-04  1:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-13 18:03 Nitin Gupta
2016-12-27 17:34 ` David Miller
2017-01-04  1:22   ` Nitin Gupta [this message]
2016-12-27 17:34 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9870606-812c-5efe-bc35-ea31fac303a6@oracle.com \
    --to=nitin.m.gupta@oracle.com \
    --cc=adam.buchbinder@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=atish.patra@oracle.com \
    --cc=chris.hyser@oracle.com \
    --cc=davem@davemloft.net \
    --cc=hughd@google.com \
    --cc=julian.calaby@gmail.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@suse.com \
    --cc=mike.kravetz@oracle.com \
    --cc=minchan@kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=sfr@canb.auug.org.au \
    --cc=sparclinux@vger.kernel.org \
    --cc=thomas.tai@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®