From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57E01C433F5 for ; Tue, 21 Dec 2021 18:51:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241553AbhLUSvH (ORCPT ); Tue, 21 Dec 2021 13:51:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:40844 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234501AbhLUSvG (ORCPT ); Tue, 21 Dec 2021 13:51:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1640112666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7hczl/fhcvDkf/yKuUBJ4xYsAaOY7Hv0t7pVBWGg6a8=; b=FXzE6vgJaj1hIuss3k5bttYKWrI5uMJnsGt1r/rDcZuJkuCpMVA6qwPLJ68FxY/EYA5ngV RwQICmCNoQYDp+8g8VbPSKzjJGWyVskjYdCoOyg2XRSLFV6MickjYLzIY4V4nSwgI19hew EAEKSePB5Sj9b5lD1hPLV/4bZrEXLuQ= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-280-2ROhmg7AN7CQ7VQNxygagA-1; Tue, 21 Dec 2021 13:51:04 -0500 X-MC-Unique: 2ROhmg7AN7CQ7VQNxygagA-1 Received: by mail-ed1-f71.google.com with SMTP id dz8-20020a0564021d4800b003f897935eb3so543257edb.12 for ; Tue, 21 Dec 2021 10:51:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=7hczl/fhcvDkf/yKuUBJ4xYsAaOY7Hv0t7pVBWGg6a8=; b=VyI1bejJl5547cOSnhmN254Geih9ocPLYcxXyZQfyyKP8uH0uCC+Fp2M0e0m+Vib9j +2fhVx1iwnvJVw9mEVKF1RxweeduTraJUV/Cx5l4Z6f5olD+l3lVuYdmbVQyrt9MPRh0 nvqcTPbzTmrUnk0pymvTtIBCgwsRrlI7a3dHm4MlS6zztUxjGDpEHIasS8q/lcWh1wB+ MdyOb5rt0xpjU8cWzEAEqypTZwagWP3MwyfBaA1fZxhvyNLOtFkJVVPVyFAqONA9xAco eWrwJl5Adw5xxZI3q9A5PIYhopl6Moc+TThDjjaKbGLPCkmwMN9eq7XCJ+KUrr5nbU4r tMcQ== X-Gm-Message-State: AOAM533O2IYP2DLlGh78yF7chUU02VsfmkLaeEmjDSA9nhkZFgrwNdr3 HDx7npOfFwSKYEryjtZ3N4UO9aLm4i/+8rGpQwaKz38MlQDxrRPDQ/sFF+CFGk9003euD6rITra PGC1Oa9ca5Ozgi6ayDYYqhhhr X-Received: by 2002:a17:906:9b82:: with SMTP id dd2mr3766369ejc.406.1640112663658; Tue, 21 Dec 2021 10:51:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJzKhGJI6p5aykoXdpRRPjv5+TiP/RvCQZELs9dzZejbGpMiW+w3+zd7TBCkvjW+JID/ORuo1A== X-Received: by 2002:a17:906:9b82:: with SMTP id dd2mr3766345ejc.406.1640112663393; Tue, 21 Dec 2021 10:51:03 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id w22sm8960767edd.49.2021.12.21.10.51.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Dec 2021 10:51:02 -0800 (PST) Message-ID: Date: Tue, 21 Dec 2021 19:51:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH v3 1/3] drm/privacy_screen: Add drvdata in drm_privacy_screen Content-Language: en-US To: Rajat Jain , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Benson Leung , Henrique de Moraes Holschuh , Mark Gross , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, gwendal@google.com, seanpaul@google.com, marcheu@google.com, dtor@google.com Cc: rajatxjain@gmail.com References: <20211220222828.2625444-1-rajatja@google.com> From: Hans de Goede In-Reply-To: <20211220222828.2625444-1-rajatja@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 12/20/21 23:28, Rajat Jain wrote: > Allow a privacy screen provider to stash its private data pointer in the > drm_privacy_screen, and update the drm_privacy_screen_register() call to > accept that. Also introduce a *_get_drvdata() so that it can retrieved > back when needed. > > This also touches the IBM Thinkpad platform driver, the only user of > privacy screen today, to pass NULL for now to the updated API. > > Signed-off-by: Rajat Jain Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > v3: Initial version. Came up due to review comments on v2 of other patches. > v2: No v2 > v1: No v1 > > drivers/gpu/drm/drm_privacy_screen.c | 5 ++++- > drivers/platform/x86/thinkpad_acpi.c | 2 +- > include/drm/drm_privacy_screen_driver.h | 13 ++++++++++++- > 3 files changed, 17 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_privacy_screen.c b/drivers/gpu/drm/drm_privacy_screen.c > index beaf99e9120a..03b149cc455b 100644 > --- a/drivers/gpu/drm/drm_privacy_screen.c > +++ b/drivers/gpu/drm/drm_privacy_screen.c > @@ -387,7 +387,8 @@ static void drm_privacy_screen_device_release(struct device *dev) > * * An ERR_PTR(errno) on failure. > */ > struct drm_privacy_screen *drm_privacy_screen_register( > - struct device *parent, const struct drm_privacy_screen_ops *ops) > + struct device *parent, const struct drm_privacy_screen_ops *ops, > + void *data) > { > struct drm_privacy_screen *priv; > int ret; > @@ -404,6 +405,7 @@ struct drm_privacy_screen *drm_privacy_screen_register( > priv->dev.parent = parent; > priv->dev.release = drm_privacy_screen_device_release; > dev_set_name(&priv->dev, "privacy_screen-%s", dev_name(parent)); > + priv->drvdata = data; > priv->ops = ops; > > priv->ops->get_hw_state(priv); > @@ -439,6 +441,7 @@ void drm_privacy_screen_unregister(struct drm_privacy_screen *priv) > mutex_unlock(&drm_privacy_screen_devs_lock); > > mutex_lock(&priv->lock); > + priv->drvdata = NULL; > priv->ops = NULL; > mutex_unlock(&priv->lock); > > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c > index 341655d711ce..ccbfda2b0095 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -9782,7 +9782,7 @@ static int tpacpi_lcdshadow_init(struct ibm_init_struct *iibm) > return 0; > > lcdshadow_dev = drm_privacy_screen_register(&tpacpi_pdev->dev, > - &lcdshadow_ops); > + &lcdshadow_ops, NULL); > if (IS_ERR(lcdshadow_dev)) > return PTR_ERR(lcdshadow_dev); > > diff --git a/include/drm/drm_privacy_screen_driver.h b/include/drm/drm_privacy_screen_driver.h > index 24591b607675..4ef246d5706f 100644 > --- a/include/drm/drm_privacy_screen_driver.h > +++ b/include/drm/drm_privacy_screen_driver.h > @@ -73,10 +73,21 @@ struct drm_privacy_screen { > * for more info. > */ > enum drm_privacy_screen_status hw_state; > + /** > + * @drvdata: Private data owned by the privacy screen provider > + */ > + void *drvdata; > }; > > +static inline > +void *drm_privacy_screen_get_drvdata(struct drm_privacy_screen *priv) > +{ > + return priv->drvdata; > +} > + > struct drm_privacy_screen *drm_privacy_screen_register( > - struct device *parent, const struct drm_privacy_screen_ops *ops); > + struct device *parent, const struct drm_privacy_screen_ops *ops, > + void *data); > void drm_privacy_screen_unregister(struct drm_privacy_screen *priv); > > void drm_privacy_screen_call_notifier_chain(struct drm_privacy_screen *priv); >