From: Neil Armstrong <neil.armstrong@linaro.org>
To: Conor Dooley <conor@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: qcom-lpg: document PM8550 compatible
Date: Mon, 22 May 2023 20:00:18 +0200 [thread overview]
Message-ID: <e98e39e3-c10d-65d1-3093-2d54888b1829@linaro.org> (raw)
In-Reply-To: <20230522-childhood-eastbound-06a5f02f1f4a@spud>
On 22/05/2023 19:39, Conor Dooley wrote:
> On Mon, May 22, 2023 at 06:26:01PM +0200, Neil Armstrong wrote:
>> The PM8550 PWM modules are compatible with the PM8350c PWM modules,
>> document the PM8350c PWM compatible as fallback for the PM8550 PWM.
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>
> I suppose you picked "items/enum", rather than "items/const" to reduce
> future churn?
Yes indeed.
Thanks,
Neil
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> Thanks,
> Conor.
>
>> ---
>> .../devicetree/bindings/leds/leds-qcom-lpg.yaml | 30 +++++++++++++---------
>> 1 file changed, 18 insertions(+), 12 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
>> index 6295c91f43e8..fa378ee05c16 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
>> +++ b/Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml
>> @@ -16,18 +16,24 @@ description: >
>>
>> properties:
>> compatible:
>> - enum:
>> - - qcom,pm660l-lpg
>> - - qcom,pm8150b-lpg
>> - - qcom,pm8150l-lpg
>> - - qcom,pm8350c-pwm
>> - - qcom,pm8916-pwm
>> - - qcom,pm8941-lpg
>> - - qcom,pm8994-lpg
>> - - qcom,pmc8180c-lpg
>> - - qcom,pmi8994-lpg
>> - - qcom,pmi8998-lpg
>> - - qcom,pmk8550-pwm
>> + oneOf:
>> + - enum:
>> + - qcom,pm660l-lpg
>> + - qcom,pm8150b-lpg
>> + - qcom,pm8150l-lpg
>> + - qcom,pm8350c-pwm
>> + - qcom,pm8916-pwm
>> + - qcom,pm8941-lpg
>> + - qcom,pm8994-lpg
>> + - qcom,pmc8180c-lpg
>> + - qcom,pmi8994-lpg
>> + - qcom,pmi8998-lpg
>> + - qcom,pmk8550-pwm
>> + - items:
>> + - enum:
>> + - qcom,pm8550-pwm
>> + - const: qcom,pm8350c-pwm
>> +
>>
>> "#pwm-cells":
>> const: 2
>>
>> ---
>> base-commit: 44c026a73be8038f03dbdeef028b642880cf1511
>> change-id: 20230522-topic-sm8550-upstream-pm8550-lpg-5bf409842c3d
>>
>> Best regards,
>> --
>> Neil Armstrong <neil.armstrong@linaro.org>
>>
next prev parent reply other threads:[~2023-05-22 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 16:26 Neil Armstrong
2023-05-22 17:39 ` Conor Dooley
2023-05-22 18:00 ` Neil Armstrong [this message]
2023-05-25 11:23 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e98e39e3-c10d-65d1-3093-2d54888b1829@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®