From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A92DA2D8764 for ; Wed, 14 Jan 2026 14:23:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768400631; cv=none; b=cYBE0x8h1etNsqrdE7ts97AZc65D43q99mx9xhg4sRFrrCUSche3mgeopEzaMW4n9dm5s0hG4c3C3DxpzENI9b/nC9J/L3pGuyaNfqoHVrajy+CXhns+Xdpo8DoxPaPC2avMZz90nvx28KFVECkdkKBYNdSctLophRLKbT4CtjA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768400631; c=relaxed/simple; bh=4yI3qv1paP3863JGJN8EaT90z7WyLn3BHwc7lsAkj0g=; h=Message-ID:Date:MIME-Version:Subject:To:References:Cc:From: In-Reply-To:Content-Type; b=BKOAoBYj4mqWWc0+/B4P9Jd7dJ2pFjUmMNOYWzvYWKfvZQ/j3uGnMW1LHOe0mYc7gCQLdD8qopZjqHgX/2AHg2+oFi7Bn1/RVcgsKH8W5R4NeHDWEP7hBjeBSlYOdbswLVFUlCz6EqdkwXrZ0ewdfhWD36I/MwdmBLmltMj577E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GoVaa0M/; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GoVaa0M/" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-2b053ec7d90so8268093eec.0 for ; Wed, 14 Jan 2026 06:23:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768400630; x=1769005430; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=VCTd1UeGbd16C0dw6Flw043UIl8ToTlwb18MsiPCF94=; b=GoVaa0M/ob5LP92LuigTci4rwd8AEn98ed69KJrtijjTKwZOQSNe6VaPoot8EdoJnO YAeeZCBABERSbrdLMCijuAqwLjBiF5xugIA5guZmDDaahAK6o29OlQBvAScp8e8jZ16p NhETAtoS6w1A5u4rclIFGka/r+6IKiSBx9Pocd1XFQqClKUnd+oS25VflweOtoHQNFZ5 3nfJZOkO2is6fb3N64ZtRXYxHtJaOMJQDF7MjYFv7f9qnJiC8QuVNJ8j57WSYkxvy5Ry pj40t0Mwm7Etoij6Ic/g46PzTXzelhXBlU0UfzFDQ4lPx52tXuZra6ISlqkzHiE34sX+ Ftqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768400630; x=1769005430; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VCTd1UeGbd16C0dw6Flw043UIl8ToTlwb18MsiPCF94=; b=IVUrDz8Eeg4DzWsfTtjvvM+fzCG9QA15qEzo/7RG7LHEruMKCXXNpJtuh4u0d67OL8 1maUAC0dzXCXtEP9JAZDkJ57MhvzSymkVhznmndEMqKYGPkKp/PfUsIBXZRo631eOh4f GZJQq2KYOYvYYchriBJ3Sr69F0SPN9QMk9BQ9uWDFKt6P5QaMHycVCVb892h6ohxC8w1 4OAg9jfehj7fNVmLi5WIKYK1HVb30B3l2jnyNgy9Z/43cJiGrQLRHWbN2YFsXoNWJ0dd tlPjt6jMVYYhMaVX5XAeJvpHm3Ts1eAxRbbJIKNt2K8ExrtViax4+irMkBj7zS+wxpXZ F0YA== X-Forwarded-Encrypted: i=1; AJvYcCUPtm0uKJg65K6G8pFoFdqzpBRc5DKZGpiyfsVJJQ8EtAoimooJhWiLdb5HVuH3BdQDeoTAzq27QpWMrgY=@vger.kernel.org X-Gm-Message-State: AOJu0YzAJ1gh9xrzNISTxkBlibh6LZQmYnw2/lmC3OGDSa4GWS2b1h6c GVSGvhW0AuC5U7kZJmzeq3xOl6vETDMZEqZaknQ08dfZK+3fUCMEH7IM X-Gm-Gg: AY/fxX5Yqx/SrJ1ta2rEOMSme97R06tt9jMsscMC7rZJCFMKeBaF9gwvzGX1GG84e+6 KMScNRB2rRp1pSOQUoS00Y7M46J9vlNfEsosCa9wydoA9q1b1GEvG741KBO85aIsOq8ASk0fO+T edgRQv2rsySTXKqD9JJlm+YQzCSAQvNRk2BBCCMkw3RDpCSCEtrHSKQMaw4AgZDTf3csxHO4k1R KYIVa6mhbpF8wJU6hWjKiW736G+NClqAMmKXVv1jf3mPYyCqhOE6vw/oqLNm/AScwu7owGOMcP8 2kgvkbCAmYTHFuNWowBqRxfakgMa0ugKdTbHmt7TrlDgvdqCHlxMXgCeOrPFpd8KK/0qR5Pybbv 5OxlTcTRlfj0yWUMvIzPT9pkPjTcHDpZSs+0AA3DpwRdvPbnjgjW8afqrT4X9jeUkRwoML2iYtd xIO6f6rW6KFuvAgwihv1u8OJu8Q5le9tApBcQjP0EQa93v/bLT1+wgfz8RiiZd X-Received: by 2002:a05:693c:374a:b0:2ac:2dfd:9ff with SMTP id 5a478bee46e88-2b48731ffeemr3380034eec.41.1768400629498; Wed, 14 Jan 2026 06:23:49 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b480dea94fsm1886468eec.24.2026.01.14.06.23.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jan 2026 06:23:48 -0800 (PST) Sender: Guenter Roeck Message-ID: Date: Wed, 14 Jan 2026 06:23:47 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] hwmon: spd5118: Do not fail resume on temporary I2C errors To: TINSAE TADESSE References: <20260110172003.13969-1-tinsaetadesse2015@gmail.com> <2740c3ab-7cb0-4931-81a2-30b85e8615f9@roeck-us.net> Content-Language: en-US Cc: "linux-hwmon@vger.kernel.org" , linux-kernel@vger.kernel.org From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/14/26 05:07, TINSAE TADESSE wrote: ... >>> Hi Guenter, >>> >>> I tested changing the i801 SMBus controller to use >>> SET_LATE_SYSTEM_SLEEP_PM_OPS() instead of >>> DEFINE_SIMPLE_DEV_PM_OPS() as a diagnostic experiment. With this >>> change, spd5118 resume failures (-ENXIO) >>> still persist, suggesting PM ordering alone is insufficient and other >>> firmware interactions are involved. >> >> How about the problem in the suspend function ? Is that also still seen ? >> >> Also, the subject talks about -EIO. Is that still seen ? >> >> Either case, can you enable debug logs for the i801 driver ? >> It should generate log entries when it reports errors. >> >> Thanks, >> Guenter >> > > Hi Guenter, > > Thank you for the questions. To clarify: > Please do not drop mailing lists from replies. > 1) I have not observed any failures in the suspend path. The suspend > callback completes successfully, and > I have not seen I2C errors or warnings during suspend at any point. Sorry, I seem to be missing something. In that case, what is the point of patch 3/3 of your series which removes hardware accesses from the suspend function ? > 2) I have also not observed -EIO in my testing. The error consistently > reported on resume and subsequent hwmon access is -ENXIO. > Earlier references to -EIO were based on assumptions rather than > observed logs, and I should have been clearer about that. > Thanks for the clarification. Guenter > I am enabling debug logging for the i801 driver to collect more > concrete evidence of controller state during resume.