mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Moger, Babu" <babu.moger@amd.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>
Cc: "fenghua.yu@intel.com" <fenghua.yu@intel.com>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"paulmck@kernel.org" <paulmck@kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
	"rdunlap@infradead.org" <rdunlap@infradead.org>,
	"damien.lemoal@opensource.wdc.com"
	<damien.lemoal@opensource.wdc.com>,
	"songmuchun@bytedance.com" <songmuchun@bytedance.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"jpoimboe@kernel.org" <jpoimboe@kernel.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"chang.seok.bae@intel.com" <chang.seok.bae@intel.com>,
	"pawan.kumar.gupta@linux.intel.com" 
	<pawan.kumar.gupta@linux.intel.com>,
	"jmattson@google.com" <jmattson@google.com>,
	"daniel.sneddon@linux.intel.com" <daniel.sneddon@linux.intel.com>,
	"Das1, Sandipan" <Sandipan.Das@amd.com>,
	"tony.luck@intel.com" <tony.luck@intel.com>,
	"james.morse@arm.com" <james.morse@arm.com>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bagasdotme@gmail.com" <bagasdotme@gmail.com>,
	"eranian@google.com" <eranian@google.com>,
	"christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>,
	"jarkko@kernel.org" <jarkko@kernel.org>,
	"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
	"quic_jiles@quicinc.com" <quic_jiles@quicinc.com>,
	"peternewman@google.com" <peternewman@google.com>
Subject: Re: [PATCH v9 10/13] x86/resctrl: Add sysfs interface to write mbm_total_bytes_config
Date: Tue, 20 Dec 2022 12:00:59 -0600	[thread overview]
Message-ID: <e9964a9e-92df-e8a3-427d-18f713ae8637@amd.com> (raw)
In-Reply-To: <e7452b29-8e9e-a3e2-a870-2c251e48507d@intel.com>

Hi Reinette,

On 12/20/22 11:32, Reinette Chatre wrote:
> Hi Babu,
>
> On 12/19/2022 11:50 AM, Moger, Babu wrote:
>> Forgot about this.  This snippet is going to change. I have tested and works fine.
>> How about this?
>>
>>         /*
>>          * Update MSR_IA32_EVT_CFG_BASE MSR on one of the CPUs in the
>>          * domain. The MSRs offset from MSR MSR_IA32_EVT_CFG_BASE
>>          * are scoped at the domain level. Writing any of these MSRs
>>          * on one CPU is supposed to be observed by all CPUs in the domain.
>>          */
>>         smp_call_function_any(&d->cpu_mask, mon_event_config_write, &mon_info, 1);
>>
>>
> It looks good but please drop the "supposed to be". If there is any uncertainty
> then the data should be written to all CPUs, if not then that uncertain text should
> be dropped.

There is no uncertainty. I will drop "supposed to be".

Thanks

Babu


  reply	other threads:[~2022-12-20 18:01 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-01 15:35 [PATCH v9 00/13] Support for AMD QoS new features Babu Moger
2022-12-01 15:36 ` [PATCH v9 01/13] x86/cpufeatures: Add Slow Memory Bandwidth Allocation feature flag Babu Moger
2022-12-15 17:08   ` Reinette Chatre
2022-12-15 21:10     ` Moger, Babu
2022-12-01 15:36 ` [PATCH v9 02/13] x86/resctrl: Add a new resource type RDT_RESOURCE_SMBA Babu Moger
2022-12-15 17:10   ` Reinette Chatre
2022-12-15 21:30     ` Moger, Babu
2022-12-01 15:36 ` [PATCH v9 03/13] x86/cpufeatures: Add Bandwidth Monitoring Event Configuration feature flag Babu Moger
2022-12-15 17:11   ` Reinette Chatre
2022-12-19 15:31     ` Moger, Babu
2022-12-01 15:36 ` [PATCH v9 04/13] x86/resctrl: Include new features in command line options Babu Moger
2022-12-15 17:12   ` Reinette Chatre
2022-12-19 15:33     ` Moger, Babu
2022-12-01 15:36 ` [PATCH v9 05/13] x86/resctrl: Detect and configure Slow Memory Bandwidth Allocation Babu Moger
2022-12-15 17:13   ` Reinette Chatre
2022-12-19 15:34     ` Moger, Babu
2022-12-01 15:36 ` [PATCH v9 06/13] x86/resctrl: Add __init attribute to rdt_get_mon_l3_config() Babu Moger
2022-12-15 17:17   ` Reinette Chatre
2022-12-19 15:51     ` Moger, Babu
2022-12-01 15:36 ` [PATCH v9 07/13] x86/resctrl: Introduce data structure to support monitor configuration Babu Moger
2022-12-15 17:19   ` Reinette Chatre
2022-12-19 17:56     ` Moger, Babu
2022-12-01 15:36 ` [PATCH v9 08/13] x86/resctrl: Add sysfs interface to read mbm_total_bytes_config Babu Moger
2022-12-15 17:40   ` Reinette Chatre
2022-12-19 18:21     ` Moger, Babu
2022-12-01 15:37 ` [PATCH v9 09/13] x86/resctrl: Add sysfs interface to read mbm_local_bytes_config Babu Moger
2022-12-15 17:43   ` Reinette Chatre
2022-12-19 18:27     ` Moger, Babu
2022-12-01 15:37 ` [PATCH v9 10/13] x86/resctrl: Add sysfs interface to write mbm_total_bytes_config Babu Moger
2022-12-15 18:24   ` Reinette Chatre
2022-12-19 19:28     ` Moger, Babu
2022-12-20 17:32       ` Reinette Chatre
2022-12-20 18:58         ` Moger, Babu
2022-12-19 19:50     ` Moger, Babu
2022-12-20 17:32       ` Reinette Chatre
2022-12-20 18:00         ` Moger, Babu [this message]
2022-12-01 15:37 ` [PATCH v9 11/13] x86/resctrl: Add sysfs interface to write mbm_local_bytes_config Babu Moger
2022-12-15 18:25   ` Reinette Chatre
2022-12-19 19:51     ` Moger, Babu
2022-12-01 15:37 ` [PATCH v9 12/13] x86/resctrl: Replace smp_call_function_many() with on_each_cpu_mask() Babu Moger
2022-12-15 18:26   ` Reinette Chatre
2022-12-19 19:59     ` Moger, Babu
2022-12-01 15:37 ` [PATCH v9 13/13] Documentation/x86: Update resctrl.rst for new features Babu Moger
2022-12-15 18:30   ` Reinette Chatre
2022-12-19 20:05     ` Moger, Babu
2022-12-15 15:08 ` [PATCH v9 00/13] Support for AMD QoS " Moger, Babu
2022-12-15 15:35   ` Reinette Chatre
2022-12-15 16:12     ` Moger, Babu
2022-12-15 18:38 ` Reinette Chatre
2022-12-19 20:57   ` Moger, Babu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9964a9e-92df-e8a3-427d-18f713ae8637@amd.com \
    --to=babu.moger@amd.com \
    --cc=Sandipan.Das@amd.com \
    --cc=adrian.hunter@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=bagasdotme@gmail.com \
    --cc=bp@alien8.de \
    --cc=chang.seok.bae@intel.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=corbet@lwn.net \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=daniel.sneddon@linux.intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=eranian@google.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=james.morse@arm.com \
    --cc=jarkko@kernel.org \
    --cc=jmattson@google.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=pbonzini@redhat.com \
    --cc=peternewman@google.com \
    --cc=peterz@infradead.org \
    --cc=quic_jiles@quicinc.com \
    --cc=quic_neeraju@quicinc.com \
    --cc=rdunlap@infradead.org \
    --cc=reinette.chatre@intel.com \
    --cc=songmuchun@bytedance.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®