From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751335AbcFAUxB (ORCPT ); Wed, 1 Jun 2016 16:53:01 -0400 Received: from lists.s-osg.org ([54.187.51.154]:34030 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbcFAUw7 (ORCPT ); Wed, 1 Jun 2016 16:52:59 -0400 Subject: Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410 To: Krzysztof Kozlowski , Kevin Hilman References: <1464429273-23457-1-git-send-email-krzk@kernel.org> <1464429273-23457-14-git-send-email-krzk@kernel.org> Cc: Kukjin Kim , Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , linux-arm-kernel , linux-samsung-soc@vger.kernel.org, devicetree , lkml , linux-clk@vger.kernel.org, Rob Herring From: Javier Martinez Canillas Message-ID: Date: Wed, 1 Jun 2016 16:52:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Krzysztof, On 06/01/2016 04:06 PM, Krzysztof Kozlowski wrote: > On Wed, Jun 1, 2016 at 9:57 PM, Kevin Hilman wrote: >> Hi Krzysztof, >> >> On Sat, May 28, 2016 at 2:54 AM, Krzysztof Kozlowski wrote: >>> Just like other Exynos5 family SoCs, this one has four UARTs. Configure >>> clocks for UART3 and enable it. >>> >>> Signed-off-by: Krzysztof Kozlowski >>> Reviewed-by: Javier Martinez Canillas >> >> This patch landed in linux-next[1] and kernelci.org found a boot >> regression on the exynos5410-odroidxu[2], where it looks like it's >> faulting in clk_prepare(). Bisecting pointed to this patch. I added >> "status = disabled" back into the DTS on top of next-20160601[3] and >> verified my odroid-XU to be booting fine again. > > Hi, > > Thanks for report. Indeed the patch brings up to the light an issue in > serial driver. Fixed here: > https://lkml.org/lkml/2016/5/31/570 > > I left the commit in my tree as it is correct (strictly speaking). > Sorry for any trouble it makes. > Kevin pointed me to this issue over IRC and I was able to reproduce it in my Peach Pi by removing the UART3 clocks from the Exynos5420 clock driver. Your patch indeed fixes the issue, I'll add a Reviewed-by on that thread. > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America