mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jammy Huang <jammy_huang@aspeedtech.com>,
	"jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"joel@jms.id.au" <joel@jms.id.au>,
	"andrew@codeconstruct.com.au" <andrew@codeconstruct.com.au>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: mailbox: Add ASPEED AST2700 series SoC
Date: Thu, 5 Jun 2025 07:48:01 +0200	[thread overview]
Message-ID: <e9a1d863-a08c-4f6a-97b3-4a752606544a@kernel.org> (raw)
In-Reply-To: <TYZPR06MB656866677C78C34A5AFDC985F16FA@TYZPR06MB6568.apcprd06.prod.outlook.com>

On 05/06/2025 03:44, Jammy Huang wrote:
>> On 04/06/2025 14:55, Jammy Huang wrote:
>>> +
>>> +examples:
>>> +  - |
>>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> +
>>> +    mailbox@12c1c200 {
>>> +        compatible = "aspeed,ast2700-mailbox";
>>> +        reg = <0x0 0x12c1c200 0x0 0x200>;
>>
>> Last time I asked to test, you responded you will test. What happened?
>> You did not test. This is just disappointing.
> I did test for my last patch. In the end, the errors shown as below did not include ast2700-mailbox.
> So I think it is ok. I will check what's wrong on my environment.

No, it is not ok and with simple dt_binding_check I immediately
reproduced the issue (wrong addresses in example), thus you did not test it.

Best regards,
Krzysztof

  reply	other threads:[~2025-06-05  5:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-04 12:55 [PATCH v2 0/2] ASPEED: Add mailbox driver for AST2700 series Jammy Huang
2025-06-04 12:55 ` [PATCH v2 1/2] dt-bindings: mailbox: Add ASPEED AST2700 series SoC Jammy Huang
2025-06-04 14:10   ` Krzysztof Kozlowski
2025-06-04 14:35   ` Rob Herring (Arm)
2025-06-04 15:19   ` Krzysztof Kozlowski
2025-06-05  1:44     ` Jammy Huang
2025-06-05  5:48       ` Krzysztof Kozlowski [this message]
2025-06-04 12:55 ` [PATCH v2 2/2] mailbox: aspeed: add mailbox driver for AST27XX " Jammy Huang
2025-06-04 12:57 ` [PATCH v2 0/2] ASPEED: Add mailbox driver for AST2700 series Krzysztof Kozlowski
2025-06-04 13:07   ` Jammy Huang
2025-06-04 14:10     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9a1d863-a08c-4f6a-97b3-4a752606544a@kernel.org \
    --to=krzk@kernel.org \
    --cc=andrew@codeconstruct.com.au \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jammy_huang@aspeedtech.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®